[ 
https://issues.apache.org/jira/browse/LUCENE-9513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Zhu updated LUCENE-9513:
------------------------------
    Description: 
In RangeFacetsExample, there is a trivial mistake where

private final long nowSec is supposed to be secs.

But it uses as millisecs.

It doesn't affect the output due to the scale change (It will just make 
PAST_HOUR, PAST_SIX_HOURS not as intended). Still it's better to be correct.

 

I've created a pull request on github with the simple fix.

https://github.com/apache/lucene-solr/pull/1846

  was:
In RangeFacetsExample, there is a trivial mistake where 

private final long nowSec is supposed to be secs. 


But it uses as millisecs.

It doesn't affect the output due to the scale change (It will just make 
PAST_HOUR, PAST_SIX_HOURS not as intended). Still it's better to be correct.

 

I've created a pull request on github with the simple fix.


> Use seconds instead of millisecs
> --------------------------------
>
>                 Key: LUCENE-9513
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9513
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/other
>    Affects Versions: master (9.0), 8.6.2
>            Reporter: Frank Zhu
>            Priority: Trivial
>
> In RangeFacetsExample, there is a trivial mistake where
> private final long nowSec is supposed to be secs.
> But it uses as millisecs.
> It doesn't affect the output due to the scale change (It will just make 
> PAST_HOUR, PAST_SIX_HOURS not as intended). Still it's better to be correct.
>  
> I've created a pull request on github with the simple fix.
> https://github.com/apache/lucene-solr/pull/1846



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to