[GitHub] [lucene-solr] jpountz opened a new pull request #1473: LUCENE-9353: Move terms metadata to its own file.

2020-05-01 Thread GitBox
jpountz opened a new pull request #1473: URL: https://github.com/apache/lucene-solr/pull/1473 See https://issues.apache.org/jira/browse/LUCENE-9353. This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (LUCENE-9331) TestIndexWriterDelete.testDeletesOnDiskFull can run for minutes

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097226#comment-17097226 ] ASF subversion and git services commented on LUCENE-9331: - Commi

[jira] [Commented] (LUCENE-9331) TestIndexWriterDelete.testDeletesOnDiskFull can run for minutes

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097225#comment-17097225 ] ASF subversion and git services commented on LUCENE-9331: - Commi

[jira] [Resolved] (LUCENE-9331) TestIndexWriterDelete.testDeletesOnDiskFull can run for minutes

2020-05-01 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-9331. -- Fix Version/s: 8.6 Resolution: Fixed Thanks Mike! > TestIndexWriterDelete.testDeletesO

[jira] [Commented] (SOLR-13289) Support for BlockMax WAND

2020-05-01 Thread Anshum Gupta (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097234#comment-17097234 ] Anshum Gupta commented on SOLR-13289: - I'm still reviewing the PR but wanted to weigh

[GitHub] [lucene-solr] MarcusSorealheis commented on pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
MarcusSorealheis commented on pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#issuecomment-622290677 Here, I take UI instance that was previously started when ADMIN UI was enabled, disabled the admin ui via system property, and then show the result. THe first chang

[GitHub] [lucene-solr] MarcusSorealheis edited a comment on pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
MarcusSorealheis edited a comment on pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#issuecomment-622290677 Here, I take UI instance that was previously started when ADMIN UI was enabled, disabled the admin ui via system property, and then show the result. The firs

[GitHub] [lucene-solr] janhoy commented on pull request #1463: SOLR-14440 Cert Auth plugin

2020-05-01 Thread GitBox
janhoy commented on pull request #1463: URL: https://github.com/apache/lucene-solr/pull/1463#issuecomment-622292663 Looks good, thanks This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Commented] (SOLR-4587) Implement Saved Searches a la ElasticSearch Percolator

2020-05-01 Thread Rougher Solr (Jira)
[ https://issues.apache.org/jira/browse/SOLR-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097252#comment-17097252 ] Rougher Solr commented on SOLR-4587: Hi everyone, I wrote SOLR Update Processor that

[jira] [Created] (SOLR-14453) Solr proximity search highlighting issue

2020-05-01 Thread amit naliyapara (Jira)
amit naliyapara created SOLR-14453: -- Summary: Solr proximity search highlighting issue Key: SOLR-14453 URL: https://issues.apache.org/jira/browse/SOLR-14453 Project: Solr Issue Type: Bug

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #1467: LUCENE-9350: Don't hold references to large automata on FuzzyQuery

2020-05-01 Thread GitBox
romseygeek commented on a change in pull request #1467: URL: https://github.com/apache/lucene-solr/pull/1467#discussion_r418479566 ## File path: lucene/core/src/java/org/apache/lucene/search/FuzzyTermsEnum.java ## @@ -88,43 +89,44 @@ * @throws IOException if there is a low-

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #1467: LUCENE-9350: Don't hold references to large automata on FuzzyQuery

2020-05-01 Thread GitBox
romseygeek commented on a change in pull request #1467: URL: https://github.com/apache/lucene-solr/pull/1467#discussion_r418480197 ## File path: lucene/core/src/java/org/apache/lucene/search/FuzzyTermsEnum.java ## @@ -88,43 +89,44 @@ * @throws IOException if there is a low-

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #1467: LUCENE-9350: Don't hold references to large automata on FuzzyQuery

2020-05-01 Thread GitBox
romseygeek commented on a change in pull request #1467: URL: https://github.com/apache/lucene-solr/pull/1467#discussion_r418480740 ## File path: lucene/core/src/java/org/apache/lucene/search/FuzzyQuery.java ## @@ -193,7 +172,7 @@ protected TermsEnum getTermsEnum(Terms terms, A

[GitHub] [lucene-solr] thetaphi commented on a change in pull request #1467: LUCENE-9350: Don't hold references to large automata on FuzzyQuery

2020-05-01 Thread GitBox
thetaphi commented on a change in pull request #1467: URL: https://github.com/apache/lucene-solr/pull/1467#discussion_r418482288 ## File path: lucene/core/src/java/org/apache/lucene/search/FuzzyTermsEnum.java ## @@ -88,43 +89,44 @@ * @throws IOException if there is a low-le

[jira] [Created] (LUCENE-9354) Refresh French stop words to remove homonyms

2020-05-01 Thread Philippe (Jira)
Philippe created LUCENE-9354: Summary: Refresh French stop words to remove homonyms Key: LUCENE-9354 URL: https://issues.apache.org/jira/browse/LUCENE-9354 Project: Lucene - Core Issue Type: Impr

[GitHub] [lucene-solr] filcius opened a new pull request #1474: LUCENE-9354: Sync French stop words with latest version from Snowball.

2020-05-01 Thread GitBox
filcius opened a new pull request #1474: URL: https://github.com/apache/lucene-solr/pull/1474 This new version removed some French homonyms from the list # Description Sync French stop words with latest version from Snowball. This new version removed some French homo

[GitHub] [lucene-solr] gunasekhardora commented on a change in pull request #1371: SOLR-14333: print readable version of CollapsedPostFilter query

2020-05-01 Thread GitBox
gunasekhardora commented on a change in pull request #1371: URL: https://github.com/apache/lucene-solr/pull/1371#discussion_r418501691 ## File path: solr/core/src/java/org/apache/solr/search/CollapsingQParserPlugin.java ## @@ -218,7 +245,7 @@ public static GroupHeadSelector bu

[GitHub] [lucene-solr] rmuir commented on pull request #1474: LUCENE-9354: Sync French stop words with latest version from Snowball.

2020-05-01 Thread GitBox
rmuir commented on pull request #1474: URL: https://github.com/apache/lucene-solr/pull/1474#issuecomment-622354621 We shouldn't manually modify these files, but instead update snowball to bring in these stopword changes. We have to bump these commit hashes: https://github.com/apache

[GitHub] [lucene-solr] filcius commented on pull request #1474: LUCENE-9354: Sync French stop words with latest version from Snowball.

2020-05-01 Thread GitBox
filcius commented on pull request #1474: URL: https://github.com/apache/lucene-solr/pull/1474#issuecomment-622358775 Ok, I also updated snowball-website to take the latest master commit. This is an automated message from the

[GitHub] [lucene-solr] filcius commented on pull request #1474: LUCENE-9354: Sync French stop words with latest version from Snowball.

2020-05-01 Thread GitBox
filcius commented on pull request #1474: URL: https://github.com/apache/lucene-solr/pull/1474#issuecomment-622359248 I did not run gradle or compile anything here. I don't have that kind of setup here. If it is required, I propose someone else commit to my branch and continue my work. --

[GitHub] [lucene-solr] filcius commented on pull request #1474: LUCENE-9354: Sync French stop words with latest version from Snowball.

2020-05-01 Thread GitBox
filcius commented on pull request #1474: URL: https://github.com/apache/lucene-solr/pull/1474#issuecomment-622360810 I dont see any other changes in snowball-website, so this may be fine https://github.com/snowballstem/snowball-website/compare/ff891e74f08e7315523ee3c0cad55bb1b7831b9d...mast

[GitHub] [lucene-solr] rmuir commented on pull request #1474: LUCENE-9354: Sync French stop words with latest version from Snowball.

2020-05-01 Thread GitBox
rmuir commented on pull request #1474: URL: https://github.com/apache/lucene-solr/pull/1474#issuecomment-622361321 Yeah, we need to run `./gradlew snowball` after bumping the commit to regenerate such files. Otherwise there are problems caused by doing it manually. In this case a whitespac

[GitHub] [lucene-solr] rmuir commented on pull request #1474: LUCENE-9354: Sync French stop words with latest version from Snowball.

2020-05-01 Thread GitBox
rmuir commented on pull request #1474: URL: https://github.com/apache/lucene-solr/pull/1474#issuecomment-622362638 If you can give me permissions, I can push the stuff to your branch and then we can merge the PR? This is an

[jira] [Commented] (SOLR-14453) Solr proximity search highlighting issue

2020-05-01 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097346#comment-17097346 ] David Smiley commented on SOLR-14453: - Try hl.method=unified > Solr proximity search

[jira] [Commented] (LUCENE-9191) Fix linefiledocs compression or replace in tests

2020-05-01 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097349#comment-17097349 ] Michael McCandless commented on LUCENE-9191: Thanks [~hossman], I didn't kno

[jira] [Commented] (SOLR-4587) Implement Saved Searches a la ElasticSearch Percolator

2020-05-01 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097365#comment-17097365 ] David Eric Pugh commented on SOLR-4587: --- This seems like another great candidate fea

[jira] [Commented] (LUCENE-9191) Fix linefiledocs compression or replace in tests

2020-05-01 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097367#comment-17097367 ] Michael McCandless commented on LUCENE-9191: Hmm, I was able to run and pass

[jira] [Commented] (LUCENE-9148) Move the BKD index to its own file.

2020-05-01 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097370#comment-17097370 ] Adrien Grand commented on LUCENE-9148: -- Something else that is a bit annoying is th

[GitHub] [lucene-solr] filcius commented on pull request #1474: LUCENE-9354: Sync French stop words with latest version from Snowball.

2020-05-01 Thread GitBox
filcius commented on pull request #1474: URL: https://github.com/apache/lucene-solr/pull/1474#issuecomment-622397809 Looks good, thanks @rmuir This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [lucene-solr] jpountz opened a new pull request #1475: LUCENE-9148: Move the BKD index to its own file.

2020-05-01 Thread GitBox
jpountz opened a new pull request #1475: URL: https://github.com/apache/lucene-solr/pull/1475 See https://issues.apache.org/jira/browse/LUCENE-9148. This is only a work-in-progress for now, I'll finish when #1440 is merged to not duplicate work and introduce conflicts.

[jira] [Commented] (LUCENE-9331) TestIndexWriterDelete.testDeletesOnDiskFull can run for minutes

2020-05-01 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097388#comment-17097388 ] Michael McCandless commented on LUCENE-9331: Thank you [~jpountz]! > TestIn

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1473: LUCENE-9353: Move terms metadata to its own file.

2020-05-01 Thread GitBox
msokolov commented on a change in pull request #1473: URL: https://github.com/apache/lucene-solr/pull/1473#discussion_r418558656 ## File path: lucene/core/src/java/org/apache/lucene/codecs/blocktree/BlockTreeTermsReader.java ## @@ -148,56 +155,80 @@ public BlockTreeTermsReader

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1473: LUCENE-9353: Move terms metadata to its own file.

2020-05-01 Thread GitBox
msokolov commented on a change in pull request #1473: URL: https://github.com/apache/lucene-solr/pull/1473#discussion_r418559430 ## File path: lucene/core/src/java/org/apache/lucene/codecs/blocktree/BlockTreeTermsReader.java ## @@ -148,56 +155,80 @@ public BlockTreeTermsReader

[jira] [Commented] (SOLR-13289) Support for BlockMax WAND

2020-05-01 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097399#comment-17097399 ] Michael Sokolov commented on SOLR-13289: It seems to me what we want to convey is

[jira] [Reopened] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler reopened LUCENE-9278: --- Hi, the renderJavadocs task does not work correctly under following circumstances: - Windows: Th

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097429#comment-17097429 ] Uwe Schindler commented on LUCENE-9278: --- In general: Please, please test the full

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097436#comment-17097436 ] Uwe Schindler commented on LUCENE-9278: --- In addition: for the same reason the SPI

[GitHub] [lucene-solr] uschindler opened a new pull request #1476: LUCENE-9278: Fix javadocs task to work on windows and with whitespace in project folder

2020-05-01 Thread GitBox
uschindler opened a new pull request #1476: URL: https://github.com/apache/lucene-solr/pull/1476 This should fix the missing escaping of options in the javadocs options task. This is an automated message from the Apache Git S

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097456#comment-17097456 ] Uwe Schindler commented on LUCENE-9278: --- Here is the PR, I will commit it in a mom

[jira] [Comment Edited] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097456#comment-17097456 ] Uwe Schindler edited comment on LUCENE-9278 at 5/1/20, 3:42 PM: --

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097463#comment-17097463 ] ASF subversion and git services commented on LUCENE-9278: - Commi

[jira] [Resolved] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-9278. --- Resolution: Fixed I merged the change. When running "gradle javadoc" my problem is now that

[GitHub] [lucene-solr] uschindler opened a new pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-01 Thread GitBox
uschindler opened a new pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477 This PR handles the markdown specific parts of the Lucene/Solr documentation: - copy static assets (unfortunetely those are not yet unified between borth projects) - convert .md files

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097488#comment-17097488 ] Uwe Schindler commented on LUCENE-9321: --- I started with markdown and copying of st

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097491#comment-17097491 ] Tomoko Uchida commented on LUCENE-9278: --- Thank you for fixing it. I tested the tas

[jira] [Resolved] (SOLR-14452) "classloading deadlock" issue with DocSet/SortedIntDocSet

2020-05-01 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter resolved SOLR-14452. --- Resolution: Invalid Gah, yes -- i initially found this on a PR branch and ment to dou

[GitHub] [lucene-solr] madrob commented on a change in pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
madrob commented on a change in pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r418622731 ## File path: solr/bin/solr.cmd ## @@ -1288,6 +1295,7 @@ REM '-OmitStackTraceInFastThrow' ensures stack traces in errors, REM users who don't care ab

[GitHub] [lucene-solr] madrob commented on a change in pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-05-01 Thread GitBox
madrob commented on a change in pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r418627559 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java ## @@ -66,4 +80,132 @@ public LBHttp2SolrClient(Http2SolrCl

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
MarcusSorealheis commented on a change in pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r418629568 ## File path: solr/core/src/java/org/apache/solr/servlet/LoadAdminUiServlet.java ## @@ -15,6 +15,13 @@ * limitations under the License. *

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
MarcusSorealheis commented on a change in pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r418630121 ## File path: solr/bin/solr ## @@ -2097,6 +2097,14 @@ else SECURITY_MANAGER_OPTS=() fi +# Enable ADMIN UI by default, and give the opti

[GitHub] [lucene-solr] madrob commented on a change in pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-05-01 Thread GitBox
madrob commented on a change in pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r418628204 ## File path: solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java ## @@ -54,6 +53,10 @@ import org.apache.solr.util.tracing.Gl

[jira] [Commented] (SOLR-13289) Support for BlockMax WAND

2020-05-01 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097507#comment-17097507 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-13289: -- bq. It seems

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-01 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097513#comment-17097513 ] Tomoko Uchida commented on LUCENE-9321: --- I left a comment about javadocs destinati

[jira] [Commented] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097517#comment-17097517 ] ASF subversion and git services commented on LUCENE-7788: - Commi

[jira] [Commented] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097518#comment-17097518 ] ASF subversion and git services commented on LUCENE-7788: - Commi

[GitHub] [lucene-solr] madrob commented on a change in pull request #341: SOLR-12131: ExternalRoleRuleBasedAuthorizationPlugin

2020-05-01 Thread GitBox
madrob commented on a change in pull request #341: URL: https://github.com/apache/lucene-solr/pull/341#discussion_r418632788 ## File path: solr/core/src/java/org/apache/solr/security/PrincipalWithUserRoles.java ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Founda

[jira] [Resolved] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

2020-05-01 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved LUCENE-7788. Fix Version/s: 8.6 Resolution: Fixed These checks are now wired in to gradle, both

[jira] [Resolved] (SOLR-11884) find/fix inefficiencies in our use of logging

2020-05-01 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-11884. --- Fix Version/s: 7.4 Resolution: Fixed The specific problem with %C was fixed in Solr 7.

[jira] [Commented] (SOLR-14430) Authorization plugins should check roles from request

2020-05-01 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097524#comment-17097524 ] Mike Drob commented on SOLR-14430: -- I think that's definitely movement in the right dire

[jira] [Resolved] (SOLR-10415) Within solr-core, debug/trace level logging should use parameterized log messages

2020-05-01 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-10415. --- Fix Version/s: 8.6 Resolution: Fixed All the logging calls are either 1> parameterized

[GitHub] [lucene-solr] madrob commented on a change in pull request #1467: LUCENE-9350: Don't hold references to large automata on FuzzyQuery

2020-05-01 Thread GitBox
madrob commented on a change in pull request #1467: URL: https://github.com/apache/lucene-solr/pull/1467#discussion_r418642710 ## File path: lucene/core/src/java/org/apache/lucene/search/FuzzyTermsEnum.java ## @@ -88,43 +89,44 @@ * @throws IOException if there is a low-leve

[GitHub] [lucene-solr] madrob commented on a change in pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
madrob commented on a change in pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r418644915 ## File path: solr/bin/solr ## @@ -2097,6 +2097,14 @@ else SECURITY_MANAGER_OPTS=() fi +# Enable ADMIN UI by default, and give the option for use

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
MarcusSorealheis commented on a change in pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r418646100 ## File path: solr/bin/solr ## @@ -2097,6 +2097,14 @@ else SECURITY_MANAGER_OPTS=() fi +# Enable ADMIN UI by default, and give the opti

[GitHub] [lucene-solr] uschindler commented on pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-01 Thread GitBox
uschindler commented on pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#issuecomment-622489584 For now I have no idea how to handle the last task, so I left it as nocommit. @mocobeta: any ideas how to get the relative path and the title of all projects below lucene

[jira] [Resolved] (SOLR-14440) Provide Certificate Authentication Plugin

2020-05-01 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-14440. -- Fix Version/s: master (9.0) Resolution: Fixed > Provide Certificate Authentication Plugin >

[jira] [Assigned] (SOLR-14440) Provide Certificate Authentication Plugin

2020-05-01 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob reassigned SOLR-14440: Assignee: Mike Drob > Provide Certificate Authentication Plugin >

[jira] [Commented] (SOLR-14440) Provide Certificate Authentication Plugin

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097547#comment-17097547 ] ASF subversion and git services commented on SOLR-14440: Commit 7

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097550#comment-17097550 ] Uwe Schindler commented on LUCENE-9321: --- Hi, yes please. Could you still have a lo

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097551#comment-17097551 ] Uwe Schindler commented on LUCENE-9321: --- I cant proceed with the index.html/index.

[jira] [Commented] (SOLR-14440) Provide Certificate Authentication Plugin

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097562#comment-17097562 ] ASF subversion and git services commented on SOLR-14440: Commit 3

[jira] [Commented] (SOLR-14440) Provide Certificate Authentication Plugin

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097564#comment-17097564 ] ASF subversion and git services commented on SOLR-14440: Commit a

[jira] [Commented] (SOLR-14440) Provide Certificate Authentication Plugin

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097568#comment-17097568 ] ASF subversion and git services commented on SOLR-14440: Commit 2

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097569#comment-17097569 ] Dawid Weiss commented on LUCENE-9321: - I this should be done this way: the task that

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-01 Thread GitBox
dweiss commented on a change in pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#discussion_r418669624 ## File path: gradle/documentation/markdown.gradle ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097573#comment-17097573 ] Uwe Schindler commented on LUCENE-9321: --- Sorry I still disagree with this: - On Wi

[jira] [Comment Edited] (LUCENE-9321) Port documentation task to gradle

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097573#comment-17097573 ] Uwe Schindler edited comment on LUCENE-9321 at 5/1/20, 6:21 PM: --

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
MarcusSorealheis commented on a change in pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r418671239 ## File path: solr/bin/solr ## @@ -2097,6 +2097,14 @@ else SECURITY_MANAGER_OPTS=() fi +# Enable ADMIN UI by default, and give the opti

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
MarcusSorealheis commented on a change in pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r418677843 ## File path: solr/bin/solr.cmd ## @@ -1288,6 +1295,7 @@ REM '-OmitStackTraceInFastThrow' ensures stack traces in errors, REM users who don

[jira] [Resolved] (SOLR-11936) maven urls should use https

2020-05-01 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-11936. -- Resolution: Duplicate > maven urls should use https > --- > > K

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097586#comment-17097586 ] Dawid Weiss commented on LUCENE-9321: - bq. So why are you arguing to have the javado

[jira] [Commented] (SOLR-14430) Authorization plugins should check roles from request

2020-05-01 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097593#comment-17097593 ] Jan Høydahl commented on SOLR-14430: I’m not currently working on this feature, so fe

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097594#comment-17097594 ] Dawid Weiss commented on LUCENE-9278: - I'm on Windows and backslashes work(ed) just

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097599#comment-17097599 ] Uwe Schindler commented on LUCENE-9278: --- The issue is already solved, for backgrou

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097602#comment-17097602 ] Dawid Weiss commented on LUCENE-9278: - Answering myself: it can be a regular Windows

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097606#comment-17097606 ] Dawid Weiss commented on LUCENE-9278: - bq. The issue is already solved, for backgrou

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097605#comment-17097605 ] Uwe Schindler commented on LUCENE-9278: --- Exactly! See my comment, too. > Make jav

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097610#comment-17097610 ] Uwe Schindler commented on LUCENE-9278: --- IMHO to improve this, we should build the

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
MarcusSorealheis commented on a change in pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r418689669 ## File path: solr/core/src/java/org/apache/solr/servlet/LoadAdminUiServlet.java ## @@ -24,29 +31,26 @@ import org.apache.solr.core.CoreCont

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097619#comment-17097619 ] Uwe Schindler commented on LUCENE-9278: --- I have to look it up. The source code of

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097628#comment-17097628 ] Dawid Weiss commented on LUCENE-9278: - Gradle javadoc task sucks in many ways... And

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097635#comment-17097635 ] Uwe Schindler commented on LUCENE-9278: --- The standard doclet issue is the typical

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097637#comment-17097637 ] Uwe Schindler commented on LUCENE-9278: --- bq. We can build the options file with th

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097638#comment-17097638 ] Uwe Schindler commented on LUCENE-9278: --- Sorry map won't work, but similar data st

[GitHub] [lucene-solr] madrob commented on a change in pull request #1371: SOLR-14333: print readable version of CollapsedPostFilter query

2020-05-01 Thread GitBox
madrob commented on a change in pull request #1371: URL: https://github.com/apache/lucene-solr/pull/1371#discussion_r418718546 ## File path: solr/core/src/java/org/apache/solr/search/CollapsingQParserPlugin.java ## @@ -128,6 +128,28 @@ field collapsing (with ngroups) when the

[GitHub] [lucene-solr] janhoy commented on a change in pull request #341: SOLR-12131: ExternalRoleRuleBasedAuthorizationPlugin

2020-05-01 Thread GitBox
janhoy commented on a change in pull request #341: URL: https://github.com/apache/lucene-solr/pull/341#discussion_r418721727 ## File path: solr/core/src/java/org/apache/solr/security/PrincipalWithUserRoles.java ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [lucene-solr] janhoy commented on a change in pull request #341: SOLR-12131: ExternalRoleRuleBasedAuthorizationPlugin

2020-05-01 Thread GitBox
janhoy commented on a change in pull request #341: URL: https://github.com/apache/lucene-solr/pull/341#discussion_r418722327 ## File path: solr/core/src/java/org/apache/solr/security/PrincipalWithUserRoles.java ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Founda

[jira] [Commented] (SOLR-13132) Improve JSON "terms" facet performance when sorted by relatedness

2020-05-01 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097660#comment-17097660 ] Michael Gibney commented on SOLR-13132: --- I was worrying about the order of sort key

[GitHub] [lucene-solr] janhoy commented on a change in pull request #341: SOLR-12131: ExternalRoleRuleBasedAuthorizationPlugin

2020-05-01 Thread GitBox
janhoy commented on a change in pull request #341: URL: https://github.com/apache/lucene-solr/pull/341#discussion_r418725066 ## File path: solr/core/src/java/org/apache/solr/security/RuleBasedAuthorizationPluginBase.java ## @@ -0,0 +1,270 @@ +/* + * Licensed to the Apache Soft

[jira] [Created] (LUCENE-9355) missing releases from testbackwardscompatibility

2020-05-01 Thread Mike Drob (Jira)
Mike Drob created LUCENE-9355: - Summary: missing releases from testbackwardscompatibility Key: LUCENE-9355 URL: https://issues.apache.org/jira/browse/LUCENE-9355 Project: Lucene - Core Issue Type

[jira] [Commented] (SOLR-10814) Solr RuleBasedAuthorization config doesn't work seamlessly with kerberos authentication

2020-05-01 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097668#comment-17097668 ] Mike Drob commented on SOLR-10814: -- [~hgadre] - do you have any interest in picking this

  1   2   >