Re: [PATCH] Delete powerpcspe

On Thu, Dec 13, 2018 at 09:49:51AM -0700, Jeff Law wrote: > On 12/12/18 10:33 AM, Segher Boessenkool wrote: > > On Wed, Dec 12, 2018 at 11:36:29AM +0100, Richard Biener wrote: > >> On Tue, Dec 11, 2018 at 2:37 PM Jeff Law wrote: > >>> One way to deal with these problems is to create a fake simulat

Re: [PATCH] Fix stmt folding in the inliner (PR tree-optimization/88444)

On Thu, 13 Dec 2018, Jeff Law wrote: > On 12/13/18 3:59 PM, Jakub Jelinek wrote: > > Hi! > > > > The inliner doesn't want to fold statements immediately, but records them > > and then fold_marked_statements is meant to fold them when inlining is done. > > > > On the following testcase it doesn't

Re: [PATCH, middle-end/i386]: Fix PR88474, Inline built-in hypot for -ffast-math

On Fri, 14 Dec 2018, Uros Bizjak wrote: > Attached patch inlines calls to hypotf and hypot using x87 XFmode arithmetic. > > 2018-12-14 Uros Bizjak > > PR target/88474 > * internal-fn.def (HYPOT): New. > * optabs.def (hypot_optab): New. > * config/i386/i386.md (hypot3): New exp

Re: [PATCH] match_asm_constraints: Use copy_rtx where needed (PR88001)

On Thu, Dec 13, 2018 at 11:09:14AM -0700, Jeff Law wrote: > On 12/12/18 1:22 PM, Segher Boessenkool wrote: > > The new insn here (temporarily) illegally shares RTL. This fixes it. > > > > Tested with an ARC cross, and regstrapped on powerpc64-linux {-m32,-m64}. > > Is this okay for trunk? > > >

Re: [PATCH] Delete powerpcspe

> On 14 Dec 2018, at 08:20, Segher Boessenkool > wrote: > > On Thu, Dec 13, 2018 at 09:49:51AM -0700, Jeff Law wrote: >> On 12/12/18 10:33 AM, Segher Boessenkool wrote: >>> On Wed, Dec 12, 2018 at 11:36:29AM +0100, Richard Biener wrote: On Tue, Dec 11, 2018 at 2:37 PM Jeff Law wrote: >>>

Re: [PATCH] [RFC] PR target/52813 and target/11807

On Thu, Dec 13, 2018 at 11:26:40PM +0200, Dimitar Dimitrov wrote: > On Thu, Dec 13, 2018 at 8:48:38 EET Segher Boessenkool wrote: > > On Wed, Dec 12, 2018 at 06:26:10PM +0200, Dimitar Dimitrov wrote: > > > I expect that if I mark a HW register as "clobber", compiler would save > > > its > > > conte

Re: [PATCH] Added information about inline assembler in stack calculations (.su files)

On Thu, Dec 13, 2018 at 05:31:28PM -0700, Jeff Law wrote: > On 12/7/18 4:35 PM, Segher Boessenkool wrote: > > Would that work well? Only warn for naked functions? It would work > > better for all users that do *not* mess with the stack in their asm ;-) > What I'm questioning is whether or not thi

[committed, GCC-8, Arm] Backport of PR target/88224

Hi, I committed a tweaked backport of https://gcc.gnu.org/ml/gcc-patches/2018-11/msg02276.html to the gcc-8-branch in r267124. There was a small subtle difference, since in GCC-8 we didn't enable fpu by default for cores, so rather than changing the default to use the right fpu, I changed the

Re: [PATCH] error on missing LTO symbols

On 13-12-18 14:44, Jakub Jelinek wrote: > On Thu, Dec 13, 2018 at 02:31:45PM +0100, Tom de Vries wrote: >>> 2015-07-24 Cesar Philippidis > > Please use current date ;) > >>> >>> gcc/ >>> * lto-cgraph.c (input_overwrite_node): Error instead of assert >>> on missing cgraph partitions

[Patch, PR 88253, combine] Prevent combine simplification to zero if side_effects_p

Hi, This patch fixes PR 88253 by preventing combine_simplify_rtx from folding an rtx with side_effects_p to const0_rtx. Without the patch, combine deletes volatile loads from memory in certain cases. When combine_simplify_rtx is called with op0_mode = E_HImode and rtx like (subreg:QI (ashift:HI

[PATCH] Remove duplicated code block in gimple-ssa-split-paths.c

Jeffs last commit added the fix twice. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2018-12-14 Richard Biener * gimple-ssa-split-paths.c (is_feasible_trace): Remove duplicated code block. Index: gcc/gimple-ssa-split-paths.c ===

Re: add taishanv110 pipeline scheduling

Hi Wuyuan, On 06/12/2018 01:31, wuyuan (E) wrote: > Hi ARM maintainers: > The taishanv110 core uses generic pipeline scheduling, which > restricted the performance of taishanv110 core. By adding the pipeline > scheduling of taishanv110 core in GCC,The performance of taishanv110 has been

Re: [PATCH] Improve gimplification of constructors with RANGE_EXPRs (PR c++/82294, PR c++/87436)

On Fri, 14 Dec 2018, Jakub Jelinek wrote: > Hi! > > With the previously posted patch to use RANGE_EXPRs in build_vec_init, > the following patch attempts to do what the reporters were asking for > - determine if it wouldn't be more efficient to use (perhaps nested) loops > to initialize at runtim

[committed][testsuite] Remove bashism from libbacktrace/allocfail.sh

Hi, Test-case libbacktrace/allocfail.sh contains bashism "set -o pipefail", which makes the script fail on ubuntu 18.04, which links /bin/sh to /bin/dash. Fix this by removing the "set -o pipefail". Tested by running the test-case with dash on x86_64-linux. Committed to trunk. Thanks, - Tom [

Re: [PATCH] Delete powerpcspe

On Thu, Dec 13, 2018 at 5:49 PM Jeff Law wrote: > > On 12/12/18 10:33 AM, Segher Boessenkool wrote: > > On Wed, Dec 12, 2018 at 11:36:29AM +0100, Richard Biener wrote: > >> On Tue, Dec 11, 2018 at 2:37 PM Jeff Law wrote: > >>> One way to deal with these problems is to create a fake simulator that

Re: [PATCH] error on missing LTO symbols

On Fri, Dec 14, 2018 at 10:21:35AM +0100, Tom de Vries wrote: > Build and reg-tested on x86_64 with nvptx accelerator. > > 2018-12-13 Tom de Vries > > * lto-cgraph.c (verify_node_partition): New function. > (input_overwrite_node, input_varpool_node): Use verify_node_partition. > >

Re: [PATCH] error on missing LTO symbols

On Fri, Dec 14, 2018 at 10:21:35AM +0100, Tom de Vries wrote: > --- /dev/null > +++ b/libgomp/testsuite/libgomp.c-c++-common/variable-not-offloaded.c > @@ -0,0 +1,21 @@ > +/* { dg-do link } */ > +/* { dg-excess-errors "lto1, mkoffload and lto-wrapper fatal errors" } */ > + > +int results[2000]; /*

Re: [PATCH] error on missing LTO symbols

Hi Tom! Thanks for looking into this one! Just one quick comment: On Fri, 14 Dec 2018 10:21:35 +0100, Tom de Vries wrote: > --- a/gcc/lto-cgraph.c > +++ b/gcc/lto-cgraph.c > +#ifdef ACCEL_COMPILER > + if (in_other_partition) > +{ > + if (TREE_CODE (decl) == FUNCTION_DECL > + ||

Re: [PATCH 01/10] Fix LRA bug

On 13/12/2018 23:49, Jeff Law wrote: OK. But be aware we may have to revisit and look more closely what what you're doing in your port if we stumble over more problems with reload changing the structure of your insns and causing problems in the process. Thanks. What's novel about this, I thin

Re: [PATCH v4][C][ADA] use function descriptors instead of trampolines in C

Am Donnerstag, den 13.12.2018, 16:35 -0700 schrieb Jeff Law: > On 12/12/18 11:12 AM, Uecker, Martin wrote: ... > > > > diff --git a/gcc/c/c-objc-common.h b/gcc/c/c-objc-common.h > > > > index 78e768c2366..ef039560eb9 100644 > > > > --- a/gcc/c/c-objc-common.h > > > > +++ b/gcc/c/c-objc-common.h

Re: [PATCH] x86: Add -march=cascadelake

The part 2 is implemented by attached patch. Ok for trunk? Wei gcc/ * config/i386/driver-i386.c (host_detect_local_cpu): Detect cascadelake. * config/i386/i386.c (fold_builtin_cpu): Handle cascadelake. * doc/extend.texi: Add cascadelake. gcc/testsuite/ * g++.target/i3

RE: [PATCH 0/2][ARC] Fixes needed for the upcomming release.

Thank you Andrew for your quick review. Both patches are committed. Claudiu From: Claudiu Zissulescu [claz...@gmail.com] Sent: Tuesday, December 11, 2018 11:23 AM To: gcc-patches@gcc.gnu.org Cc: francois.bed...@synopsys.com; claudiu.zissule...@synopsys.com;

Re: [PATCH] x86: Add -march=cascadelake

On Fri, Dec 14, 2018 at 06:33:37PM +0800, Wei Xiao wrote: --- a/gcc/config/i386/driver-i386.c +++ b/gcc/config/i386/driver-i386.c @@ -832,8 +832,16 @@ const char *host_detect_local_cpu (int argc, const char **argv) cpu = "skylake"; break; case 0x55: - /* Skylake

[Ada] Small fix for records with boolean discriminants

The point is to avoid building comparisons of the form "D == true" in this case for the qualifiers of the union describing the variant part because 1) it's useless and 2) it's output as "D = 1" by -gnatR, which is not valid Ada. The dwarf2out.c change only affects the Ada compiler. Tested on x8

Re: [PATCH] Improve gimplification of constructors with RANGE_EXPRs (PR c++/82294, PR c++/87436)

On Fri, Dec 14, 2018 at 10:40:19AM +0100, Richard Biener wrote: > This looks OK to me - the only comment I have is on the two magic > constants (64 and 8) which are used twice in the patch. Can you > either see to hoist the common condition into sth like > > bool prefer_loop_initializer_p = ...

[Ada] Fix Max_Size_In_Storage_Elements for unconstrained array types

It appears that GNAT was not fully compliant with the intent of the RM here because it wouldn't include the size of the bounds added in front of the data in an allocation in the value of Max_Size_In_Storage_Elements. Tested on x86_64-suse-linux, applied on the mainline. 2018-12-14 Eric Botcaz

Re: [committed][testsuite] Remove bashism from libbacktrace/allocfail.sh

On Fri, Dec 14, 2018 at 10:48:26AM +0100, Tom de Vries wrote: > Test-case libbacktrace/allocfail.sh contains bashism "set -o pipefail", which > makes the script fail on ubuntu 18.04, which links /bin/sh to /bin/dash. > > Fix this by removing the "set -o pipefail". > > Tested by running the test-c

Re: [PATCH] Improve gimplification of constructors with RANGE_EXPRs (PR c++/82294, PR c++/87436)

On Fri, 14 Dec 2018, Jakub Jelinek wrote: > On Fri, Dec 14, 2018 at 10:40:19AM +0100, Richard Biener wrote: > > This looks OK to me - the only comment I have is on the two magic > > constants (64 and 8) which are used twice in the patch. Can you > > either see to hoist the common condition into s

Re: [PATCH 01/10] Fix LRA bug

On 14/12/2018 10:04, Andrew Stubbs wrote: Anyway, this patch should not affect any use case that did not already have UB, so I'll get it committed shortly. Now done. Thanks for the review. Andrew

Re: [PATCH] error on missing LTO symbols

[ cc-ing HSAIL maintainer ] On 14-12-18 10:54, Jakub Jelinek wrote: > On Fri, Dec 14, 2018 at 10:21:35AM +0100, Tom de Vries wrote: >> Build and reg-tested on x86_64 with nvptx accelerator. >> >> 2018-12-13 Tom de Vries >> >> * lto-cgraph.c (verify_node_partition): New function. >> (i

Re: [PATCH] error on missing LTO symbols

On Fri, Dec 14, 2018 at 02:07:18PM +0100, Tom de Vries wrote: > Done, using offload_device_nonshared_as for > libgomp.c-c++-common/variable-not-offloaded.c and > openacc_nvidia_accel_configured for > libgomp.oacc-c-c++-common/function-not-offloaded.c. > > > Otherwise LGTM. > > Updated patch OK?

Re: [PATCH] error on missing LTO symbols

On 14-12-18 14:08, Jakub Jelinek wrote: > On Fri, Dec 14, 2018 at 02:07:18PM +0100, Tom de Vries wrote: >> Done, using offload_device_nonshared_as for >> libgomp.c-c++-common/variable-not-offloaded.c and >> openacc_nvidia_accel_configured for >> libgomp.oacc-c-c++-common/function-not-offloaded.c. >

[PATCH] Fix PR84521

This fixes and simplifies the setjmp and non-local goto implementation. Currently the virtual frame pointer is saved when using __builtin_setjmp or a non-local goto. Depending on whether a frame pointer is used, this may either save SP or FP with an immediate offset. However the goto or longjmp a

Re: [PATCH] error on missing LTO symbols

On Fri, Dec 14, 2018 at 02:17:49PM +0100, Tom de Vries wrote: > Build x86_64 and reg-tested libgomp. > > 2018-12-13 Tom de Vries > > * lto-cgraph.c (verify_node_partition): New function. > (input_overwrite_node, input_varpool_node): Use verify_node_partition. > > * testsuite

Re: [PATCH] [RFC] PR target/52813 and target/11807

(Maybe the discussion has moved on from this already -- sorry if so) Christophe Lyon writes: > On Wed, 12 Dec 2018 at 12:21, Thomas Preudhomme > wrote: >> >> So my understanding is that the original code (CMSIS library) used to >> clobber sp because the asm statement was actually changing the sp

Re: [PATCH 0/6, OpenACC, libgomp] Async re-work

Hi Chung-Lin! On Thu, 06 Dec 2018 21:42:14 +0100, I wrote: > On Tue, 25 Sep 2018 21:09:49 +0800, Chung-Lin Tang > wrote: > > Also included in this patch is the code for the acc_get/set_default_async > > API functions in OpenACC 2.5. > > It's a minor part of this patch, but since some code was m

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts

Hi Chung-Lin! On Fri, 7 Dec 2018 22:19:14 +0800, Chung-Lin Tang wrote: > On 2018/12/7 07:32 PM, Thomas Schwinge wrote: > > Does the following make sense? > > I don't quite remember why I simply ensured asyncqueue creation here at the > time, > maybe simply because it allowed simpler code at th

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts

Hi Chung-Lin! On Tue, 25 Sep 2018 21:10:47 +0800, Chung-Lin Tang wrote: > --- a/libgomp/oacc-async.c > +++ b/libgomp/oacc-async.c > +attribute_hidden struct goacc_asyncqueue * > +lookup_goacc_asyncqueue (struct goacc_thread *thr, bool create, int async) > +{ > + /* The special value acc_async_

Re: [C++ PATCH] Use RANGE_EXPRs in build_vec_init (PR c++/82294, PR c++/87436)

OK. On Thu, Dec 13, 2018 at 6:03 PM Jakub Jelinek wrote: > > Hi! > > The following patch makes use of RANGE_EXPRs in build_vec_init, instead of > appending many ctor elements. > > E.g. on the PR87436 testcase the memory usage goes down from more than 5GB > to a few megabytes and compile time decre

Re: [PATCH 0/6, OpenACC, libgomp] Async re-work

Hi Chung-Lin! A little bit of documentation starter update for you to include. Please make sure that all relevant functions have such comments addded. commit 7e0896281d155e1544751f43c1eaace8e005e019 Author: Thomas Schwinge Date: Thu Dec 13 17:59:46 2018 +0100 [WIP] into async re-work: do

Re: [PATCH 0/6, OpenACC, libgomp] Async re-work

On 2018/12/13 11:51 PM, Thomas Schwinge wrote: On Thu, 13 Dec 2018 23:28:49 +0800, Chung-Lin Tang wrote: On 2018/12/7 6:26 AM, Julian Brown wrote: On Thu, 6 Dec 2018 22:22:46 + Julian Brown wrote: On Thu, 6 Dec 2018 21:42:14 +0100 Thomas Schwinge wrote: [...] ..., where the "Invalid

Re: [PATCH] [PR87012] canonicalize ref type for tmpl arg

On Thu, Dec 13, 2018 at 8:37 PM Alexandre Oliva wrote: > On Dec 5, 2018, Jason Merrill wrote: > > > I would expect that this same issue would come up with other types; I > > think we want to fix this sooner, when we are figuring out what type > > we want to convert the argument to. > > You mean

Re: [PATCH] [PR86823] retain deferred access checks from outside firewall

OK. On Thu, Dec 13, 2018 at 8:35 PM Alexandre Oliva wrote: > > On Dec 6, 2018, Alexandre Oliva wrote: > > > I'm giving your proposed patch a full round of testing along with other > > patches. > > [PR86823] retain deferred access checks from outside firewall > > We used to preserve deferred acce

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts

Hi Chung-Lin! On Tue, 25 Sep 2018 21:10:47 +0800, Chung-Lin Tang wrote: > void > acc_wait_async (int async1, int async2) > { > + struct goacc_thread *thr = get_goacc_thread (); > > + goacc_aq aq2 = lookup_goacc_asyncqueue (thr, true, async2); > + goacc_aq aq1 = lookup_goacc_asyncqueue (t

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts

On 2018/12/14 10:32 PM, Thomas Schwinge wrote: Invoked as "acc_wait_async ([...], acc_async_sync)" (as used in a test case that I'll soon submit/commit), we'll end up with "aq2 == NULL", and will segfault in the nvptx "openacc.async.serialize_func". What does "wait async(acc_async_sync)" suppos

[PATCH v2] [MIPS] GCC: Fix Loongson3 LLSC Errata

From: Paul Hua In some older Loongson3 processors there is a LL/SC errata that can cause the CPU to deadlock occasionally. The details are very complicated. We find a way to work around this errata by a) adding a sync before ll/lld instruction, b) adding a sync before branch target that betwee

Re: Too strict synchronization with the local (host) thread?

Hi Chung-Lin! On Tue, 11 Dec 2018 21:30:31 +0800, Chung-Lin Tang wrote: > On 2018/12/7 11:56 PM, Thomas Schwinge wrote: > >> --- a/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-79.c > >> +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-79.c > >> @@ -114,6 +114,7 @@ main (int argc, char **

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts

On 2018/12/14 10:17 PM, Thomas Schwinge wrote: Hi Chung-Lin! On Tue, 25 Sep 2018 21:10:47 +0800, Chung-Lin Tang wrote: --- a/libgomp/oacc-async.c +++ b/libgomp/oacc-async.c +attribute_hidden struct goacc_asyncqueue * +lookup_goacc_asyncqueue (struct goacc_thread *thr, bool create, int asyn

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts

Hi Chung-Lin! On Tue, 25 Sep 2018 21:10:47 +0800, Chung-Lin Tang wrote: > --- a/libgomp/oacc-parallel.c > +++ b/libgomp/oacc-parallel.c > @@ -377,8 +360,6 @@ GOACC_enter_exit_data (int device, size_t mapnum, > finalize = true; > } > > - acc_dev->openacc.async_set_async_func (async)

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts

Hi Chung-Lin! On Tue, 25 Sep 2018 21:10:47 +0800, Chung-Lin Tang wrote: > --- a/libgomp/oacc-async.c > +++ b/libgomp/oacc-async.c > +attribute_hidden struct goacc_asyncqueue * > +lookup_goacc_asyncqueue (struct goacc_thread *thr, bool create, int async) > +{ > + /* The special value acc_async_

Re: [PATCH 2/6, OpenACC, libgomp] Async re-work, oacc-* parts

On 2018/12/14 10:53 PM, Thomas Schwinge wrote: Additionally the following, or why not? Please comment on the one TODO which before your async re-work also was -- incorrectly? -- run asynchronously? diff --git libgomp/oacc-parallel.c libgomp/oacc-parallel.c index 5a441c9efe38..91875c57fc97 10

Re: [PATCH 0/6, OpenACC, libgomp] Async re-work

Hi Chung-Lin! On Tue, 25 Sep 2018 21:09:49 +0800, Chung-Lin Tang wrote: > This patch is a re-organization of OpenACC asynchronous queues. Again, many thanks for that! In addition to the review emails I just posted, I've also put all that stuff into a GitHub branch:

Re: [PATCH] [MSP430] Fix gcc.dg/pr85180.c and gcc.dg/pr87985.c timeouts for msp430-elf -mlarge

Hi Segher, Thanks for the review. On Wed, 12 Dec 2018 19:47:53 -0600 Segher Boessenkool wrote: > The unused bits in a MODE_PARTIAL_INT value are undefined, so nonzero_bits > isn't valid for conversion in either direction. > > And *which* bits are undefined isn't defined anywhere either, so we c

Re: [PATCH 1/3][GCC] Add new target hook asm_post_cfi_startproc

On 12/13/18 7:03 PM, Jason Merrill wrote: > And this seems consistent with the other stuff in > dwarf2out_do_cfi_startproc.  You might amend the documentation to > mention that the expected use is to add more .cfi_* directives. OK > with that change. > > Jason Hi Jason, Thanks for the approva

Re: [PATCH] Delete powerpcspe

On 12/14/18 2:52 AM, Richard Biener wrote: > On Thu, Dec 13, 2018 at 5:49 PM Jeff Law wrote: >> >> On 12/12/18 10:33 AM, Segher Boessenkool wrote: >>> On Wed, Dec 12, 2018 at 11:36:29AM +0100, Richard Biener wrote: On Tue, Dec 11, 2018 at 2:37 PM Jeff Law wrote: > One way to deal with th

Re: [PATCH] Delete powerpcspe

On 12/14/18 1:20 AM, Segher Boessenkool wrote: > On Thu, Dec 13, 2018 at 09:49:51AM -0700, Jeff Law wrote: >> On 12/12/18 10:33 AM, Segher Boessenkool wrote: >>> On Wed, Dec 12, 2018 at 11:36:29AM +0100, Richard Biener wrote: On Tue, Dec 11, 2018 at 2:37 PM Jeff Law wrote: > One way to de

Re: [PATCH, GCC, AARCH64, 5/6] Enable BTI : Add new pass for BTI.

Hi James On 29/11/18 16:47, Sudakshina Das wrote: > Hi > > On 13/11/18 14:47, Sudakshina Das wrote: >> Hi >> >> On 02/11/18 18:38, Sudakshina Das wrote: >>> Hi >>> >>> This patch is part of a series that enables ARMv8.5-A in GCC and >>> adds Branch Target Identification Mechanism. >>> (https://de

Re: [PATCH, ARM] Improve robustness of -mslow-flash-data

Hi Thomas, On 11/12/18 16:09, Thomas Preudhomme wrote: Hi Kyrill, I've tested on armeb-none-eabi with -mslow-flash-data for both -mfloat-abi=hard and -mfloat-abi=soft. Both show no regression and the former shows some new PASS. Regarding the part you are hesitant about, the code was taken from

Re: Add a loop versioning pass

Richard Biener writes: > On December 12, 2018 7:43:10 PM GMT+01:00, Richard Sandiford > wrote: >>Richard Biener writes: >>> On Thu, Dec 6, 2018 at 2:19 PM Richard Sandiford Tested on x86_64-linux-gnu, aarch64-linux-gnu and aarch64_be-elf. Also repeated the performance testing (but hav

[committed] Fix minor goof in last change for TARGET_ASM_POST_CFI_STARTPROC

It looks like Jason asked Sam to make a last minute doc change. Sam made that change in the tm.texi file, but target.def has the old text. This causes a build failure. I'm guessing the wrong target.def was committed. Regardless the fix is trivial. Jeff diff --git a/gcc/target.def b/gcc/target

Re: [PATCH 1/6, OpenACC, libgomp] Async re-work, interfaces

Hi! A few more -- final? ;-) -- comments: On Tue, 25 Sep 2018 21:10:21 +0800, Chung-Lin Tang wrote: > This patch separates out the header interface changes. GOMP_VERSION has been > bumped, > and various changes to the plugin interface, and a few libgomp internal > functions > declared. The li

Re: [PATCH, libphobos] Committed remove unused internal modules

On Mon, 19 Nov 2018 at 00:40, Iain Buclaw wrote: > > Hi, > > This patch removes two x86-centric modules that are ignored as gdc > doesn't implement the D_InlineAsm version condition. Bootstrapped and > testsuite ran on x86_64-linux-gnu. > > Committed to trunk as r266256 > > -- > Iain > --- > libp

Linux x86 unwinder: Handle __NR_sigreturn for __kernel_sigreturn support

I believe this may address recent unwinder failures in Fedora if the vDSO unwinder does not contain unwinding data: The question is: Do we want to move in that direction? Or should we make clear that the userspace ABI *requires* unwinding i

Re: [PATCH] Delete powerpcspe

On Fri, 14 Dec 2018, Jeff Law wrote: > > I wonder if we could set up auto-(simulator)-testing for all supported > > archs (and build testing for all supported configs) on the CF > > (with the required scripting in contrib/ so it's easy to replicate). I'd > > simply test only released snapshots to

Re: [C++ Patch] PR 84644 ("internal compiler error: in warn_misplaced_attr_for_class_type, at cp/decl.c:4718")

Hi, On 13/12/18 22:03, Jason Merrill wrote: On 10/30/18 9:22 PM, Paolo Carlini wrote: Hi, On 30/10/18 21:37, Jason Merrill wrote: On 10/26/18 2:02 PM, Paolo Carlini wrote: On 26/10/18 17:18, Jason Merrill wrote: On Fri, Oct 26, 2018 at 4:52 AM Paolo Carlini wrote: On 24/10/18 22:41, Jason

[PATCH] Fix up AVX512F masked gather vectorization, add support for AVX512F 512-bit masked scatter vectorization (PR tree-optimization/88464)

Hi! In the previous patch I've unfortunately left one important case from the testcase and apparently it wasn't covered by anything else in the testsuite. The 3 functions covered float and double gathers with indexes with the same bitsize and WIDENING gather (double gather with int index), but did

[PATCH] Fix avx512f_sfixupimm* (PR target/88489)

Hi! The avx512f-vfixupimms{s,d}-2.c testcases were miscompiled with -mavx512vl. The problem is that there are separate instructions (e.g. vfixupimmsd vs. vfixupimmpd), each of those have different behavior, the first one is TARGET_AVX512F, the latter TARGET_AVX512VL, but the 128-bit version of the

Re: [nvptx] vector length patch series

On 29-10-18 20:28, Cesar Philippidis wrote: > On 10/5/18 23:22, Tom de Vries wrote: >> On 9/18/18 10:04 PM, Cesar Philippidis wrote: >>> 591973d3c3a [nvptx] use user-defined vectors when possible >> >> If I drop this patch, I get the same test results. Can you find a >> testcase for which this patc

Re: [C++ Patch] [PR c++/88146] do not crash synthesizing inherited ctor(...)

On Dec 6, 2018, Alexandre Oliva wrote: > Regstrapped on x86_64- and i686-linux-gnu, mistakenly along with a patch > with a known regression, and got only that known regression. Retesting > without it. Ok to install? Ping? That round of retesting confirmed no regressions. https://gcc.gnu.org/

Re: [C++ PATCH] [PR c++/87814] undefer deferred noexcept on tsubst if request

On Dec 6, 2018, Alexandre Oliva wrote: > Regstrapped on x86_64- and i686-linux-gnu, mistakenly along with a patch > with a known regression, and got only that known regression. Retesting > without it. Ok to install? Ping? That retesting confirmed no regressions. https://gcc.gnu.org/ml/gcc-pa

Re: [C++ Patch] PR 84644 ("internal compiler error: in warn_misplaced_attr_for_class_type, at cp/decl.c:4718")

On 12/14/18 1:44 PM, Paolo Carlini wrote: Hi, On 13/12/18 22:03, Jason Merrill wrote: On 10/30/18 9:22 PM, Paolo Carlini wrote: Hi, On 30/10/18 21:37, Jason Merrill wrote: On 10/26/18 2:02 PM, Paolo Carlini wrote: On 26/10/18 17:18, Jason Merrill wrote: On Fri, Oct 26, 2018 at 4:52 AM Paolo

Re: [C++ PATCH] [PR c++/87814] undefer deferred noexcept on tsubst if request

On 12/6/18 7:19 PM, Alexandre Oliva wrote: tsubst_expr and tsubst_copy_and_build are not expected to handle DEFERRED_NOEXCEPT exprs, but if tsubst_exception_specification takes a DEFERRED_NOEXCEPT expr with !defer_ok, it just passes the expr on for tsubst_copy_and_build to barf. This patch arran

Re: [C++ Patch] [PR c++/88146] do not crash synthesizing inherited ctor(...)

On 12/6/18 7:23 PM, Alexandre Oliva wrote: This patch started out from the testcase in PR88146, that attempted to synthesize an inherited ctor without any args before a varargs ellipsis and crashed while at that, because of the unguarded dereferencing of the parm type list, that usually contains

Re: [committed 0/4] (Partial) OpenMP 5.0 support for GCC 9

Hi Jakub! On Thu, 8 Nov 2018 18:16:11 +0100, Jakub Jelinek wrote: > The OpenMP 5.0 specification, https://www.openmp.org/specifications/ , > has been just released a few minutes ago and to celebrate that, I've merged > gomp-5_0-branch into trunk after bootstrapping/regtesting it on x86_64-linux

Add user-friendly diagnostics for OpenACC loop parallelism assigned (was: [PATCH 3/3] Add user-friendly OpenACC diagnostics regarding detected parallelism)

Hi! On Thu, 26 Jul 2018 07:14:21 -0700, Cesar Philippidis wrote: > On 07/26/2018 01:33 AM, Richard Biener wrote: > > On Wed, Jul 25, 2018 at 5:30 PM Cesar Philippidis > > wrote: > >> > >> This patch Thanks! > >> teaches GCC to inform the user how it assigned parallelism > >> to each OpenACC l

Re: [committed 0/4] (Partial) OpenMP 5.0 support for GCC 9

On Fri, Dec 14, 2018 at 09:55:51PM +0100, Thomas Schwinge wrote: > Anyway, that was easy enough to fix; in r267145 committed to trunk: > liboffloadmic/ > * runtime/offload.h (omp_target_is_present, omp_target_memcpy) > (omp_target_memcpy_rect, omp_target_associa

Re: [PR88370] acc_get_cuda_stream/acc_set_cuda_stream: acc_async_sync, acc_async_noval

Hi! On Wed, 5 Dec 2018 15:14:16 +0100, I wrote: > On Mon, 19 Nov 2018 16:33:30 +0900, Chung-Lin Tang > wrote: > > On 2018/11/18 10:36 AM, Thomas Schwinge wrote: > > > Generally, I envision test cases running a few "acc_get_cuda_stream" > > > calls with relevant argument values, to see whether th

Re: [PATCH 5/6, OpenACC, libgomp] Async re-work, C/C++ testsuite changes

Hi! On Fri, 7 Dec 2018 16:30:53 +0100, I wrote: > On Tue, 25 Sep 2018 21:11:42 +0800, Chung-Lin Tang > wrote: > > These are the testsuite/libgomp.oacc-c-c++-common/* changes. > > Please commit the following three hunks to trunk: the code as present > doesn't declare its async/wait dependencies

Re: [PATCH, libgcc/ARM & testsuite] Optimize executable size when using softfloat fmul/dmul

Hi Richard, None, is there any? All the one I could find in the big switch selecting tm_files and tmake_files in gcc/config.gcc are including arm/elf.h. I tried to build for arm-wince-pe but got: "Configuration arm-wince-pe not supported". However note that to guarantee correct results the only re

Revise libgomp.oacc-c-c++-common/data-2-lib.c, libgomp.oacc-c-c++-common/data-2.c

Hi! Committed to trunk in r267149: commit 1d61d32a5dda2b567f2253284ce3ecf40c253fab Author: tschwinge Date: Fri Dec 14 20:42:29 2018 + Revise libgomp.oacc-c-c++-common/data-2-lib.c, libgomp.oacc-c-c++-common/data-2.c These are meant to be functionally equivalent (but no longe

Re: [PR88407] [OpenACC] Correctly handle unseen async-arguments

Hi! On Fri, 7 Dec 2018 16:38:58 +0100, I wrote: > So, confused about the intended behavior, I've asked the OpenACC > committee to clarify, and filed "[OpenACC] > Correctly handle unseen async-arguments". > > Assuming this gets clarified in the way I think it should,

Re: [PATCH] Delete powerpcspe

On 12/14/18 11:41 AM, Joseph Myers wrote: > On Fri, 14 Dec 2018, Jeff Law wrote: > >>> I wonder if we could set up auto-(simulator)-testing for all supported >>> archs (and build testing for all supported configs) on the CF >>> (with the required scripting in contrib/ so it's easy to replicate).

Re: [PATCH, ARM] Do softfloat when -mfpu set, -mfloat-abi=softfp and targeting Thumb-1

Hi Richard, Thanks for catching the problem with this approach. Hopefully this version should solve the real problem: FP instructions are only enabled for TARGET_32BIT and TARGET_HARD_FLOAT but GCC only gives an error when TARGET_HARD_FLOAT is true and -mfpu is not set. Among other things, it ma

[PR88484] OpenACC wait directive without wait argument but with async clause

Hi! Committed to trunk in r267151: commit 44b7d2b9c1b1a535212b8312c6dc76dd1570db45 Author: tschwinge Date: Fri Dec 14 20:42:50 2018 + [PR88484] OpenACC wait directive without wait argument but with async clause We don't correctly handle "#pragma acc wait async (a)" for "a >=

[PR88495] An OpenACC async queue is always synchronized with itself

Hi! Committed to trunk in r267152: commit 963e7a8d58a248f8093947e9a5ba56306d36a8e2 Author: tschwinge Date: Fri Dec 14 20:43:02 2018 + [PR88495] An OpenACC async queue is always synchronized with itself An OpenACC async queue is always synchronized with itself, so invocations

Re: [PATCH] Remove duplicated code block in gimple-ssa-split-paths.c

On 12/14/18 2:25 AM, Richard Biener wrote: > > Jeffs last commit added the fix twice. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. > > Richard. > > 2018-12-14 Richard Biener > > * gimple-ssa-split-paths.c (is_feasible_trace): Remove > duplicated code block.

Re: [PATCH 1/4] introduce struct strlen_data_t into gimple-fold

On 12/10/18 2:00 PM, Martin Sebor wrote: > Jeff, is there something you are expecting me to change in > response to this or have you just not gotten around to reviewing > the rest? Your last comment led me to believe you had another iteration on the first patch to do before we moved forward. > >

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior

Hi! On Fri, 25 May 2018 13:01:58 -0700, Cesar Philippidis wrote: > This patch updates GCC's to support OpenACC 2.5's data clause semantics. > In OpenACC 2.5, copy, copyin and copyout all behave like their > present_or_* counterparts in OpenACC 2.0. The patch also adds support > for the new fi

Re: PING^2: [PATCH] i386; Add -mmanual-endbr and cf_check function attribute

On 12/11/18 9:03 AM, H.J. Lu wrote: > On Mon, Dec 3, 2018 at 5:45 AM H.J. Lu wrote: >> On Mon, Jun 18, 2018 at 2:20 AM Richard Biener >> wrote: >>> On Fri, Jun 15, 2018 at 2:59 PM H.J. Lu wrote: Currently GCC inserts ENDBR instruction at entries of all non-static functions, unless LTO

Re: [C++ Patch] PR 84644 ("internal compiler error: in warn_misplaced_attr_for_class_type, at cp/decl.c:4718")

Hi, On 14/12/18 21:19, Jason Merrill wrote: On 12/14/18 1:44 PM, Paolo Carlini wrote: Hi, On 13/12/18 22:03, Jason Merrill wrote: On 10/30/18 9:22 PM, Paolo Carlini wrote: Hi, On 30/10/18 21:37, Jason Merrill wrote: On 10/26/18 2:02 PM, Paolo Carlini wrote: On 26/10/18 17:18, Jason Merril

Re: [PATCH 1/4] introduce struct strlen_data_t into gimple-fold

On 12/14/18 2:23 PM, Jeff Law wrote: On 12/10/18 2:00 PM, Martin Sebor wrote: Jeff, is there something you are expecting me to change in response to this or have you just not gotten around to reviewing the rest? Your last comment led me to believe you had another iteration on the first patch to

Re: [C++ Patch] [PR c++/88146] do not crash synthesizing inherited ctor(...)

On 12/14/18 3:42 PM, Jason Merrill wrote: On 12/6/18 7:23 PM, Alexandre Oliva wrote: This patch started out from the testcase in PR88146, that attempted to synthesize an inherited ctor without any args before a varargs ellipsis and crashed while at that, because of the unguarded dereferencing of

Re: [C++ Patch] PR 84644 ("internal compiler error: in warn_misplaced_attr_for_class_type, at cp/decl.c:4718")

On 12/14/18 4:33 PM, Paolo Carlini wrote: Hi, On 14/12/18 21:19, Jason Merrill wrote: On 12/14/18 1:44 PM, Paolo Carlini wrote: Hi, On 13/12/18 22:03, Jason Merrill wrote: On 10/30/18 9:22 PM, Paolo Carlini wrote: Hi, On 30/10/18 21:37, Jason Merrill wrote: On 10/26/18 2:02 PM, Paolo Carl

Re: PING^2: [PATCH] i386; Add -mmanual-endbr and cf_check function attribute

On Fri, Dec 14, 2018 at 1:28 PM Jeff Law wrote: > > On 12/11/18 9:03 AM, H.J. Lu wrote: > > On Mon, Dec 3, 2018 at 5:45 AM H.J. Lu wrote: > >> On Mon, Jun 18, 2018 at 2:20 AM Richard Biener > >> wrote: > >>> On Fri, Jun 15, 2018 at 2:59 PM H.J. Lu wrote: > Currently GCC inserts ENDBR instr

Re: [C++ PATCH] Sanity check __cxa_* user declarations (PR c++/88482)

On 12/13/18 6:29 PM, Jakub Jelinek wrote: Hi! If the user provides his own __cxa_* prototypes and does so incorrectly (or even worse declares them as variables etc.), we can get various ICEs. The following patch adds some sanity checking, mainly that they are actually functions and with a compa

Re: V5 [PATCH] C/C++: Add -Waddress-of-packed-member

On 12/13/18 6:56 PM, H.J. Lu wrote: On Thu, Dec 13, 2018 at 12:50 PM Jason Merrill wrote: On 9/25/18 11:46 AM, H.J. Lu wrote: On Fri, Aug 31, 2018 at 2:04 PM, Jason Merrill wrote: On 07/23/2018 05:24 PM, H.J. Lu wrote: On Mon, Jun 18, 2018 at 12:26 PM, Joseph Myers wrote: On Mon, 18 Ju

Re: [doc,committed] clarify docs for function attribute "const"

On 12/13/18 7:07 PM, Sandra Loosemore wrote: On 12/13/18 3:52 PM, Martin Sebor wrote: Ping: https://gcc.gnu.org/ml/gcc-patches/2018-12/msg00426.html (I have now committed the @code{const} cleanup mentioned below.) This patch is OK except for one nit.  @cindex pointer arguments  Note that a

Re: [C++ Patch] [PR c++/88146] do not crash synthesizing inherited ctor(...)

On Dec 14, 2018, Jason Merrill wrote: >> If inh is false, we're a copy constructor, which always has a parm, >> so this hunk seems unnecessary. ack >>> -  int cvquals = cp_type_quals (TREE_TYPE (parm)); >>> +  int cvquals = parm ? cp_type_quals (TREE_TYPE (parm)) : 0; >> >> This could

Re: RFC: libiberty PATCH to disable demangling of ancient mangling schemes

On Fri, Dec 7, 2018 at 4:00 PM Jason Merrill wrote: > On 12/7/18 12:48 PM, Tom Tromey wrote: > >> "Pedro" == Pedro Alves writes: > > > > Pedro> I would say that it's very, very unlikely, and not worth it of the > > Pedro> maintenance burden. > > > > Agreed, and especially true for the more un

Re: [PATCH] Improve gimplification of constructors with RANGE_EXPRs (PR c++/82294, PR c++/87436)

On Fri, Dec 14, 2018 at 12:22:28PM +0100, Richard Biener wrote: > > Still need to wait for the FE patch if I want to commit the testcases, those > > depend on both patches. > > I've added size32plus effective target to the larger test, as 384MB is too > > much for 16 or 20 bit address targets. > >

  1   2   >