Hi! On Fri, 7 Dec 2018 16:30:53 +0100, I wrote: > On Tue, 25 Sep 2018 21:11:42 +0800, Chung-Lin Tang <chunglin_t...@mentor.com> > wrote: > > These are the testsuite/libgomp.oacc-c-c++-common/* changes. > > Please commit the following three hunks to trunk: the code as present > doesn't declare its async/wait dependencies correctly.
As I had this queued as a prerequisite for other changes, in r267148 I have now committed the following to trunk: commit fef25f06de8e800d2a6ac04b12b6399923d414a9 Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4> Date: Fri Dec 14 20:42:18 2018 +0000 Correctly describe OpenACC async/wait dependencies libgomp/ * testsuite/libgomp.oacc-c-c++-common/data-2-lib.c: Adjust. * testsuite/libgomp.oacc-c-c++-common/data-2.c: Likewise. * testsuite/libgomp.oacc-c-c++-common/data-3.c: Likewise. Reviewed-by: Thomas Schwinge <tho...@codesourcery.com> git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@267148 138bc75d-0d04-0410-961f-82ee72b054a4 --- libgomp/ChangeLog | 6 ++++++ libgomp/testsuite/libgomp.oacc-c-c++-common/data-2-lib.c | 2 +- libgomp/testsuite/libgomp.oacc-c-c++-common/data-2.c | 2 +- libgomp/testsuite/libgomp.oacc-c-c++-common/data-3.c | 2 +- 4 files changed, 9 insertions(+), 3 deletions(-) diff --git libgomp/ChangeLog libgomp/ChangeLog index b4ab6b690553..b6cbb34908a2 100644 --- libgomp/ChangeLog +++ libgomp/ChangeLog @@ -1,3 +1,9 @@ +2018-12-14 Chung-Lin Tang <clt...@codesourcery.com> + + * testsuite/libgomp.oacc-c-c++-common/data-2-lib.c: Adjust. + * testsuite/libgomp.oacc-c-c++-common/data-2.c: Likewise. + * testsuite/libgomp.oacc-c-c++-common/data-3.c: Likewise. + 2018-12-14 Thomas Schwinge <tho...@codesourcery.com> PR libgomp/88370 diff --git libgomp/testsuite/libgomp.oacc-c-c++-common/data-2-lib.c libgomp/testsuite/libgomp.oacc-c-c++-common/data-2-lib.c index 2ddfa7d4a01b..f553d3d839c5 100644 --- libgomp/testsuite/libgomp.oacc-c-c++-common/data-2-lib.c +++ libgomp/testsuite/libgomp.oacc-c-c++-common/data-2-lib.c @@ -153,7 +153,7 @@ main (int argc, char **argv) d[ii] = ((a[ii] * a[ii] + a[ii]) / a[ii]) - a[ii]; #pragma acc parallel present (a[0:N], b[0:N], c[0:N], d[0:N], e[0:N], N) \ - async (4) + wait (1, 2, 3) async (4) for (int ii = 0; ii < N; ii++) e[ii] = a[ii] + b[ii] + c[ii] + d[ii]; diff --git libgomp/testsuite/libgomp.oacc-c-c++-common/data-2.c libgomp/testsuite/libgomp.oacc-c-c++-common/data-2.c index 0c6abe69dc17..81d623afa0ea 100644 --- libgomp/testsuite/libgomp.oacc-c-c++-common/data-2.c +++ libgomp/testsuite/libgomp.oacc-c-c++-common/data-2.c @@ -162,7 +162,7 @@ main (int argc, char **argv) d[ii] = ((a[ii] * a[ii] + a[ii]) / a[ii]) - a[ii]; #pragma acc parallel present (a[0:N], b[0:N], c[0:N], d[0:N], e[0:N]) \ - wait (1) async (4) + wait (1, 2, 3) async (4) for (int ii = 0; ii < N; ii++) e[ii] = a[ii] + b[ii] + c[ii] + d[ii]; diff --git libgomp/testsuite/libgomp.oacc-c-c++-common/data-3.c libgomp/testsuite/libgomp.oacc-c-c++-common/data-3.c index 0bf706a1b5d4..5ec50b808a73 100644 --- libgomp/testsuite/libgomp.oacc-c-c++-common/data-3.c +++ libgomp/testsuite/libgomp.oacc-c-c++-common/data-3.c @@ -138,7 +138,7 @@ main (int argc, char **argv) d[ii] = ((a[ii] * a[ii] + a[ii]) / a[ii]) - a[ii]; #pragma acc parallel present (a[0:N], b[0:N], c[0:N], d[0:N], e[0:N]) \ - wait (1,5) async (4) + wait (1, 2, 3, 5) async (4) for (int ii = 0; ii < N; ii++) e[ii] = a[ii] + b[ii] + c[ii] + d[ii]; Grüße Thomas