On 29-10-18 20:28, Cesar Philippidis wrote: > On 10/5/18 23:22, Tom de Vries wrote: >> On 9/18/18 10:04 PM, Cesar Philippidis wrote: >>> 591973d3c3a [nvptx] use user-defined vectors when possible >> >> If I drop this patch, I get the same test results. Can you find a >> testcase for which this patch has an effect? > > I just revisited the vector length patch series, and that patch in > specific is bogus and can be safely dropped. >
Hi Thomas, The new vector length patch series contains these patches: ... 0001-libgomp-OpenACC-Adjust-offsets-for-present-data-clau.patch 0002-nvptx-Update-insufficient-launch-message-to-accommod.patch 0003-openacc-Add-target-hook-TARGET_GOACC_ADJUST_PARALLEL.patch 0004-openacc-Make-GFC-default-to-1-for-OpenACC-routine-di.patch 0005-nvptx-update-openacc-dim-macros.patch 0006-nvptx-Rename-worker_bcast-variables-oacc_bcast.patch 0007-nvptx-consolidate-offloaded-function-attributes-into.patch 0008-nvptx-make-nvptx-state-propagation-function-names-mo.patch 0009-nvptx-Fix-whitespace-in-nvptx_single-and-nvptx_neute.patch 0010-nvptx-only-use-one-bar.sync-barriers-in-OpenACC-offl.patch 0011-nvptx-Add-thread-count-parm-to-bar.sync.patch 0012-nvptx-Add-axis_dim.patch 0013-nvptx-Use-TARGET_SET_CURRENT_FUNCTION.patch 0014-nvptx-Use-MAX-MIN-ROUND_UP-macros.patch 0015-nvptx-Generalize-state-propagation-and-synchronizati.patch 0016-nvptx-Add-vector_length-128-testcases.patch 0017-nvptx-Enable-large-vectors.patch 0018-nvptx-Handle-large-vectors-in-libgomp.patch 0019-nvptx-Enable-worker-partitioning-with-warp-sized-vec.patch 0020-nvptx-Simplifly-logic-in-nvptx_single.patch 0021-PR85246-nvptx-Fix-propagation-of-branch-cond-in-vw-n.patch 0022-nvptx-openacc-Don-t-emit-barriers-for-empty-loops.patch 0023-nvptx-Force-vl32-if-calling-vector-partitionable-rou.patch 0024-nvptx-Handle-large-vector-reductions.patch 0025-OpenACC-Enable-firstprivate-OpenACC-reductions.patch ... > 0001-libgomp-OpenACC-Adjust-offsets-for-present-data-clau.patch This patch (well, a variant of it) has been committed (although it's not clear to me why this was included in this patch series). > 0025-OpenACC-Enable-firstprivate-OpenACC-reductions.patch This patch is not required for this patch series. If you remove it, vred2d-128.c and gemm.f90 start to fail, which is trivially fixable by adding firstprivate clauses according to the test-cases. > 0004-openacc-Make-GFC-default-to-1-for-OpenACC-routine-di.patch If I remove this, I run into ICEs in the compiler, but I think that means we need to understand and fix that ICE, instead of concluding that we need this patch. It looks completely unrelated. Thanks, - Tom
