[GUMP@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2012-10-13 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-taglibs-standard has an issue affecting its community integration.

Re: Buidlbot for trunk (was: Re: svn commit: r1397390)

2012-10-13 Thread Konstantin Kolinko
2012/10/12 Mark Thomas : > On 12/10/2012 09:01, Konstantin Kolinko wrote: >> 2012/10/12 Mark Thomas : >>> On 12/10/2012 01:21, ma...@apache.org wrote: Author: markt Date: Fri Oct 12 00:21:23 2012 New Revision: 1397390 URL: http://svn.apache.org/viewvc?rev=1397390&view=rev >

Re: svn commit: r1397291 - in /tomcat/trunk/java/javax/servlet/http: HttpServletRequest.java HttpServletRequestWrapper.java ProtocolHandler.java WebConnection.java

2012-10-13 Thread Konstantin Kolinko
2012/10/12 Mark Thomas : > On 12/10/2012 08:54, Konstantin Kolinko wrote: >> 2012/10/12 : >>> Author: markt >>> Date: Thu Oct 11 20:29:01 2012 >>> New Revision: 1397291 >>> >>> URL: http://svn.apache.org/viewvc?rev=1397291&view=rev >>> Log: >>> Fill in some of the HTTP upgrade Javadoc >>> >>> Modi

Re: svn commit: r1397476 - in /tomcat/tc7.0.x/trunk: ./ java/javax/servlet/http/HttpServlet.java java/javax/servlet/http/HttpServletRequest.java

2012-10-13 Thread Konstantin Kolinko
2012/10/12 : > Author: markt > Date: Fri Oct 12 08:56:58 2012 > New Revision: 1397476 > > URL: http://svn.apache.org/viewvc?rev=1397476&view=rev > Log: > Fix a long standing TODO so correct exceptions are thrown. > Clean-up Javadoc. > > Modified: > tomcat/tc7.0.x/trunk/ (props changed) >

svn commit: r1397839 - /tomcat/trunk/java/javax/servlet/http/HttpServlet.java

2012-10-13 Thread markt
Author: markt Date: Sat Oct 13 14:30:39 2012 New Revision: 1397839 URL: http://svn.apache.org/viewvc?rev=1397839&view=rev Log: Fix my errors. Reviewed by kkolinko Modified: tomcat/trunk/java/javax/servlet/http/HttpServlet.java Modified: tomcat/trunk/java/javax/servlet/http/HttpServlet.java U

svn commit: r1397840 - in /tomcat/tc7.0.x/trunk: ./ java/javax/servlet/http/HttpServlet.java

2012-10-13 Thread markt
Author: markt Date: Sat Oct 13 14:31:58 2012 New Revision: 1397840 URL: http://svn.apache.org/viewvc?rev=1397840&view=rev Log: Fix my errors. Reviewed by kkolinko Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/javax/servlet/http/HttpServlet.java Propchange: t

Re: Buidlbot for trunk (was: Re: svn commit: r1397390)

2012-10-13 Thread Mark Thomas
On 13/10/2012 12:45, Konstantin Kolinko wrote: > http://ci.apache.org/projects/tomcat/tomcat8/logs/1397390/TEST-org.apache.catalina.util.TestServerInfo.NIO.txt > > Architecture: amd64 > JVM Version:1.7.0_07-b10 > JVM Vendor: Oracle Corporation > > JDK 7u7. Nothing exotic there... > >

svn commit: r1397861 - /tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java

2012-10-13 Thread markt
Author: markt Date: Sat Oct 13 15:37:25 2012 New Revision: 1397861 URL: http://svn.apache.org/viewvc?rev=1397861&view=rev Log: A clean close by the server appears to result in a reset being seen by the client on Linux for this test case. A similar error is not seen on Windows (or when the test i

svn commit: r1397862 - /tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java

2012-10-13 Thread markt
Author: markt Date: Sat Oct 13 15:39:38 2012 New Revision: 1397862 URL: http://svn.apache.org/viewvc?rev=1397862&view=rev Log: Grr. Remove local env changes for testing Modified: tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java Modified: tomcat/trunk/test/org/apache/tomcat/util/net/

svn commit: r1397868 - /tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java

2012-10-13 Thread markt
Author: markt Date: Sat Oct 13 15:56:21 2012 New Revision: 1397868 URL: http://svn.apache.org/viewvc?rev=1397868&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53993 Avoid NPE when the session is invalidated Modified: tomcat/trunk/java/org/apache/catalina/valves/AccessLo

svn commit: r1397870 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/valves/AccessLogValve.java webapps/docs/changelog.xml

2012-10-13 Thread markt
Author: markt Date: Sat Oct 13 16:00:11 2012 New Revision: 1397870 URL: http://svn.apache.org/viewvc?rev=1397870&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53993 Avoid NPE when the session is invalidated Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc

[Bug 53993] NPE in AccessLogValve

2012-10-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53993 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1397873 - in /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool: DataSourceProxy.java JdbcInterceptor.java PooledConnection.java

2012-10-13 Thread markt
Author: markt Date: Sat Oct 13 16:04:33 2012 New Revision: 1397873 URL: http://svn.apache.org/viewvc?rev=1397873&view=rev Log: Fix some Eclipse / Javadoc warnings Modified: tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java tomcat/trunk/modules

buildbot success in ASF Buildbot on tomcat-trunk

2012-10-13 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/3462 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

Re: Time for Taglibs to be sent to the archive?

2012-10-13 Thread Henri Yandell
Hard to argue against it. I've no energy for Taglibs coding. I wish we'd got a JSTL 1.2 released, but c'est la vie. All the steps listed sound good except removing the website. Historically on the Attic side we've kept the websites up with a notice that the project is dead, rather than going dark

svn commit: r1397944 - in /tomcat/trunk/java: javax/servlet/http/HttpServletResponse.java javax/servlet/http/HttpServletResponseWrapper.java javax/servlet/http/HttpSession.java org/apache/catalina/con

2012-10-13 Thread markt
Author: markt Date: Sat Oct 13 20:45:40 2012 New Revision: 1397944 URL: http://svn.apache.org/viewvc?rev=1397944&view=rev Log: Fill in some Servlet 3.0 Javadoc Modified: tomcat/trunk/java/javax/servlet/http/HttpServletResponse.java tomcat/trunk/java/javax/servlet/http/HttpServletResponseW

svn commit: r1397945 - in /tomcat/tc7.0.x/trunk: ./ java/javax/servlet/http/HttpServletResponse.java java/javax/servlet/http/HttpServletResponseWrapper.java java/javax/servlet/http/HttpSession.java ja

2012-10-13 Thread markt
Author: markt Date: Sat Oct 13 20:46:26 2012 New Revision: 1397945 URL: http://svn.apache.org/viewvc?rev=1397945&view=rev Log: Fill in some Servlet 3.0 Javadoc Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/javax/servlet/http/HttpServletResponse.java tomca

buildbot failure in ASF Buildbot on tomcat-trunk

2012-10-13 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/3464 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

svn commit: r1397953 - /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/

2012-10-13 Thread markt
Author: markt Date: Sat Oct 13 21:43:36 2012 New Revision: 1397953 URL: http://svn.apache.org/viewvc?rev=1397953&view=rev Log: Run the UCDetector and remove unused code Some follow-up remains. Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Annotations.java tomcat/trunk/

svn commit: r1397957 - /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/

2012-10-13 Thread markt
Author: markt Date: Sat Oct 13 21:54:57 2012 New Revision: 1397957 URL: http://svn.apache.org/viewvc?rev=1397957&view=rev Log: Remove unused code identified by Eclipse Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/CodeException.java tomcat/trunk/java/org/apache/tomcat/

svn commit: r1397962 - in /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile: CodeException.java ConstantInvokeDynamic.java ConstantMethodHandle.java ConstantMethodType.java

2012-10-13 Thread markt
Author: markt Date: Sat Oct 13 22:16:58 2012 New Revision: 1397962 URL: http://svn.apache.org/viewvc?rev=1397962&view=rev Log: Start to add comments identifying what is being read but not used (to aid debugging / future extension) Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/class

svn commit: r1397964 - in /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile: InnerClass.java LineNumber.java LocalVariable.java PMGClass.java Signature.java SourceFile.java StackMapEntry.java S

2012-10-13 Thread markt
Author: markt Date: Sat Oct 13 22:23:42 2012 New Revision: 1397964 URL: http://svn.apache.org/viewvc?rev=1397964&view=rev Log: Complete adding comments identifying what is being read but not used (to aid debugging / future extension) Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/cl

Re: svn commit: r1397953 - /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/

2012-10-13 Thread Mark Thomas
On 13/10/2012 22:43, ma...@apache.org wrote: > Author: markt > Date: Sat Oct 13 21:43:36 2012 > New Revision: 1397953 > > URL: http://svn.apache.org/viewvc?rev=1397953&view=rev > Log: > Run the UCDetector and remove unused code > Some follow-up remains. Drat. This clean-up was too aggressive. I n

Re: svn commit: r1397953 - /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/

2012-10-13 Thread Konstantin Kolinko
2012/10/14 Mark Thomas : > On 13/10/2012 22:43, ma...@apache.org wrote: >> Author: markt >> Date: Sat Oct 13 21:43:36 2012 >> New Revision: 1397953 >> >> URL: http://svn.apache.org/viewvc?rev=1397953&view=rev >> Log: >> Run the UCDetector and remove unused code >> Some follow-up remains. > > Drat.

Re: svn commit: r1397953 - /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/

2012-10-13 Thread Mark Thomas
On 14/10/2012 00:05, Konstantin Kolinko wrote: > 2012/10/14 Mark Thomas : >> On 13/10/2012 22:43, ma...@apache.org wrote: >>> Author: markt >>> Date: Sat Oct 13 21:43:36 2012 >>> New Revision: 1397953 >>> >>> URL: http://svn.apache.org/viewvc?rev=1397953&view=rev >>> Log: >>> Run the UCDetector and

Re: svn commit: r1397953 - /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/

2012-10-13 Thread Konstantin Kolinko
2012/10/14 Mark Thomas : > On 14/10/2012 00:05, Konstantin Kolinko wrote: >> 2012/10/14 Mark Thomas : >>> On 13/10/2012 22:43, ma...@apache.org wrote: Author: markt Date: Sat Oct 13 21:43:36 2012 New Revision: 1397953 URL: http://svn.apache.org/viewvc?rev=1397953&view=rev >

svn commit: r1397969 - /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ClassParser.java

2012-10-13 Thread markt
Author: markt Date: Sat Oct 13 23:38:00 2012 New Revision: 1397969 URL: http://svn.apache.org/viewvc?rev=1397969&view=rev Log: A couple more identifying comments Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ClassParser.java Modified: tomcat/trunk/java/org/apache/tomcat/

svn commit: r1397971 - /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Code.java

2012-10-13 Thread markt
Author: markt Date: Sun Oct 14 00:13:57 2012 New Revision: 1397971 URL: http://svn.apache.org/viewvc?rev=1397971&view=rev Log: Restore incorrectly removed reads when parsing Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Code.java Modified: tomcat/trunk/java/org/apache/tom

svn commit: r1397972 - in /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile: StackMapEntry.java StackMapTableEntry.java

2012-10-13 Thread markt
Author: markt Date: Sun Oct 14 00:16:10 2012 New Revision: 1397972 URL: http://svn.apache.org/viewvc?rev=1397972&view=rev Log: Restore incorrectly removed reads when parsing Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/StackMapEntry.java tomcat/trunk/java/org/apache/

svn commit: r1397973 - in /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile: ConstantInvokeDynamic.java ConstantMethodHandle.java ConstantMethodType.java ConstantValue.java PMGClass.java Signat

2012-10-13 Thread markt
Author: markt Date: Sun Oct 14 00:18:29 2012 New Revision: 1397973 URL: http://svn.apache.org/viewvc?rev=1397973&view=rev Log: Use a single constructor Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantInvokeDynamic.java tomcat/trunk/java/org/apache/tomcat/util/b

Re: svn commit: r1397953 - /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/

2012-10-13 Thread Mark Thomas
On 13/10/2012 23:57, Mark Thomas wrote: > On 13/10/2012 22:43, ma...@apache.org wrote: >> Author: markt >> Date: Sat Oct 13 21:43:36 2012 >> New Revision: 1397953 >> >> URL: http://svn.apache.org/viewvc?rev=1397953&view=rev >> Log: >> Run the UCDetector and remove unused code >> Some follow-up rema

svn commit: r1397974 - in /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile: RuntimeInvisibleAnnotations.java RuntimeInvisibleParameterAnnotations.java RuntimeVisibleAnnotations.java

2012-10-13 Thread markt
Author: markt Date: Sun Oct 14 00:19:56 2012 New Revision: 1397974 URL: http://svn.apache.org/viewvc?rev=1397974&view=rev Log: Line length Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/RuntimeInvisibleAnnotations.java tomcat/trunk/java/org/apache/tomcat/util/bcel/cla

svn commit: r1397976 - /tomcat/trunk/java/org/apache/tomcat/util/bcel/Constants.java

2012-10-13 Thread markt
Author: markt Date: Sun Oct 14 00:22:37 2012 New Revision: 1397976 URL: http://svn.apache.org/viewvc?rev=1397976&view=rev Log: Update constants Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/Constants.java Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/Constants.java URL:

svn commit: r1397977 - /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/StackMapType.java

2012-10-13 Thread markt
Author: markt Date: Sun Oct 14 00:23:04 2012 New Revision: 1397977 URL: http://svn.apache.org/viewvc?rev=1397977&view=rev Log: Remove more unused code Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/StackMapType.java Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/

svn commit: r1397978 - /tomcat/trunk/java/org/apache/tomcat/util/bcel/Constants.java

2012-10-13 Thread markt
Author: markt Date: Sun Oct 14 00:26:02 2012 New Revision: 1397978 URL: http://svn.apache.org/viewvc?rev=1397978&view=rev Log: UCDetector Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/Constants.java Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/Constants.java URL: http:/

buildbot failure in ASF Buildbot on tomcat-trunk

2012-10-13 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/3469 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

svn commit: r1397979 - /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Constant.java

2012-10-13 Thread markt
Author: markt Date: Sun Oct 14 00:42:00 2012 New Revision: 1397979 URL: http://svn.apache.org/viewvc?rev=1397979&view=rev Log: Prevent a stack overflow when generating an error message if parsing fails and provide some useful information in error message. Modified: tomcat/trunk/java/org/apac

svn commit: r1397980 - /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/StackMapEntry.java

2012-10-13 Thread markt
Author: markt Date: Sun Oct 14 00:46:14 2012 New Revision: 1397980 URL: http://svn.apache.org/viewvc?rev=1397980&view=rev Log: Fix unused parameter warning Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/StackMapEntry.java Modified: tomcat/trunk/java/org/apache/tomcat/util

svn commit: r1397982 - /tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java

2012-10-13 Thread markt
Author: markt Date: Sun Oct 14 00:48:11 2012 New Revision: 1397982 URL: http://svn.apache.org/viewvc?rev=1397982&view=rev Log: Comment out debug code Modified: tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java Modified: tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java URL:

svn commit: r1397985 - in /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile: ClassParser.java Field.java FieldOrMethod.java Method.java

2012-10-13 Thread markt
Author: markt Date: Sun Oct 14 00:53:23 2012 New Revision: 1397985 URL: http://svn.apache.org/viewvc?rev=1397985&view=rev Log: Only need FieldOrMethod, not individual classes Removed: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Field.java tomcat/trunk/java/org/apache/tomcat/ut

buildbot success in ASF Buildbot on tomcat-trunk

2012-10-13 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/3470 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1397988 - /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/

2012-10-13 Thread markt
Author: markt Date: Sun Oct 14 01:00:48 2012 New Revision: 1397988 URL: http://svn.apache.org/viewvc?rev=1397988&view=rev Log: Remove unused copy() method Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/AnnotationDefault.java tomcat/trunk/java/org/apache/tomcat/util/bce