classfile: InnerClass.java LineNumber.java LocalVariable.java PMGClass.java Signature.java SourceFile.java StackMapEntry.java StackMapTableEntry.java

markt Sat, 13 Oct 2012 15:24:29 -0700

Author: markt
Date: Sat Oct 13 22:23:42 2012
New Revision: 1397964

URL: http://svn.apache.org/viewvc?rev=1397964&view=rev
Log:
Complete adding comments identifying what is being read but not used (to aid 
debugging / future extension)


Modified:
    tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/InnerClass.java
    tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LineNumber.java
    tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LocalVariable.java
    tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/PMGClass.java
    tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Signature.java
    tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/SourceFile.java
    tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/StackMapEntry.java
    
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/StackMapTableEntry.java

Modified: 
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/InnerClass.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/InnerClass.java?rev=1397964&r1=1397963&r2=1397964&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/InnerClass.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/InnerClass.java Sat 
Oct 13 22:23:42 2012
@@ -40,10 +40,10 @@ public final class InnerClass implements
      * @throws IOException
      */
     InnerClass(DataInput file) throws IOException {
-        file.readUnsignedShort();
-        file.readUnsignedShort();
-        file.readUnsignedShort();
-        file.readUnsignedShort();
+        file.readUnsignedShort();   // Unused inner_class_index
+        file.readUnsignedShort();   // Unused outer_class_index
+        file.readUnsignedShort();   // Unused inner_name_index
+        file.readUnsignedShort();   // Unused inner_access_flags
     }
 
 

Modified: 
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LineNumber.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LineNumber.java?rev=1397964&r1=1397963&r2=1397964&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LineNumber.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LineNumber.java Sat 
Oct 13 22:23:42 2012
@@ -41,8 +41,8 @@ public final class LineNumber implements
      * @throws IOException
      */
     LineNumber(DataInput file) throws IOException {
-        file.readUnsignedShort();
-        file.readUnsignedShort();
+        file.readUnsignedShort();   // Unused start_pc
+        file.readUnsignedShort();   // Unused line_number
     }
 
 

Modified: 
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LocalVariable.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LocalVariable.java?rev=1397964&r1=1397963&r2=1397964&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LocalVariable.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LocalVariable.java 
Sat Oct 13 22:23:42 2012
@@ -42,11 +42,11 @@ public final class LocalVariable impleme
      * @throws IOException
      */
     LocalVariable(DataInput file) throws IOException {
-        file.readUnsignedShort();
-        file.readUnsignedShort();
-        file.readUnsignedShort();
-        file.readUnsignedShort();
-        file.readUnsignedShort();
+        file.readUnsignedShort();   // Unused start_pc
+        file.readUnsignedShort();   // Unused length
+        file.readUnsignedShort();   // Unused name_index
+        file.readUnsignedShort();   // Unused signature_index
+        file.readUnsignedShort();   // Unused index
     }
 
 

Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/PMGClass.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/PMGClass.java?rev=1397964&r1=1397963&r2=1397964&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/PMGClass.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/PMGClass.java Sat 
Oct 13 22:23:42 2012
@@ -44,8 +44,8 @@ public final class PMGClass extends Attr
     PMGClass(int name_index, int length, DataInput file, ConstantPool 
constant_pool)
             throws IOException {
         this(name_index, length, constant_pool);
-        file.readUnsignedShort();
-        file.readUnsignedShort();
+        file.readUnsignedShort();   // Unused pmg_index
+        file.readUnsignedShort();   // Unused pmg_class_index
     }
 
 

Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Signature.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Signature.java?rev=1397964&r1=1397963&r2=1397964&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Signature.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Signature.java Sat 
Oct 13 22:23:42 2012
@@ -44,7 +44,7 @@ public final class Signature extends Att
     Signature(int name_index, int length, DataInput file, ConstantPool 
constant_pool)
             throws IOException {
         this(name_index, length, constant_pool);
-        file.readUnsignedShort();
+        file.readUnsignedShort();   // Unused signature_index
     }
 
 

Modified: 
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/SourceFile.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/SourceFile.java?rev=1397964&r1=1397963&r2=1397964&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/SourceFile.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/SourceFile.java Sat 
Oct 13 22:23:42 2012
@@ -46,7 +46,7 @@ public final class SourceFile extends At
     SourceFile(int name_index, int length, DataInput file, ConstantPool 
constant_pool)
             throws IOException {
         this(name_index, length, constant_pool);
-        file.readUnsignedShort();
+        file.readUnsignedShort();   // Unused sourcefile_index
     }
 
 

Modified: 
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/StackMapEntry.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/StackMapEntry.java?rev=1397964&r1=1397963&r2=1397964&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/StackMapEntry.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/StackMapEntry.java 
Sat Oct 13 22:23:42 2012
@@ -36,8 +36,8 @@ public final class StackMapEntry impleme
     private static final long serialVersionUID = 1L;
 
     StackMapEntry(DataInputStream file) throws IOException {
-        file.readShort();
-        file.readShort();
+        file.readShort();   // Unused byte_code_offset
+        file.readShort();   // Unused number_of_locals
     }
 
 

Modified: 
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/StackMapTableEntry.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/StackMapTableEntry.java?rev=1397964&r1=1397963&r2=1397964&view=diff
==============================================================================
--- 
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/StackMapTableEntry.java 
(original)
+++ 
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/StackMapTableEntry.java 
Sat Oct 13 22:23:42 2012
@@ -42,7 +42,7 @@ public final class StackMapTableEntry im
      * @throws IOException
      */
     StackMapTableEntry(DataInputStream file) throws IOException {
-        file.read();
+        file.read();    // Unused frame_type
     }
 
 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1397964 - in /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile: InnerClass.java LineNumber.java LocalVariable.java PMGClass.java Signature.java SourceFile.java StackMapEntry.java StackMapTableEntry.java

Reply via email to