2012/10/12 Mark Thomas <ma...@apache.org>: > On 12/10/2012 08:54, Konstantin Kolinko wrote: >> 2012/10/12 <ma...@apache.org>: >>> Author: markt >>> Date: Thu Oct 11 20:29:01 2012 >>> New Revision: 1397291 >>> >>> URL: http://svn.apache.org/viewvc?rev=1397291&view=rev >>> Log: >>> Fill in some of the HTTP upgrade Javadoc >>> >>> Modified: >>> tomcat/trunk/java/javax/servlet/http/HttpServletRequest.java >>> tomcat/trunk/java/javax/servlet/http/HttpServletRequestWrapper.java >>> tomcat/trunk/java/javax/servlet/http/ProtocolHandler.java >>> tomcat/trunk/java/javax/servlet/http/WebConnection.java >>> >> >>> >>> /** >>> - * TODO SERVLET 3.1 >>> + * Start the HTTP upgrade process and pass the connection to the >>> provided >>> + * protocol handler once the current request/response pair has >>> completed >>> + * processing. >>> */ >>> - public abstract void upgrade(javax.servlet.http.ProtocolHandler >>> handler) >>> - throws java.io.IOException; >>> + public void upgrade(ProtocolHandler handler) throws >>> java.io.IOException; >> >> It would be better to mark such new API as "@since Servlet 3.1" > > Agreed. I've done this and cleaned up / filled-in the Servlet 3.0 and > Servlet 3.1 Javadoc for those classes. There is a fair amount of > clean-up required in the Javadoc. I'm aiming to fix these as I touch the > classes / have a spare 5 minutes to fill. >
Looks good. Thank you. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
