Author: markt
Date: Sat Oct 13 22:16:58 2012
New Revision: 1397962
URL: http://svn.apache.org/viewvc?rev=1397962&view=rev
Log:
Start to add comments identifying what is being read but not used (to aid
debugging / future extension)
Modified:
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/CodeException.java
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantInvokeDynamic.java
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantMethodHandle.java
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantMethodType.java
Modified:
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/CodeException.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/CodeException.java?rev=1397962&r1=1397961&r2=1397962&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/CodeException.java
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/CodeException.java
Sat Oct 13 22:16:58 2012
@@ -43,10 +43,10 @@ public final class CodeException impleme
* @throws IOException
*/
CodeException(DataInput file) throws IOException {
- file.readUnsignedShort();
- file.readUnsignedShort();
- file.readUnsignedShort();
- file.readUnsignedShort();
+ file.readUnsignedShort(); // Unused start_pc
+ file.readUnsignedShort(); // Unused end_pc
+ file.readUnsignedShort(); // Unused handler_pc
+ file.readUnsignedShort(); // Unused catch_type
}
Modified:
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantInvokeDynamic.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantInvokeDynamic.java?rev=1397962&r1=1397961&r2=1397962&view=diff
==============================================================================
---
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantInvokeDynamic.java
(original)
+++
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantInvokeDynamic.java
Sat Oct 13 22:16:58 2012
@@ -42,8 +42,8 @@ public final class ConstantInvokeDynamic
*/
ConstantInvokeDynamic(DataInput file) throws IOException {
this();
- file.readUnsignedShort();
- file.readUnsignedShort();
+ file.readUnsignedShort(); // Unused bootstrap_method_attr_index
+ file.readUnsignedShort(); // Unused name_and_type_index
}
Modified:
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantMethodHandle.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantMethodHandle.java?rev=1397962&r1=1397961&r2=1397962&view=diff
==============================================================================
---
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantMethodHandle.java
(original)
+++
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantMethodHandle.java
Sat Oct 13 22:16:58 2012
@@ -42,8 +42,8 @@ public final class ConstantMethodHandle
*/
ConstantMethodHandle(DataInput file) throws IOException {
this();
- file.readUnsignedByte();
- file.readUnsignedShort();
+ file.readUnsignedByte(); // Unused reference_kind
+ file.readUnsignedShort(); // Unused reference_index
}
Modified:
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantMethodType.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantMethodType.java?rev=1397962&r1=1397961&r2=1397962&view=diff
==============================================================================
---
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantMethodType.java
(original)
+++
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantMethodType.java
Sat Oct 13 22:16:58 2012
@@ -42,7 +42,7 @@ public final class ConstantMethodType ex
*/
ConstantMethodType(DataInput file) throws IOException {
this();
- file.readUnsignedShort();
+ file.readUnsignedShort(); // Unused descriptor_index
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
