[PATCH] D50168: [Builtins] Implement __builtin_clrsb to be compatible with gcc

bkramer added a comment. Test case? Comment at: lib/CodeGen/CGBuiltin.cpp:1563 +Value *Result = Builder.CreateCall(F, {Tmp, Builder.getTrue()}); +if (Result->getType() != ResultType) + Result = Builder.CreateIntCast(Result, ResultType, /*isSigned*/true, ---

[PATCH] D50168: [Builtins] Implement __builtin_clrsb to be compatible with gcc

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D50168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D46942: Add vfs::FileSystem::getRealPath

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good. Please watch the windows buildbots carefully after landing this. Comment at: lib/Basic/FileManager.cpp:537 -#ifdef LLVM_ON_UNIX - char CanonicalNameBuf[PATH_

[PATCH] D47060: [VFS] Implement getRealPath for OverlayFileSystem.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Basic/VirtualFileSystem.cpp:387 + SmallVectorImpl &Output) const { + // Not using overlays_begin/end because this method i

[PATCH] D47074: [Tooling] Add an overload of runToolOnCodeWithArgs that takes VFS

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D47074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D47262: [VFS] Implement getRealPath in InMemoryFileSystem.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D47262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D38228: Fix clangd when built with LLVM_LINK_LLVM_DYLIB=ON

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D38228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D38225: [clangd] Fix missing "message" key when responding with unsupported method

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks good. Do you have commit access? https://reviews.llvm.org/D38225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D38678: [Sema] Warn about unused variables if we can constant evaluate the initializer.

bkramer created this revision. If the variable construction can be constant evaluated it doesn't have side effects, so removing it is always safe. We only try to evaluate variables that are unused, there should be no impact on compile time. https://reviews.llvm.org/D38678 Files: lib/Sema/Sema

[PATCH] D37970: [clangd] Added a command-line arg to mirror clangd input into a file.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks useful, thanks! https://reviews.llvm.org/D37970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D38617: Set PreprocessorOpts.GeneratePreamble=true in PrecompiledPreamble.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. A testcase would be nice, but this can go in to unblock things. https://reviews.llvm.org/D38617 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D51729: [Tooling] JSONCompilationDatabasePlugin infers compile commands for missing files

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I like it Repository: rC Clang https://reviews.llvm.org/D51729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D51921: [VFS] vfs::directory_iterator yields path and file type instead of full Status

bkramer added inline comments. Comment at: include/clang/Basic/VirtualFileSystem.h:135 + // For compatibility with old Status-based API. Prefer using Path directly. + StringRef getName() const { return Path; } +}; sammccall wrote: > Backwards-compatibility note

[PATCH] D51921: [VFS] vfs::directory_iterator yields path and file type instead of full Status

bkramer added inline comments. Comment at: include/clang/Basic/VirtualFileSystem.h:135 + // For compatibility with old Status-based API. Prefer using Path directly. + StringRef getName() const { return Path; } +}; sammccall wrote: > sammccall wrote: > > bkramer

[PATCH] D51921: [VFS] vfs::directory_iterator yields path and file type instead of full Status

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D51921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D49274: [CUDA] Provide integer SIMD functions for CUDA-9.2

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D49274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D48873: [AST] Use llvm::TrailingObjects in CXXTryStmt

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D48873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D50156: [test] Fix %hmaptool path for standalone builds

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg, thanks Repository: rC Clang https://reviews.llvm.org/D50156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D43371: [clang-include-fixer] Use add_clang_tool instead of add_clang_executable

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D43567: [ASTMatchers] isTemplateInstantiation: also match explicit instantiation declaration.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D43567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good. Make sure to watch the windows buildbots after submitting. https://reviews.llvm.org/D33416 ___ cfe-commits mailing list cfe-commits

[PATCH] D33678: [clangd] Mark results of clangd requests with a tag provided by the FileSystemProvider.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D33678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D33930: Do not pick up by default the LLVM style if passing -format

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good, but I'm wondering if we should also change the default in clang-apply-replacements itself. https://reviews.llvm.org/D33930 ___ cfe

[PATCH] D41487: [clang-format] Adds a FormatStyleSet

bkramer added inline comments. Comment at: include/clang/Format/Format.h:1700 +typedef std::map> +MapType; Why unique_ptr? Comment at: include/clang/Format/Format.h:1706 +// FormatStyleSet. +void Add(FormatStyle Style); +

[PATCH] D41487: [clang-format] Adds a FormatStyleSet

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D41487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

bkramer added a comment. I'd like to, but I don't know when I find time to rebase this thing after more than a year of waiting for review. https://reviews.llvm.org/D23130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D47864: [python] Fix most Python binding unittests on Windows

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I don't know much about the python bindings, but this is probably fine. Repository: rC Clang https://reviews.llvm.org/D47864 ___ cfe-commits

[PATCH] D56665: [AST] Fix double-traversal of code in top-level lambdas in RAV(implicit = yes).

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This makes sense to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56665/new/ https://reviews.llvm.org/D56665 _

[PATCH] D57150: [HeaderSearch] don't immediately request that headers are opened in getFileAndSuggestModule().

bkramer accepted this revision. bkramer added inline comments. Comment at: lib/Lex/HeaderSearch.cpp:313 // check whether we'll have a suggestion for a module. - const FileEntry *File = getFileMgr().getFile(FileName, /*OpenFile=*/true); + const FileEntry *File = getFileMgr().

[PATCH] D57442: [OpenGL] Fix test on PPC after r352540

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57442/new/ https://reviews.llvm.org/D57442 ___ cfe-commits ma

[PATCH] D55415: Revert removal of tidy plugin support from libclang

bkramer added a comment. I'd be interested in hearing how this is used. I added this feature as an experiment a while back but it simply didn't work as I envisioned it to. Some checks do work but the overall latency makes it unusable in an IDE setting. People repeatedly asked me to remove it be

[PATCH] D55484: ComputeLineNumbers: delete SSE2 vectorization

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. The performance difference on preprocessing huge files was tiny back then, doesn't surprise me that it disappeared. What did you test this on? Dropping it is fine with me. Repository: rC

[PATCH] D55415: Revert removal of tidy plugin support from libclang

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I think that's a fair point for bringing it back for now. It's not supported though and we will get rid of it eventually. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55415/new/ h

[PATCH] D59387: Make getFullyQualifiedName qualify both the pointee and class type for member ptr types

bkramer created this revision. bkramer added reviewers: saugustine, ilya-biryukov. Herald added a subscriber: jlebar. Herald added a project: clang. We already handle pointers and references, member ptrs are just another special case. Fixes PR40732. Repository: rG LLVM Github Monorepo https:/

[PATCH] D59750: Rename directory housing clang-include-fixer to be eponymous

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg. Is the reference from libclang still around? Might need an update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59750/new/ https://reviews.llvm.org/D59750 __

[PATCH] D60201: Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60201/new/ https://reviews.llvm.org/D60201 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D52264: Deduplicate replacements from diagnostics.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D37382: Fixed a crash in code completion.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D37382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D37564: Update users of llvm::sys::ExecuteAndWait etc.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm too https://reviews.llvm.org/D37564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D45603: Fix evaluation of `__has_include_next` during -frewrite-includes.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D45603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D46148: [CUDA] Added -f[no-]cuda-short-ptr option

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D46148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D48845: [Sema] Add fixit for unused lambda captures

bkramer added inline comments. Comment at: test/FixIt/fixit-unused-lambda-capture.cpp:31 + // CHECK: [=,&i] { return i; }; +} This needs tests for: * capture initializers `[c = foo()] {};` * Capturing this `[this] {};` * Capturing *this `[*this] {};` * VLA capt

[PATCH] D49484: [CodeComplete] Allow getDeclaration on RK_Pattern result.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D49484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D49302: [AST] Various micro-optimizations in CXXInheritance

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. cool Repository: rC Clang https://reviews.llvm.org/D49302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D49274: [CUDA] Provide integer SIMD functions for CUDA-9.2

bkramer accepted this revision. bkramer added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:1080 + unsigned int r; + asm("vabsdiff2.u32.u32.u32.sat %0,%1,%2,0;" : "=r"(r) : "r"(__a), "r"(__b)); +

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Nice, those relocations have annoyed me for years. I'm worried about whether the way you're accessing StaticDiagInfoDescriptionStringTable might be undefined behavior. I won't block this cha

[PATCH] D77420: Also look for devtoolset-9 gcc toolchain

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77420/new/ https://reviews.llvm.org/D77420 ___

[PATCH] D77420: Also look for devtoolset-9 gcc toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b9c6c16c33d: Also look for devtoolset-9 gcc toolchain (authored by stephan.dollberg, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77

[PATCH] D78213: [libclang]: visit BindingDecl in DecompositionDecl

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78213/new/ https://reviews.llvm.org/D78213 ___

[PATCH] D78214: [libclang]: visit C++17 if init statements

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78214/new/ https://reviews.llvm.org/D78214 ___

[PATCH] D78213: [libclang]: visit BindingDecl in DecompositionDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG4597e3bd475b: [libclang]: visit BindingDecl in DecompositionDecl (authored by milianw, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D78214: [libclang]: visit C++17 if init statements

This revision was automatically updated to reflect the committed changes. Closed by commit rG08e181264318: [libclang]: visit C++17 if init statements (authored by milianw, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78214/new

[PATCH] D40302: Avoid copying the data of in-memory preambles

bkramer added inline comments. Comment at: include/clang/Frontend/PrecompiledPreamble.h:101 /// is accessible. + /// For in-memory preambles, PrecompiledPreamble instance continues to owns + /// the MemoryBuffer with the Preamble after this method returns. The caller ---

[PATCH] D40302: Avoid copying the data of in-memory preambles

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D40302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D40435: [clang-format] Deduplicate using declarations

bkramer added inline comments. Comment at: lib/Format/UsingDeclarationsSorter.cpp:115 +bool usingDeclarationsEqual(const UsingDeclaration &a, +const UsingDeclaration &b) { I'd use a lambda instead. https://reviews.llvm.org/D40435

[PATCH] D40435: [clang-format] Deduplicate using declarations

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D40435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D40439: [Tooling] Remove file/command enumeration from CompilationDatabase.

bkramer added a comment. There are a few users of the C++ API out there, do we have migration path for them? https://reviews.llvm.org/D40439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D40485: [clangd] Introduced a Context that stores implicit data

bkramer requested changes to this revision. bkramer added inline comments. This revision now requires changes to proceed. Comment at: clangd/Context.h:79 +/// Otherwise returns an empty Context. +Context &globalCtx(); + This is a giant code smell. If we want the

[PATCH] D40643: [libclang] Add function to get the buffer for a file

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D40643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D40561: [libclang] Fix cursors for functions with trailing return type

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D40561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D132920: [clang] Silence a false positive GCC -Wunused-but-set-parameter warning with constexpr

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132920/new/ https://reviews.llvm.org/D132920 ___

[PATCH] D122173: [libc++][ranges] Implement ranges::transform

bkramer added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/ranges_transform.module.verify.cpp:1-15 +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[PATCH] D130964: [X86][BF16] Enable __bf16 for x86 targets.

bkramer added a comment. In D130964#3694473 , @rjmccall wrote: > How are you actually implementing `__bf16` on these targets? There isn't > even hardware support for conversions. `bf16` -> `float` is really just a bit shift. The other direction gets lo

[PATCH] D27104: Unify and simplify the behavior of the hasDeclaration matcher.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg under the precondition that clang-tidy tests still work. https://reviews.llvm.org/D27104 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D36095: [clangd] Allow to get vfs::FileSystem used inside codeComplete.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg (it could use a test case though) https://reviews.llvm.org/D36095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D36133: [clangd] Rewrote AST and Preamble management.

bkramer added inline comments. Comment at: clangd/ClangdServer.h:113 + /// queue. The request will be run on a separate thread. + template void addToFront(Func &&F, Args &&... As); + /// Add a new request to run function \p F with args \p As to the end of the ---

[PATCH] D36133: [clangd] Rewrote AST and Preamble management.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. ship it! https://reviews.llvm.org/D36133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D36154: Adapt clang-tidy checks to changing semantics of hasDeclaration.

bkramer added inline comments. Comment at: clang-tidy/google/StringReferenceMemberCheck.cpp:31 + auto String = anyOf(namedDecl(hasName("::std::string")), recordDecl(hasName("::string"))); auto ConstString = qualType(isConstQualified(), hasDeclaration(St

[PATCH] D36154: Adapt clang-tidy checks to changing semantics of hasDeclaration.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good https://reviews.llvm.org/D36154 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

bkramer added inline comments. Comment at: include/clang/Sema/Sema.h:2681 + bool PartialOverloading = false, + bool ExtraFirstArgument = false); void AddMethodCandidate(DeclAccessPair FoundDecl, Shouldn't this be calle

[PATCH] D36187: [clang-diff] Use the relative name for NamedDecls

bkramer added a comment. There's some similar code in tools/clang/lib/Tooling/Core/Lookup.cpp, it might make sense to share it. Otherwise this looks good. Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:391 + if (!ContextPrefix.empty() && + Val.substr(0, ContextPrefix.size()

[PATCH] D36458: Fix crash when current lexer is nullptr

bkramer added a comment. Test case? https://reviews.llvm.org/D36458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

bkramer added inline comments. Comment at: include/clang/Sema/Sema.h:2681 + bool PartialOverloading = false, + bool ExtraFirstArgument = false); void AddMethodCandidate(DeclAccessPair FoundDecl, I'd prefer something li

[PATCH] D36458: Fix crash when current lexer is nullptr

bkramer added a comment. Changes like this should come with a small, c-index-test based, test case so we don't reintroduce the same bug in the future. https://reviews.llvm.org/D36458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D36397: [clangd] Fixed a data race.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I think this can be committed now. It's still a bit awkward but we can address that later. https://reviews.llvm.org/D36397 ___ cfe-commits mai

[PATCH] D36872: Fixed a crash on replaying Preamble's PP conditional stack.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks good to me. https://reviews.llvm.org/D36872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D36821: [libclang]: Honor LIBCLANG_NOTHREADS for clang_parseTranslationUnit*

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D36821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

bkramer added a comment. In D17993#2409401 , @brooksmoses wrote: > So, I have bad news: This causes OpenJDK to segfault. The relevant code is > here: > https://github.com/openjdk/jdk/blob/master/src/hotspot/share/memory/arena.cpp#L311 > > void Arena::d

[PATCH] D92297: [CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to dereferenceable_or_null

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. While it would be nice for `dereferenceable` to not imply nonnull, the implementation currently assumes it does and will speculate loads based on that. See `llvm::Value::getPointerDereferenc

[PATCH] D89708: Move clang/Tooling/Core/Lookup.h to clang/Tooling/Refactoring/Lookup.h

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89708/new/ https://reviews.llvm.org/D89708 _

[PATCH] D109865: [NFC] `goto fail` has failed us in the past...

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109865/new/ https://reviews.llvm.org/D109865 ___

[PATCH] D107760: [clang] Fix warning -Wnon-virtual-dtor.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107760/new/ https://reviews.llvm.org/D107760 ___

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

bkramer marked an inline comment as done. bkramer added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:513 if (Opts.MaxBitIntWidth) -MaxBitIntWidth = Opts.MaxBitIntWidth; +MaxBitIntWidth = (unsigned)Opts.MaxBitIntWidth; barannikov88 wrot

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

bkramer marked an inline comment as done. bkramer added a comment. In D140332#4005988 , @MaskRay wrote: > Can you push `using OptionalFileEntryRef = > CustomizableOptional;` and the renaming as a separate commit to > make this patch smaller? > There is

[PATCH] D137760: Add FP8 E4M3 support to APFloat.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137760/new/ https://reviews.llvm.org/D137760 _

[PATCH] D137760: Add FP8 E4M3 support to APFloat.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88eb3c62f25d: Add FP8 E4M3 support to APFloat. (authored by reedwm, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D133574: [C2x] reject type definitions in offsetof

bkramer added a comment. GitHub finds around 1.9k instances of this pattern to compute `alignof`. There's a lot of duplicates and `#ifdefs` so the real number is going to be smaller, but it seems to be quite common. The annoying part is that there is no `_Alignof` in C99 so for many of those pr

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571 ___

[PATCH] D156172: [clang][CodeGen] Emit annotations for function declarations.

bkramer added a comment. Reverted this in 88b7e06dcf9723d0869b0c6bee030b4140e4366d as it makes clang crash. Reduced test case in the commit description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D76703: [ARM][CMSE] Fix clang/test/Driver/save-temps.c test.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76703/new/ https://reviews.llvm.org/D76703 ___

[PATCH] D74954: Add a basic tiling pass for parallel loops

bkramer updated this revision to Diff 246167. bkramer added a comment. Herald added a subscriber: wuzish. Herald added a reviewer: mclow.lists. - WTF phab? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74954/new/ https://reviews.llvm.org/D74954 Fi

[PATCH] D74954: Add a basic tiling pass for parallel loops

bkramer updated this revision to Diff 246166. bkramer marked 4 inline comments as done. bkramer added a comment. Herald added subscribers: libc-commits, libcxx-commits, lldb-commits, Sanitizers, cfe-commits, bader, kerbowa, csigg, usaxena95, jdoerfert, ormris, jsji, kadircet, rupprecht, jfb, arph

[PATCH] D70488: [InstCombine] Infer fast math flags on fadd/fsub/fmul/fcmp

bkramer created this revision. bkramer added a reviewer: spatel. Herald added subscribers: cfe-commits, hiraditya. Herald added projects: clang, LLVM. Applies nnan, ninf and nsz. This allows more instructions to be folded away even with no fast math flags, e.g. (int)x * (b ? 1.0 : 0.0) -> b ? x :

[PATCH] D70488: [InstCombine] Infer fast math flags on fadd/fsub/fmul/fcmp

bkramer updated this revision to Diff 230245. bkramer added a comment. Fix condition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70488/new/ https://reviews.llvm.org/D70488 Files: clang/test/CodeGen/builtins-systemz-zvector.c llvm/lib/Transfo

[PATCH] D70518: [clang-include-fixer] Suppress cmd prompt from Vim on Windows

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70518/new/ https://reviews.llvm.org/D70518 ___

[PATCH] D70488: [InstCombine] Infer fast math flags on fadd/fsub/fmul/fcmp

bkramer added a comment. In D70488#1753897 , @mcberg2017 wrote: > For us this would be an impediment as we have math models that want ieee > behavior while relaxing precision. Adding nnan or ninf would obstruct those > choices. Mind elaborating why nn

[PATCH] D70902: Fix compatibility with python3 of clang-include-fixer.py

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70902/new/ https://reviews.llvm.org/D70902 ___

[PATCH] D70902: Fix compatibility with python3 of clang-include-fixer.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa189ed25fbd: Fix compatibility with python3 of clang-include-fixer.py (authored by Yannick Brehon , committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D76272: Fix memtag test.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Right, we don't have names for values in release builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76272/new/ https://reviews.llvm.org/D76

[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

bkramer accepted this revision. bkramer added a comment. Push and watch the bots Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74384/new/ https://reviews.llvm.org/D74384 ___ cfe-commits mailing list cf

  1   2   3   >