bkramer added inline comments.
================
Comment at: clangd/ClangdServer.h:113
+ /// queue. The request will be run on a separate thread.
+ template <class Func, class... Args> void addToFront(Func &&F, Args &&...
As);
+ /// Add a new request to run function \p F with args \p As to the end of the
----------------
Why the template? This is awkward now because it can only be called from
ClangdServer.cpp
================
Comment at: clangd/ClangdUnit.cpp:887-889
+tooling::CompileCommand const &CppFile::getCompileCommand() const {
+ return Command;
+}
----------------
Move implementation into header
================
Comment at: clangd/ClangdUnit.cpp:910
+ return WasCancelledBeforeConstruction;
+}
+
----------------
Move implementation into header.
================
Comment at: clangd/ClangdUnit.h:104
- ~ParsedAST();
+// Providse thread-safe access to ParsedAST.
+class ParsedASTWrapper {
----------------
Typo: Providse
================
Comment at: clangd/ClangdUnitStore.cpp:22
return;
OpenedFiles.erase(It);
}
----------------
Not introduced in this commit, but this is equivalent to
OpenedFiles.erase(File) without the find and check.
https://reviews.llvm.org/D36133
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
