bkramer marked an inline comment as done. bkramer added a comment. In D140332#4005988 <https://reviews.llvm.org/D140332#4005988>, @MaskRay wrote:
> Can you push `using OptionalFileEntryRef = > CustomizableOptional<FileEntryRef>;` and the renaming as a separate commit to > make this patch smaller? > There is a smaller that this rename may be reverted. > 205c0589f918f95d2f2c586a01bea2716d73d603 > <https://reviews.llvm.org/rG205c0589f918f95d2f2c586a01bea2716d73d603> > reverted a change related to `OptionalFileEntryRef`. I assume that your > change is fine. Yeah, I'll split this into smaller pieces once we agree on the direction and just submit the alias. I expect a revert or two. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140332/new/ https://reviews.llvm.org/D140332 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
