bkramer requested changes to this revision. bkramer added inline comments. This revision now requires changes to proceed.
================ Comment at: clangd/Context.h:79 +/// Otherwise returns an empty Context. +Context &globalCtx(); + ---------------- This is a giant code smell. If we want the context route, please pass contexts everywhere. I really don't want this kind of technical debt in clangd now. https://reviews.llvm.org/D40485 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
