[clang] fc2d832 - Reland "[RISCV][NFC] Moving RVV intrinsic type related util to llvm/Support"

2022-04-08 Thread Kito Cheng via cfe-commits
Author: Kito Cheng Date: 2022-04-08T15:09:03+08:00 New Revision: fc2d8326ae4d6e05c1aa2db7e7dbd8e759bf4d51 URL: https://github.com/llvm/llvm-project/commit/fc2d8326ae4d6e05c1aa2db7e7dbd8e759bf4d51 DIFF: https://github.com/llvm/llvm-project/commit/fc2d8326ae4d6e05c1aa2db7e7dbd8e759bf4d51.diff LO

[clang] b672638 - [clang][deps] Ensure deterministic filename case

2022-04-08 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2022-04-08T09:18:00+02:00 New Revision: b672638dbc7cec9a51826520e8f8aef276bac3ee URL: https://github.com/llvm/llvm-project/commit/b672638dbc7cec9a51826520e8f8aef276bac3ee DIFF: https://github.com/llvm/llvm-project/commit/b672638dbc7cec9a51826520e8f8aef276bac3ee.diff L

[PATCH] D123229: [clang][deps] Ensure deterministic filename case

2022-04-08 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb672638dbc7c: [clang][deps] Ensure deterministic filename case (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

2022-04-08 Thread Dave Green via Phabricator via cfe-commits
dmgreen added a comment. Looks OK to me, as far as I can see. If it worth adding a few extra instructions that may come up? Comment at: llvm/lib/Target/ARM/ARMFixCortexA57AES1742098Pass.cpp:146 + case ARM::VMVNd: + case ARM::VMVNq: + // VMOV of 64-bit value between D regist

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

2022-04-08 Thread Fütő Gergely via Phabricator via cfe-commits
futogergely updated this revision to Diff 421435. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91000/new/ https://reviews.llvm.org/D91000 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt clang-tools-extra/clan

[PATCH] D123299: [clang-format][docs] Fix incorrect 'clang-format 9' option marker

2022-04-08 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123299/new/ https://reviews.llvm.org/D123299 ___

[clang] 301e0d9 - [Clang][Fortify] drop inline decls when redeclared

2022-04-08 Thread via cfe-commits
Author: serge-sans-paille Date: 2022-04-08T09:31:51+02:00 New Revision: 301e0d91354b853addb63a35e72e552e8059413e URL: https://github.com/llvm/llvm-project/commit/301e0d91354b853addb63a35e72e552e8059413e DIFF: https://github.com/llvm/llvm-project/commit/301e0d91354b853addb63a35e72e552e8059413e.d

[PATCH] D123308: Handle a subtle hole in inline builtin handling

2022-04-08 Thread serge via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG301e0d91354b: [Clang][Fortify] drop inline decls when redeclared (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D123308?vs=421187&id=421438#toc Repository: rG LLVM

[PATCH] D123308: Handle a subtle hole in inline builtin handling

2022-04-08 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. @nickdesaulniers changes taken into account and pushed, thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123308/new/ https://reviews.llvm.org/D123308 __

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

2022-04-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 421444. hokein marked 5 inline comments as done. hokein added a comment. address some comments, and cleanups. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123127/new/ https://reviews.llvm.org/D123127 Files:

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

2022-04-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang/lib/AST/TemplateName.cpp:80 TemplateName::TemplateName(DependentTemplateName *Dep) : Storage(Dep) {} +TemplateName::TemplateName(UsingShadowDecl *Using) : Storage(Using) {} sammccall wrote: > assert(isa(Using->ge

[clang] f60dc3c - [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

2022-04-08 Thread Iain Sandoe via cfe-commits
Author: Iain Sandoe Date: 2022-04-08T08:57:37+01:00 New Revision: f60dc3caa67374c0e2941ee3866b5eaef0c6ffe6 URL: https://github.com/llvm/llvm-project/commit/f60dc3caa67374c0e2941ee3866b5eaef0c6ffe6 DIFF: https://github.com/llvm/llvm-project/commit/f60dc3caa67374c0e2941ee3866b5eaef0c6ffe6.diff L

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

2022-04-08 Thread Iain Sandoe via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf60dc3caa673: [C++20][Modules] Adjust handling of exports of namespaces and using-decls. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D121984: [RISCV][NFC] Moving RVV intrinsic type related util to llvm/Support

2022-04-08 Thread Kito Cheng via Phabricator via cfe-commits
kito-cheng added a comment. Oh, apology, I guess I just miss the discussion, let me revert that again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121984/new/ https://reviews.llvm.org/D121984 ___ cfe-c

[clang] fd8e576 - [analyzer] Don't track function calls as control dependencies

2022-04-08 Thread Kristóf Umann via cfe-commits
Author: Kristóf Umann Date: 2022-04-08T10:16:58+02:00 New Revision: fd8e5762f86f0a602ec08eea5c4c86927faba6dc URL: https://github.com/llvm/llvm-project/commit/fd8e5762f86f0a602ec08eea5c4c86927faba6dc DIFF: https://github.com/llvm/llvm-project/commit/fd8e5762f86f0a602ec08eea5c4c86927faba6dc.diff

[PATCH] D116597: [analyzer] Don't track function calls as control dependencies

2022-04-08 Thread Kristóf Umann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Szelethus marked an inline comment as done. Closed by commit rGfd8e5762f86f: [analyzer] Don't track function calls as control dependencies (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D116597

[clang] f922dbb - Revert "Reland "[RISCV][NFC] Moving RVV intrinsic type related util to llvm/Support""

2022-04-08 Thread Kito Cheng via cfe-commits
Author: Kito Cheng Date: 2022-04-08T16:20:19+08:00 New Revision: f922dbb7923f73bab058d09346a2ec0b40ae3cb2 URL: https://github.com/llvm/llvm-project/commit/f922dbb7923f73bab058d09346a2ec0b40ae3cb2 DIFF: https://github.com/llvm/llvm-project/commit/f922dbb7923f73bab058d09346a2ec0b40ae3cb2.diff LO

[PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

2022-04-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. +1, I think this is an improvement, it looks good overall, some nits. Comment at: clang-tools-extra/CMakeLists.txt:49 +endif() + nit: remove the extra blank line. Comment at: clang/CMakeLists.txt:196 +umbrella_lit_

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

2022-04-08 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 421454. cor3ntin marked 6 inline comments as done. cor3ntin added a comment. Address ChuanqiXu's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136 Files: cla

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

2022-04-08 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 421456. cor3ntin added a comment. - Address ChuanqiXu's comments - Add an entry in ReleaseNotes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136 Files: clang/docs/R

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

2022-04-08 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/lib/Sema/Scope.cpp:72 + // Lambdas have an extra prototype scope that doesn't add any depth + if (flags & FunctionPrototypeScope && !(flags & LambdaScope)) +PrototypeDepth++; ChuanqiXu wrote: > cor3ntin wrot

[PATCH] D123370: [CUDA/HIP] Remove argument from module ctor/dtor signatures

2022-04-08 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld created this revision. Hahnfeld added reviewers: tra, yaxunl. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In theory, constructors can take arguments when called via `.init_array` where at l

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

2022-04-08 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. You have a single bool property, yet you allow to enable/disable this by each sub-checker. It feels like the last checker in the registration process will rule them all. That being said, in the fixit creation scope, you check for both this flag and the presence of the

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

2022-04-08 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 421461. cor3ntin added a comment. Add dependent tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/

[PATCH] D123372: [PowerPC] add XLC compat builtin __abs

2022-04-08 Thread ChenZheng via Phabricator via cfe-commits
shchenz created this revision. shchenz added reviewers: stefanp, nemanjai, jsji, qiucf, PowerPC. Herald added a subscriber: kbarton. Herald added a project: All. shchenz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is supplement of

[PATCH] D123243: [pseudo] Strip directives from a token stream

2022-04-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/DirectiveTree.cpp:373 +case DirectiveTree::Chunk::K_Empty: + break; +} return, otherwise we we hit the unreachable code below. Comment at: clang-tools-extra/pse

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

2022-04-08 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added a comment. Herald added a subscriber: StephenFan. @fhahn Remind me - why did you want me to split these? If we're initially just going for integer support, can't both be done at the same time in this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D122732: [Clang][AArch64][SVE] Allow subscript operator for SVE types

2022-04-08 Thread Bradley Smith via Phabricator via cfe-commits
bsmith accepted this revision. bsmith added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122732/new/ https://reviews.llvm.org/D122732 __

[PATCH] D121984: [RISCV][NFC] Moving RVV intrinsic type related util to llvm/Support

2022-04-08 Thread Kito Cheng via Phabricator via cfe-commits
kito-cheng updated this revision to Diff 421477. kito-cheng added a comment. Changes: - Move those stuffs into clang/Support instead of llvm/Support - Keep table gen staffs in clang/utils/TableGen/RISCVVEmitter.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D121984: [RISCV][NFC] Moving RVV intrinsic type related util to llvm/Support

2022-04-08 Thread Kito Cheng via Phabricator via cfe-commits
kito-cheng added a comment. @MaskRay I've move those stuffs into clang/Support which is introduce by this patch, and also keep those table gen stuffs in clang-tblgen, did you mind take a look? Thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] 1331ad2 - [OpenCL] Add generic addrspace guards for get_fence

2022-04-08 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-04-08T12:08:10+01:00 New Revision: 1331ad22c31fc2ed6890fa046c1e2333e369251b URL: https://github.com/llvm/llvm-project/commit/1331ad22c31fc2ed6890fa046c1e2333e369251b DIFF: https://github.com/llvm/llvm-project/commit/1331ad22c31fc2ed6890fa046c1e2333e369251b.

[PATCH] D121556: [randstruct] Add randomize structure layout support

2022-04-08 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Precommit CI is failing on one test: Failed Tests (1): Clang :: Misc/pragma-attribute-supported-attributes-list.test but with that test fixed, this LGTM! (Feel free to land wi

[PATCH] D123298: [NFC] [AST] Reduce the size of TemplateParmPosition

2022-04-08 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/AST/DeclTemplate.h:1151-1152 protected: - // FIXME: These probably don't need to be ints. int:5 for depth, int:8 for - // position? Maybe? - unsigned Depth; - unsigned Position; +#define DEPTH_BITWIDTH 20 +

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

2022-04-08 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/docs/HLSLSupport.rst:150-152 +HLSL has a ``precise`` qualifier that behaves unlike anything else in the C +language. The support for this qualifier in DXC is buggy, so our bar for +compatibility is low. beanz

[PATCH] D101624: [clang-tidy] Make performance-inefficient-vector-operation work on members

2022-04-08 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Sorry, this fell off my radar! LGTM, but please add a release note for the fix when landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D121375: [clang] NFC, move the utility function CompilerInvocation::setLangDefaults to LangOptions.h

2022-04-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 421494. hokein marked 2 inline comments as done. hokein added a comment. address comments; move to LangOpts::setLangDefaults; pull out a getNameKind in LangStandard; remove the old API in CompilerInvocation; Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D121375: [clang] NFC, move the utility function CompilerInvocation::setLangDefaults to LangOptions.h

2022-04-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. Thanks for all comments! Comment at: clang/include/clang/Basic/LangOptions.h:519-521 +void setLangDefaults(LangOptions &Opts, Language Lang, const llvm::Triple &T, + std::vector &Includes, + LangStandard::Kind Lang

[PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

2022-04-08 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added a comment. LG to me with the comments that Haojian made! Comment at: llvm/cmake/modules/AddLLVM.cmake:1827 +# Convert a target name like check-clangd to a variable name like CLANG. +function(umbrella_lit_testsuite_var target outvar) hokein wrot

[PATCH] D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py

2022-04-08 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 421502. bernhardmgruber added a comment. Rebased on main and applied review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123065/new/ https://reviews.llvm.org/D123065 Files: clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py

[PATCH] D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py

2022-04-08 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 421503. bernhardmgruber added a comment. Added missing '.' in helptext. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123065/new/ https://reviews.llvm.org/D123065 Files: clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py clang-tools-e

[PATCH] D123303: [Clang][AArch64][SVE] Add shift operators for SVE vector types

2022-04-08 Thread Dinar Temirbulatov via Phabricator via cfe-commits
dtemirbulatov added a comment. LGTM, Any remarks from others? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123303/new/ https://reviews.llvm.org/D123303 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

2022-04-08 Thread Martin Böhme via Phabricator via cfe-commits
mboehme updated this revision to Diff 421506. mboehme added a comment. Documentation: Added discussion of type system implications and fixed syntax error in example. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111548/new/ https://reviews.llvm.org

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

2022-04-08 Thread Martin Böhme via Phabricator via cfe-commits
mboehme marked 2 inline comments as done. mboehme added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6387 +additional information specific to the annotation category. The optional +arguments must be constant expressions of arbitrary type. +

[clang-tools-extra] 0e0b0fe - [clang-tidy] Make performance-inefficient-vector-operation work on members

2022-04-08 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2022-04-08T14:17:41+01:00 New Revision: 0e0b0feff194358e5e68bf36f5a563d269fa8e88 URL: https://github.com/llvm/llvm-project/commit/0e0b0feff194358e5e68bf36f5a563d269fa8e88 DIFF: https://github.com/llvm/llvm-project/commit/0e0b0feff194358e5e68bf36f5a563d269fa8e88.diff

[PATCH] D101624: [clang-tidy] Make performance-inefficient-vector-operation work on members

2022-04-08 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0e0b0feff194: [clang-tidy] Make performance-inefficient-vector-operation work on members (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D101624?vs=341877&id=421508#toc Reposi

[clang] 692a147 - [CGCall] Make findDominatingStoreToReturnValue() more robust

2022-04-08 Thread Nikita Popov via cfe-commits
Author: Nikita Popov Date: 2022-04-08T15:18:12+02:00 New Revision: 692a147bf4339380ccfea7418cbedcea540cfaef URL: https://github.com/llvm/llvm-project/commit/692a147bf4339380ccfea7418cbedcea540cfaef DIFF: https://github.com/llvm/llvm-project/commit/692a147bf4339380ccfea7418cbedcea540cfaef.diff

[PATCH] D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions

2022-04-08 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I'm going to accept, I am ok with it as-is, though I would like to see @ChuanqiXu be accepting of whatever we do in Sema's enum as well. So please wait for his feedback too. ==

[PATCH] D123387: [clang-offload-bundler] fix "no output file" issue with -outputs

2022-04-08 Thread Siu Chi Chan via Phabricator via cfe-commits
scchan created this revision. scchan added reviewers: yaxunl, saiislam, ronlieb. Herald added a project: All. scchan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix backward compatibility issue due to D120662

[clang] ae37757 - [OpenMP] Remove help and documentation for old flag

2022-04-08 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2022-04-08T10:16:33-04:00 New Revision: ae377575b23b07107c08627357821a131a2ab1e0 URL: https://github.com/llvm/llvm-project/commit/ae377575b23b07107c08627357821a131a2ab1e0 DIFF: https://github.com/llvm/llvm-project/commit/ae377575b23b07107c08627357821a131a2ab1e0.diff

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

2022-04-08 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6409-6411 +- The attribute will not cause any additional data to be output to LLVM IR, + object files or debug information. It is only intended to be consumed using + Clang APIs by source-lev

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

2022-04-08 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Also, you should add a release note about the new attribute and check the Precommit CI pipeline failure out: Failed Tests (1): Clang :: CodeGenCXX/annotate-type.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

2022-04-08 Thread Chris Bieneman via Phabricator via cfe-commits
beanz marked 30 inline comments as done. beanz added inline comments. Comment at: clang/docs/HLSLSupport.rst:150-152 +HLSL has a ``precise`` qualifier that behaves unlike anything else in the C +language. The support for this qualifier in DXC is buggy, so our bar for +compatibili

[PATCH] D122841: [analyzer] Consider all addrspaces in null dereference check

2022-04-08 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers updated this revision to Diff 421519. vabridgers added a comment. add option, retain legacy behavior per comments. update rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122841/new/ https://reviews.llvm.org/D122841 Files: clang/docs

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

2022-04-08 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers updated this revision to Diff 421521. vabridgers edited the summary of this revision. vabridgers added a comment. clean up a few debug edits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122841/new/ https://reviews.llvm.org/D122841 File

[clang] be93716 - Clarify language option default value behavior; NFC

2022-04-08 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2022-04-08T10:26:16-04:00 New Revision: be9371659380388a693ec99624e1f3d02f07047f URL: https://github.com/llvm/llvm-project/commit/be9371659380388a693ec99624e1f3d02f07047f DIFF: https://github.com/llvm/llvm-project/commit/be9371659380388a693ec99624e1f3d02f07047f.diff

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

2022-04-08 Thread Jakub Kuderski via Phabricator via cfe-commits
kuhar accepted this revision. kuhar added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/docs/HLSLSupport.rst:223 +* References +* goto or labels +* Variable Length Arrays nit, for consistency with the other list items: make

[PATCH] D123387: [clang-offload-bundler] fix "no output file" issue with -outputs

2022-04-08 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. Does this mean without this fix clang-offload-bundler emits an error if -outputs option not given? How could the lit tests passed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

2022-04-08 Thread Chris Bieneman via Phabricator via cfe-commits
beanz updated this revision to Diff 421524. beanz added a comment. Updating based on feedback :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123278/new/ https://reviews.llvm.org/D123278 Files: clang/docs/HLSLSupport.rst clang/docs/index.rst

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

2022-04-08 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/docs/HLSLSupport.rst:150-152 +HLSL has a ``precise`` qualifier that behaves unlike anything else in the C +language. The support for this qualifier in DXC is buggy, so our bar for +compatibility is low. beanz

[PATCH] D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph

2022-04-08 Thread Daniel Grumberg via Phabricator via cfe-commits
dang created this revision. dang added reviewers: zixuw, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D123391 Files: cl

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

2022-04-08 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added inline comments. Comment at: clang/docs/HLSLSupport.rst:150-152 +HLSL has a ``precise`` qualifier that behaves unlike anything else in the C +language. The support for this qualifier in DXC is buggy, so our bar for +compatibility is low. aaron.ballman

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

2022-04-08 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. In D123319#3437250 , @dblaikie wrote: > (@probinson as someone I've disagreed with about this before) > > Personally I think there's limited value in expressing 'auto' in DWARF at all > - we could omit function declarations if

[PATCH] D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph

2022-04-08 Thread Victoria Mitchell via Phabricator via cfe-commits
QuietMisdreavus added a comment. This looks good! Just one question. Comment at: clang/test/ExtractAPI/objc_interface.m:198 +"kind": "identifier", +"spelling": "getWithProperty:" + } I'm curious: Does this properly handle Object

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

2022-04-08 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/docs/HLSLSupport.rst:150-152 +HLSL has a ``precise`` qualifier that behaves unlike anything else in the C +language. The support for this qualifier in DXC is buggy, so our bar for +comp

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

2022-04-08 Thread Moshe via Phabricator via cfe-commits
MosheBerman added a comment. In D123352#3438475 , @steakhal wrote: > You have a single bool property, yet you allow to enable/disable this by each > sub-checker. It feels like the last checker in the registration process will > rule them all. > > That b

[PATCH] D115924: [ConstantFolding] Unify handling of load from uniform value

2022-04-08 Thread Nikita Popov via Phabricator via cfe-commits
nikic added inline comments. Comment at: llvm/lib/Analysis/ConstantFolding.cpp:722 + (Ty->isIntOrIntVectorTy() || Ty->isFPOrFPVectorTy())) +return Constant::getAllOnesValue(Ty); + return nullptr; cameron.mcinally wrote: > nikic wrote: > > cameron.mcinal

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

2022-04-08 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. Ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122335/new/ https://reviews.llvm.org/D122335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph

2022-04-08 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 421537. dang added a comment. Add test to check that ObjC methods with multiple external parameters get the correct name in subHeadings and navigator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123391/new/ http

[PATCH] D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph

2022-04-08 Thread Victoria Mitchell via Phabricator via cfe-commits
QuietMisdreavus accepted this revision. QuietMisdreavus added a comment. This revision is now accepted and ready to land. Looks great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123391/new/ https://reviews.llvm.org/D123391 _

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

2022-04-08 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added inline comments. Comment at: clang/docs/analyzer/checkers.rst:69-74 +Check for dereferences of null pointers. This checker specifically does +not report null pointer dereferences for x86 and x86-64 targets when the +address space is 256 (x86 GS Segment), 257 (x86 F

[PATCH] D123397: [clang][ASTImporter] Add import of attribute 'enable_if'.

2022-04-08 Thread Balázs Kéri via Phabricator via cfe-commits
balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a subs

[PATCH] D123398: [VFS] RedirectingFileSystem only replace path if not already mapped

2022-04-08 Thread Ben Barham via Phabricator via cfe-commits
bnbarham created this revision. bnbarham added reviewers: dexonsmith, keith, JDevlieghere, vsapsai, sammccall. Herald added a subscriber: hiraditya. Herald added a project: All. bnbarham requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, c

[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

2022-04-08 Thread Ben Barham via Phabricator via cfe-commits
bnbarham abandoned this revision. bnbarham added a comment. Looks like there's more changes required for modulemap-collision.m to actually pass. I'll try figure those out when I have the time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123104/ne

[libunwind] 575a1d4 - NFC: Avoid unused variable warning in UnwindLevel1.c

2022-04-08 Thread via cfe-commits
Author: kristina Date: 2022-04-08T17:11:29+01:00 New Revision: 575a1d48e781a03a1bb892ff52e16ee0485d0a34 URL: https://github.com/llvm/llvm-project/commit/575a1d48e781a03a1bb892ff52e16ee0485d0a34 DIFF: https://github.com/llvm/llvm-project/commit/575a1d48e781a03a1bb892ff52e16ee0485d0a34.diff LOG:

[clang] 80ae366 - [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph

2022-04-08 Thread Daniel Grumberg via cfe-commits
Author: Daniel Grumberg Date: 2022-04-08T17:29:00+01:00 New Revision: 80ae366592924c8a32f81f96b316595ec90ec672 URL: https://github.com/llvm/llvm-project/commit/80ae366592924c8a32f81f96b316595ec90ec672 DIFF: https://github.com/llvm/llvm-project/commit/80ae366592924c8a32f81f96b316595ec90ec672.dif

[PATCH] D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph

2022-04-08 Thread Daniel Grumberg via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80ae36659292: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph (authored by dang). Repository: rG LLVM Github Monorepo CH

[PATCH] D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr

2022-04-08 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added projects: clang, OpenMP. Herald added subscribers: arphaman, guansong, yaxunl. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. jyu2 requested review of this revision. Herald added subsc

[PATCH] D123403: [OpenMP] Refactor OMPScheduleType enum.

2022-04-08 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur created this revision. Meinersbur added reviewers: peixin, tianshilei1992, jdoerfert, sriharikrishna, Leporacanthicus, kiranchandramohan, clementval. Meinersbur added a project: OpenMP. Herald added subscribers: awarzynski, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, ormris, dcaballe,

[PATCH] D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

2022-04-08 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 421555. jhuber6 added a comment. Update handling for fatbinaries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120273/new/ https://reviews.llvm.org/D120273 Files: clang/tools/clang-linker-wrapper/ClangLinke

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

2022-04-08 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added reviewers: Szelethus, steakhal. steakhal added a comment. tldr; static-analyzer fixits are not completely implemented. We don't even have tests for it, which is a shame. When I passed the `apply-fixits`, it modified the input source file - as I expected. Then I tried the `-analyze

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

2022-04-08 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon updated this revision to Diff 421556. RKSimon added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117829/new/ https://reviews.llvm.org/D117829 Files: clang/include/clang/Basic/Builtins.def clang/lib/CodeGen/CGBuiltin.

[PATCH] D123387: [clang-offload-bundler] fix "no output file" issue with -outputs

2022-04-08 Thread Saiyedul Islam via Phabricator via cfe-commits
saiislam accepted this revision. saiislam added a comment. In D123387#3439069 , @yaxunl wrote: > Does this mean without this fix clang-offload-bundler emits an error if > -outputs option not given? How could the lit tests passed? I think lit tests were

[PATCH] D123405: [dllexport] odr-use constexpr default args for constructor closures

2022-04-08 Thread Hans Wennborg via Phabricator via cfe-commits
hans created this revision. hans added reviewers: rnk, mstorsjo, thakis. Herald added a project: All. hans requested review of this revision. Herald added a project: clang. InstantiateDefaultCtorDefaultArgs() is supposed to mark default constructor args as odr-used, since those args will be used

[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

2022-04-08 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 421562. cor3ntin added a comment. Add fix hint tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang

[PATCH] D119544: Deferred Concept Instantiation Implementation

2022-04-08 Thread Erich Keane via Phabricator via cfe-commits
erichkeane updated this revision to Diff 421564. erichkeane marked an inline comment as done. erichkeane added a comment. rebase for CI + comment change requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119544/new/ https://reviews.llvm.org/D119544 Files: clang/docs/ReleaseNote

[PATCH] D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr

2022-04-08 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. I think it worth it to add the analysis test for the clause Comment at: clang/lib/AST/OpenMPClause.cpp:1465 + + OMPHasDeviceAddrClause *Clause = + new (Mem) OMPHasDeviceAddrClause(Locs, Sizes); `auto *` Comment

[PATCH] D123387: [clang-offload-bundler] fix "no output file" issue with -outputs

2022-04-08 Thread Saiyedul Islam via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0f6cbdee5761: [clang-offload-bundler] fix "no output file" issue with -outputs (authored by scchan, committed by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang] 0f6cbde - [clang-offload-bundler] fix "no output file" issue with -outputs

2022-04-08 Thread Saiyedul Islam via cfe-commits
Author: Siu Chi Chan Date: 2022-04-08T17:11:27Z New Revision: 0f6cbdee576160a3b40139bf66b864ce05a1e28f URL: https://github.com/llvm/llvm-project/commit/0f6cbdee576160a3b40139bf66b864ce05a1e28f DIFF: https://github.com/llvm/llvm-project/commit/0f6cbdee576160a3b40139bf66b864ce05a1e28f.diff LOG:

[clang] 9e3678e - [Clang] [Docs] Add HLSLSupport page

2022-04-08 Thread Chris Bieneman via cfe-commits
Author: Chris Bieneman Date: 2022-04-08T12:17:45-05:00 New Revision: 9e3678e161553f29df1408f1b7c7ffc14fc0ef17 URL: https://github.com/llvm/llvm-project/commit/9e3678e161553f29df1408f1b7c7ffc14fc0ef17 DIFF: https://github.com/llvm/llvm-project/commit/9e3678e161553f29df1408f1b7c7ffc14fc0ef17.diff

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

2022-04-08 Thread Chris Bieneman via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e3678e16155: [Clang] [Docs] Add HLSLSupport page (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

2022-04-08 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. If you need a -static-libstdc++ not subject to unused argument warning, D53238 -static=c++stdlib may be a better choice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121560/new/ https://reviews.llvm.org/D121560 __

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

2022-04-08 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:814-815 +diagExportedUnnamedDecl(S, UnnamedDeclKind::Namespace, D, BlockStart); + else +; // We allow an empty named namespace decl. +} else if (DC->getRedeclContext()->isFileCont

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

2022-04-08 Thread Mitch Phillips via Phabricator via cfe-commits
hctim updated this revision to Diff 421581. hctim added a comment. Comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clan

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

2022-04-08 Thread Mitch Phillips via Phabricator via cfe-commits
hctim added a comment. Over to @eugenis for any final touches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D123405: [dllexport] odr-use constexpr default args for constructor closures

2022-04-08 Thread Nico Weber via Phabricator via cfe-commits
thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123405/new/ https://reviews.llvm.org/D123405 ___

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

2022-04-08 Thread Moshe via Phabricator via cfe-commits
MosheBerman added a comment. In D123352#3439390 , @steakhal wrote: > tldr; static-analyzer fixits are not completely implemented. Where can I learn more about this? Would it be possible and idiomatically/architecturally sounds to write a clang-tidy tha

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

2022-04-08 Thread Moshe via Phabricator via cfe-commits
MosheBerman updated this revision to Diff 421587. MosheBerman added a comment. - Changed the ShowFixIts flag to be per-checker. - Added support for syntax sugar (`nullable` vs `_Nullable`) - Pass FixItHint through, so we can do that. - Changed tests to use `-fdiagnostics-parseable-fixits`. This

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

2022-04-08 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Some drive by comments, I plan to do a more thorough review when I have the chance. Comment at: clang/docs/ReleaseNotes.rst:97 and `51641 `_. -- The builtin function __builtin_dump_struct woul

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

2022-04-08 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis accepted this revision. eugenis added a comment. LGTM Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:475 def err_stack_tagging_requires_hardware_feature : Error< - "'-fsanitize=memtag' requires hardware support (+memtag)">; + "'-fsanitize=memtag-stack

[PATCH] D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions

2022-04-08 Thread PoYao Chang via Phabricator via cfe-commits
rZhBoYao updated this revision to Diff 421589. rZhBoYao marked 2 inline comments as done. rZhBoYao set the repository for this revision to rG LLVM Github Monorepo. rZhBoYao added a comment. Reordered enumerators. Does this look good to you, @ChuanqiXu ? Repository: rG LLVM Github Monorepo CH

  1   2   >