eugenis accepted this revision. eugenis added a comment. LGTM
================ Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:475 def err_stack_tagging_requires_hardware_feature : Error< - "'-fsanitize=memtag' requires hardware support (+memtag)">; + "'-fsanitize=memtag-stack' requires hardware support (+memtag). For Armv8, " + "try compiling with -march=armv8a+memtag.">; ---------------- MaskRay wrote: > hctim wrote: > > eugenis wrote: > > > Split out renaming of memtag to memtag-stack first? This will remove a > > > lot of diff from this patch. > > splitting into elf -> lld -> clang as per Ray's suggestion, should reduce > > the diff enough. > The convention is to omit period for the last sentence. Mention armv9a, too? Something like "Try compiling with -march=armv9a, or -march=armv8a+memtag" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
