[PATCH] D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added a comment.

I think it worth it to add the analysis test for the clause



================
Comment at: clang/lib/AST/OpenMPClause.cpp:1465
+
+  OMPHasDeviceAddrClause *Clause =
+      new (Mem) OMPHasDeviceAddrClause(Locs, Sizes);
----------------
`auto *`


================
Comment at: clang/lib/Serialization/ASTReader.cpp:12848
+  Vars.reserve(NumVars);
+  for (unsigned i = 0; i != NumVars; ++i)
+    Vars.push_back(Record.readSubExpr());
----------------
Use `I` instead of `i` everywhere in this function


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:564
     VersionedClause<OMPC_IsDevicePtr>,
+    VersionedClause<OMPC_HasDeviceAddr>,
     VersionedClause<OMPC_Reduction>,
----------------
`VersionedClause<OMPC_HasDeviceAddr, 51>,`


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:661
     VersionedClause<OMPC_IsDevicePtr>,
+    VersionedClause<OMPC_HasDeviceAddr>,
     VersionedClause<OMPC_Allocate>,
----------------
`VersionedClause<OMPC_HasDeviceAddr, 51>,`


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:694
     VersionedClause<OMPC_IsDevicePtr>,
+    VersionedClause<OMPC_HasDeviceAddr>,
     VersionedClause<OMPC_Allocate>,
----------------
`VersionedClause<OMPC_HasDeviceAddr, 51>,`


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:711
     VersionedClause<OMPC_IsDevicePtr>,
+    VersionedClause<OMPC_HasDeviceAddr>,
     VersionedClause<OMPC_Allocator>,
----------------
`VersionedClause<OMPC_HasDeviceAddr, 51>,`


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:1145
     VersionedClause<OMPC_IsDevicePtr>,
+    VersionedClause<OMPC_HasDeviceAddr>,
     VersionedClause<OMPC_Allocate>,
----------------
`VersionedClause<OMPC_HasDeviceAddr, 51>,`


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:1176
     VersionedClause<OMPC_IsDevicePtr>,
+    VersionedClause<OMPC_HasDeviceAddr>,
     VersionedClause<OMPC_Allocate>,
----------------
`VersionedClause<OMPC_HasDeviceAddr, 51>,` and in other places


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123402/new/

https://reviews.llvm.org/D123402

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits