[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

mstorsjo added a subscriber: tstellar. mstorsjo added a comment. @tstellar, FYI there are still issues being reported with this commit (which was made before the branch). One fix is committed and a backport request was made in https://llvm.org/PR51261, but there’s still a couple other outstandin

[PATCH] D107051: [clang][analyzer] Improve bug report in alpha.security.ReturnPtrRange

balazske added inline comments. Comment at: clang/test/Analysis/return-ptr-range.cpp:1 -// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.security.ReturnPtrRange -verify %s +// RUN1: %clang_analyze_cc1 -analyzer-checker=alpha.security.ReturnPtrRange -verify %s +// RUN: %clang_

[PATCH] D107051: [clang][analyzer] Improve bug report in alpha.security.ReturnPtrRange

balazske updated this revision to Diff 362981. balazske added a comment. Changed way of generating notes. Re-structured the tests. Other small changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107051/new/ https://reviews.llvm.org/D107051 File

[PATCH] D107137: clangd: Provide hover info for include directives

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. It's quite useful

[PATCH] D107054: [Clang][CUDA] Add descriptors, mappings, and features for missing CUDA and PTX versions

steffenlarsen updated this revision to Diff 362986. steffenlarsen added a comment. Made sure the PTX73 and PTX74 macros are popped correctly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107054/new/ https://reviews.llvm.org/D107054 Files: clang/include/clang/Basic/BuiltinsNVPTX.def

[clang] 577220e - [OpenCL] Add std flag aliases clc++1.0 and CLC++1.0

Author: Anastasia Stulova Date: 2021-07-30T09:19:26+01:00 New Revision: 577220e89866608e0706e3a2b9f8f48215e4e811 URL: https://github.com/llvm/llvm-project/commit/577220e89866608e0706e3a2b9f8f48215e4e811 DIFF: https://github.com/llvm/llvm-project/commit/577220e89866608e0706e3a2b9f8f48215e4e811.d

[PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG577220e89866: [OpenCL] Add std flag aliases clc++1.0 and CLC++1.0 (authored by Anastasia). Changed prior to commit: https://reviews.llvm.org/D1062

[PATCH] D107054: [Clang][CUDA] Add descriptors, mappings, and features for missing CUDA and PTX versions

steffenlarsen marked an inline comment as done. steffenlarsen added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:821 #pragma pop_macro("PTX71") #pragma pop_macro("PTX72") tra wrote: > You need to pop new macros here. My bad! It has b

[PATCH] D107138: [PowerPC] Implement cmplxl builtins

Conanap created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Conanap requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch implements the builtins for cmplxl by utilising __builtin_complex. Thi

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

balazske added a comment. The bug type is passed to `constructNoteTag` only to identify what message will be displayed. The bug types that are related to the current function (a message should be here if the bug is happening) are passed in. It should be enough to look at comment before `constru

[PATCH] D106939: [RISCV] If the maskedoff is vundefined(), use ta, ma for vsetvli.

HsiangKai added a comment. In D106939#2915134 , @HsiangKai wrote: > In D106939#2912807 , @frasercrmck > wrote: > >> LGTM but there are test failures. Is that just a whole load of `mu->ma` >> changes that have be

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

pdhaliwal updated this revision to Diff 362997. pdhaliwal added a comment. It required some work to fix the failing lit test case. And many thanks to @estewart for helping in that. The current status is that we are now following the nvptx openmp strategy for openmp math headers very closely. In t

[PATCH] D107139: [RISCV] Rename vector inline constraint from 'v' to 'vr' and 'vm' in IR.

HsiangKai created this revision. HsiangKai added reviewers: craig.topper, khchen, kito-cheng, frasercrmck, rogfer01. Herald added subscribers: StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jo

[PATCH] D107141: [Inline-asm] Add semacheck for unsupported constraint

pengfei created this revision. pengfei added reviewers: jyu2, epastor, ABataev, kbsmith1, LuoYuanke. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang will crash if we tie a structure with a small size type. This patch adds chec

[clang] 8eaa05d - [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

Author: Ivan Murashko Date: 2021-07-30T12:40:38+03:00 New Revision: 8eaa05d06161db69e68ff2a5f4c8e3545a4e8080 URL: https://github.com/llvm/llvm-project/commit/8eaa05d06161db69e68ff2a5f4c8e3545a4e8080 DIFF: https://github.com/llvm/llvm-project/commit/8eaa05d06161db69e68ff2a5f4c8e3545a4e8080.diff

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8eaa05d06161: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch (authored by ivanmurashko, committed by DmitryPolukhin). Repository: rG LLVM

[PATCH] D107145: clangd: Add new semantic token modifier "virtual"

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is needed for

[PATCH] D107145: clangd: Add new semantic token modifier "virtual"

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. The modifier seems reasonable to me. The most important cases are callsites (where `virtual`) isn't written. Can you extend a test to cover some such case? Repository: rG LLVM Github

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 added a comment. Passed PSDB Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D107145: clangd: Add new semantic token modifier "virtual"

ckandeler updated this revision to Diff 363031. ckandeler added a comment. Extended test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107145/new/ https://reviews.llvm.org/D107145 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp c

[PATCH] D107026: [Clang] Add support for attribute 'escape'

aaron.ballman added a comment. > The attribute will first be used by the Swift compiler in a new implicit > bridging diagnostic, but may have other non-Swift use-cases for diagnostics. This means there's no use of this attribute within Clang which suggests to me that this attribute belongs in t

[PATCH] D107151: [OpenCL] Reduce duplicate defs by using multiclasses; NFC

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Builtin definitions with pointer arguments were duplicated to provide overloa

[PATCH] D106862: [clang][modules] Avoid creating partial FullSourceLoc for explicit modules imports

jansvoboda11 updated this revision to Diff 363033. jansvoboda11 edited the summary of this revision. jansvoboda11 added a comment. Remove assertion altogether. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106862/new/ https://reviews.llvm.org/D106862 Files: clang/include/clang/Basic/

[PATCH] D106862: [clang][modules] Avoid creating partial FullSourceLoc for explicit modules imports

jansvoboda11 requested review of this revision. jansvoboda11 added a comment. I investigated this a bit more. What previously lead me to believe that `SourceLoc::ID` is being modified from the outside was the way it's declared right after some `friend`s: class SourceLocation { friend clas

[PATCH] D107130: [clangd] Enable relative configs in check mode

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/tool/Check.cpp:275 Opts.ConfigProvider, nullptr); - WithContext Ctx(ContextProvider("")); + WithContext Ctx(ContextPro

[PATCH] D106934: [clangd] Do not inlay hints pertaining to code in other files

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/InlayHints.cpp:320 +// file that was included after the preamble), do not show in that case. +if (AST.getSourceManager(

[PATCH] D107040: [clangd] Make use of diagnostic tags for some clang diags

kadircet updated this revision to Diff 363038. kadircet added a comment. - Fix base Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107040/new/ https://reviews.llvm.org/D107040 Files: clang-tools-extra/clangd/Diagnostics.cpp clang-tools-extra/cl

[PATCH] D107130: [clangd] Enable relative configs in check mode

kadircet updated this revision to Diff 363040. kadircet marked an inline comment as done. kadircet added a comment. - Don't use local configs for temp files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107130/new/ https://reviews.llvm.org/D107130

[PATCH] D107040: [clangd] Make use of diagnostic tags for some clang diags

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:330 + +std::vector getDiagnosticTags(unsigned DiagID) { + static const llvm::DenseSet DeprecatedDiags = {

[PATCH] D106934: [clangd] Do not inlay hints pertaining to code in other files

kadircet added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:320 +// file that was included after the preamble), do not show in that case. +if (AST.getSourceManager().getFileID(FileRange->getBegin()) != MainFileID) + return; sa

[clang-tools-extra] c3682a2 - [clangd] Enable relative configs in check mode

Author: Kadir Cetinkaya Date: 2021-07-30T14:23:48+02:00 New Revision: c3682a22c227652558764c67a2529399c59e58e6 URL: https://github.com/llvm/llvm-project/commit/c3682a22c227652558764c67a2529399c59e58e6 DIFF: https://github.com/llvm/llvm-project/commit/c3682a22c227652558764c67a2529399c59e58e6.dif

[PATCH] D107130: [clangd] Enable relative configs in check mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3682a22c227: [clangd] Enable relative configs in check mode (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D107154: [OpenCL] Add support of __opencl_c_pipes feature macro.

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, dexonsmith, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 'pipe' keyword is introduced in OpenCL C 2.0: so

[PATCH] D107137: clangd: Provide hover info for include directives

sammccall added a comment. Thanks, this is great! I think we need to hold the line a bit on keeping different hovers uniform though. Comment at: clang-tools-extra/clangd/Hover.cpp:914 + HoverInfo HI; + HI.TargetFile = File->Definition; + return HI; -

[PATCH] D107154: [OpenCL] Add support of __opencl_c_pipes feature macro.

azabaznov updated this revision to Diff 363044. azabaznov added a comment. Fix doubling run lines, misprint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107154/new/ https://reviews.llvm.org/D107154 Files: clang/include/clang/Basic/LangOptions.d

[PATCH] D106669: [clangd] Unify compiler invocation creation

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Compiler.h:64 +/// Clears \p CI from options that are not supported by clangd, like codegen or +/// plugins.

[PATCH] D107138: [PowerPC] Implement cmplxl builtins

nemanjai requested changes to this revision. nemanjai added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:146 BUILTIN(__builtin_ppc_stfiw, "viC*d", "") +BUILTIN(__builtin_ppc_cmplxl, "XLdLdLd", "") ---

[PATCH] D107155: [clang][deps] Substitute clang-scan-deps executable in lit tests

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman, lxfind. jansvoboda11 added a project: clang. jansvoboda11 requested review of this revision. The lit tests for `clang-scan-deps` invoke the tool without going through the substitution system. While

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Requesting changes until my comment is answered/addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://revie

[PATCH] D106410: [PowerPC] Emit error for Altivec vector initializations when -faltivec-src-compat=gcc is specified

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. Other than the naming nit, this LGTM. Comment at: clang/include/clang/Sema/Sema.h:6103 + // these vectors on gcc (an error is emitted). + bool IsAltivecCompatGCC(Source

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

azabaznov added a comment. @airlied, can you please fix that to something like here https://godbolt.org/z/3Kbso8ca3? What currently we do have with your patch is that generic address space overload is always selected, but more strict overloading always exist in OpenCL C 3.0 (https://godbolt.org

[PATCH] D107040: [clangd] Make use of diagnostic tags for some clang diags

kadircet updated this revision to Diff 363053. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107040/new/ https://reviews.llvm.org/D107040 Files: clang-tools-

[clang-tools-extra] 5734652 - [clangd] Make use of diagnostic tags for some clang diags

Author: Kadir Cetinkaya Date: 2021-07-30T15:11:46+02:00 New Revision: 57346526c83e1fcf03baf80362fc2a9e6624f5fd URL: https://github.com/llvm/llvm-project/commit/57346526c83e1fcf03baf80362fc2a9e6624f5fd DIFF: https://github.com/llvm/llvm-project/commit/57346526c83e1fcf03baf80362fc2a9e6624f5fd.dif

[PATCH] D107040: [clangd] Make use of diagnostic tags for some clang diags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57346526c83e: [clangd] Make use of diagnostic tags for some clang diags (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D106550: [PowerPC] Allow MMA builtins to accpet restrict qualified pointers

nemanjai requested changes to this revision. nemanjai added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Sema/SemaChecking.cpp:7306 (!ExpectedType->isVoidPointerType() && - ArgType.getCanonicalType() != ExpectedType)) +

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. I think this is good enough for now, assuming the majority of OvO is running locally. More cleanups to do after landing. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D107154: [OpenCL] Add support of __opencl_c_pipes feature macro.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks We might need to fix the target triple in `clang/test/SemaOpenCL/invalid-pipes-cl2.0.cl` to avoid surprises with testing but it has better coverage if we don't though...

[PATCH] D106669: [clangd] Unify compiler invocation creation

kadircet updated this revision to Diff 363055. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106669/new/ https://reviews.llvm.org/D106669 Files: clang-tools-

[clang-tools-extra] 41e2422 - [clangd] Unify compiler invocation creation

Author: Kadir Cetinkaya Date: 2021-07-30T15:22:51+02:00 New Revision: 41e24222861fb5394ab4c7e892a7d7f2914b533e URL: https://github.com/llvm/llvm-project/commit/41e24222861fb5394ab4c7e892a7d7f2914b533e DIFF: https://github.com/llvm/llvm-project/commit/41e24222861fb5394ab4c7e892a7d7f2914b533e.dif

[PATCH] D106669: [clangd] Unify compiler invocation creation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41e24222861f: [clangd] Unify compiler invocation creation (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107154: [OpenCL] Add support of __opencl_c_pipes feature macro.

azabaznov added a comment. > We might need to fix the target triple in > clang/test/SemaOpenCL/invalid-pipes-cl2.0.cl to avoid surprises with testing > but it has better coverage if we don't though... Yeah, I am not sure now though. It's awful because testing is not deterministic as we have di

[clang-tools-extra] 8070bf8 - [clangd] Record remote index usage

Author: Kadir Cetinkaya Date: 2021-07-30T15:24:22+02:00 New Revision: 8070bf8c6e6afbf0b8a20322d935cb530b4b796a URL: https://github.com/llvm/llvm-project/commit/8070bf8c6e6afbf0b8a20322d935cb530b4b796a DIFF: https://github.com/llvm/llvm-project/commit/8070bf8c6e6afbf0b8a20322d935cb530b4b796a.dif

[PATCH] D106796: [clangd] Record remote index usage

This revision was automatically updated to reflect the committed changes. Closed by commit rG8070bf8c6e6a: [clangd] Record remote index usage (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106796/new/ https://reviews.llvm.org/

[PATCH] D107078: [analyzer] Catch leaking stack addresses via stack variables

martong added inline comments. Comment at: clang/test/Analysis/copy-elision.cpp:9-10 +// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -std=c++17 \ +// RUN:-analyzer-config elide-constructors=false -DNO_ELIDE_FLAG \ +// RUN:-analyzer-c

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

alexfh added a comment. Looking at this once again, I'm pretty sure that reverting this is much safer than trying to fix forward. Unless there's a really trivial fix to the outstanding issues, I'll revert this later today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

arsenm added a comment. Missing sema test for rejecting the builtins on targets that don't support this Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:201 +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_f32, "ff*1fi", "t", "gfx90a-insts") +TARGET_BUILTIN(__builti

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105981/new/ https://reviews.llvm.org/D105981 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D106934: [clangd] Do not inlay hints pertaining to code in other files

sammccall added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:320 +// file that was included after the preamble), do not show in that case. +if (AST.getSourceManager().getFileID(FileRange->getBegin()) != MainFileID) + return; k

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

lei added inline comments. Comment at: llvm/lib/Target/PowerPC/P9InstrResources.td:1434 + ADDEX, + ADDEX8 )> { let Unsupported = 1; } nemanjai wrote: > You have added the 64-bit version of this, but it seems this is only > available for 64-bit operands in 64-

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

yaxunl added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:201 +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_f32, "ff*1fi", "t", "gfx90a-insts") +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_2f16, "hh*1hi", "t", "gfx90a-insts") +TARGET_BU

[clang] 9830f90 - [AMDGPU][OpenMP] Support linking of math libraries

Author: Pushpinder Singh Date: 2021-07-30T13:53:44Z New Revision: 9830f902e4d087ecb1706912b730c046f20600ee URL: https://github.com/llvm/llvm-project/commit/9830f902e4d087ecb1706912b730c046f20600ee DIFF: https://github.com/llvm/llvm-project/commit/9830f902e4d087ecb1706912b730c046f20600ee.diff L

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rG9830f902e4d0: [AMDGPU][OpenMP] Support linking of math libraries (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105981/new/ https://

[PATCH] D106864: [clang][cli] Expose -fno-cxx-modules in cc1

jansvoboda11 updated this revision to Diff 363071. jansvoboda11 added a comment. Add negative test, check error messages. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106864/new/ https://reviews.llvm.org/D106864 Files: clang/include/clang/Driver/Options.td clang/lib/Frontend/Compi

[PATCH] D106864: [clang][cli] Expose -fno-cxx-modules in cc1

jansvoboda11 added inline comments. Comment at: clang/test/Modules/cxx20-disable.cpp:2 +// RUN: rm -rf %t && mkdir %t +// RUN: not %clang_cc1 -x objective-c++ -std=c++20 -fno-cxx-modules -I %t %s + arphaman wrote: > jansvoboda11 wrote: > > I'm not sure how to bes

[clang] 0a175ad - [clang][patch][FPEnv] Fix syntax errors in pragma float_control test

Author: Melanie Blower Date: 2021-07-30T09:59:45-04:00 New Revision: 0a175ad445f095caf59f7175fbc035464919b7a3 URL: https://github.com/llvm/llvm-project/commit/0a175ad445f095caf59f7175fbc035464919b7a3 DIFF: https://github.com/llvm/llvm-project/commit/0a175ad445f095caf59f7175fbc035464919b7a3.diff

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

sfertile added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1781 - // pragma align(packed). - if (isAIXLayout(Context) && !MaxFieldAlignment.isZero() && !FieldSize) -FieldAlign = std::min(FieldAlign, MaxFieldAlignmentInBits); stevewan

[PATCH] D107125: [Diagnostic] Split 'qualifier on reference type has no effect' out into a new flag

aaron.ballman added a comment. Thank you for this! The changes LGTM as far as they go, but I'd appreciate some test coverage that shows the new diagnostic can be disabled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107125/new/ https://reviews.l

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield accepted this revision. JonChesterfield added inline comments. Comment at: clang/lib/Headers/openmp_wrappers/cmath:113 +__DEVICE__ float lgamma(float __x) { return ::lgammaf(__x); } +//__DEVICE__ long long int llrint(float __x) { return ::llrintf(__x); } +//__DEVI

[PATCH] D107163: [OpenCL] __cpp_threadsafe_static_init is by default undefined in OpenCL mode

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Definition of __cpp_threadsafe_static_init macro is controlled by langu

[PATCH] D107137: clangd: Provide hover info for include directives

ckandeler updated this revision to Diff 363083. ckandeler added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107137/new/ https://reviews.llvm.org/D107137 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-ext

[clang] 5ea6117 - [PowerPC] Emit error for Altivec vector initializations when -faltivec-src-compat=gcc is specified

Author: Amy Kwan Date: 2021-07-30T09:35:43-05:00 New Revision: 5ea6117a9e9eae49ad1295fa422266ef3832e419 URL: https://github.com/llvm/llvm-project/commit/5ea6117a9e9eae49ad1295fa422266ef3832e419 DIFF: https://github.com/llvm/llvm-project/commit/5ea6117a9e9eae49ad1295fa422266ef3832e419.diff LOG:

[PATCH] D106410: [PowerPC] Emit error for Altivec vector initializations when -faltivec-src-compat=gcc is specified

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ea6117a9e9e: [PowerPC] Emit error for Altivec vector initializations when -faltivec-src… (authored by amyk). Changed prior to commit: https://rev

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

Sockke marked 2 inline comments as done. Sockke added a comment. In D106431#2913101 , @aaron.ballman wrote: > In D106431#2912589 , @Sockke wrote: > >> Thank you for your reply! I generally understand what you mea

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

whisperity added a comment. In D106431#2916542 , @Sockke wrote: > Cheers! Can it be merged? @aaron.ballman Yes, but I think the patch needs to be rebased first as the pre-merge checks CI system said "patch application failed". Do you have commit access?

[PATCH] D107163: [OpenCL] __cpp_threadsafe_static_init is by default undefined in OpenCL mode

Anastasia added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6150 options::OPT_fno_threadsafe_statics, -!IsWindowsMSVC || IsMSVC2015Compatible)) +!types::isOpenCL(InputType) && +

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

Sockke added a comment. In D106431#2916551 , @whisperity wrote: > In D106431#2916542 , @Sockke wrote: > >> Cheers! Can it be merged? @aaron.ballman > > Yes, but I think the patch needs to be rebased first as the

[PATCH] D107163: [OpenCL] __cpp_threadsafe_static_init is by default undefined in OpenCL mode

Topotuna marked an inline comment as done. Topotuna added inline comments. Comment at: clang/test/Driver/threadsafe-statics.clcpp:2 +// RUN: %clang -### -c -DNO_THREADSAFE_STATICS %s 2>&1 | FileCheck --check-prefix=CHECK-NO-THREADSAFE-STATICS %s +// RUN: %clang -### -fno-threads

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

pdhaliwal updated this revision to Diff 363090. pdhaliwal added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/ https://reviews.llvm.org/D104904 Files: clang/lib/Driver/ToolChains/Clang.cpp clang

[clang] 12da97e - [OpenMP][AMDGCN] Initial math headers support

Author: Pushpinder Singh Date: 2021-07-30T14:52:41Z New Revision: 12da97ea10a941f0123340831300d09a2121e173 URL: https://github.com/llvm/llvm-project/commit/12da97ea10a941f0123340831300d09a2121e173 DIFF: https://github.com/llvm/llvm-project/commit/12da97ea10a941f0123340831300d09a2121e173.diff L

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12da97ea10a9: [OpenMP][AMDGCN] Initial math headers support (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

bsmith updated this revision to Diff 363093. bsmith marked an inline comment as done. bsmith added a comment. - Update comment to reflect changes - Add new test for lax casting via memory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106860/new/ ht

[clang] e6620a3 - Fix test that was never run.

Author: Paul Robinson Date: 2021-07-30T07:59:29-07:00 New Revision: e6620a351ecb87a75eca116399c5b359e3c63cc8 URL: https://github.com/llvm/llvm-project/commit/e6620a351ecb87a75eca116399c5b359e3c63cc8 DIFF: https://github.com/llvm/llvm-project/commit/e6620a351ecb87a75eca116399c5b359e3c63cc8.diff

[PATCH] D107155: [clang][deps] Substitute clang-scan-deps executable in lit tests

lxfind accepted this revision. lxfind added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107155/new/ https://reviews.llvm.org/D107155 _

[clang] acc5850 - [OpenCL] Add support of __opencl_c_pipes feature macro.

Author: Anton Zabaznov Date: 2021-07-30T18:10:25+03:00 New Revision: acc58504952f0e2ca48a44d868f684e3b135dd34 URL: https://github.com/llvm/llvm-project/commit/acc58504952f0e2ca48a44d868f684e3b135dd34 DIFF: https://github.com/llvm/llvm-project/commit/acc58504952f0e2ca48a44d868f684e3b135dd34.diff

[PATCH] D107154: [OpenCL] Add support of __opencl_c_pipes feature macro.

This revision was automatically updated to reflect the committed changes. Closed by commit rGacc58504952f: [OpenCL] Add support of __opencl_c_pipes feature macro. (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107154/new/ htt

[PATCH] D107078: [analyzer] Catch leaking stack addresses via stack variables

steakhal updated this revision to Diff 363101. steakhal added a comment. Removed the deceiving `-DNO_ELIDE_FLAG` define from the c++17 run line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107078/new/ https://reviews.llvm.org/D107078 Files: cl

[PATCH] D107078: [analyzer] Catch leaking stack addresses via stack variables

steakhal marked an inline comment as done. steakhal added inline comments. Comment at: clang/test/Analysis/copy-elision.cpp:9-10 +// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -std=c++17 \ +// RUN:-analyzer-config elide-constructors=false -DNO_ELIDE_

[PATCH] D107155: [clang][deps] Substitute clang-scan-deps executable in lit tests

dblaikie added a comment. Hmm, don't we have some other substitution feature that avoids the need to add the %? (like, I think LLVM's tests don't usually use the % for many tool names - but they still make for good copy/pastable command lines, if I'm not mistaken?) Repository: rG LLVM Githu

[PATCH] D107145: clangd: Add new semantic token modifier "virtual"

ckandeler updated this revision to Diff 363106. ckandeler added a comment. Fixed lit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107145/new/ https://reviews.llvm.org/D107145 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp cla

[clang] c0fa174 - Add triples to try to fix a test

Author: Paul Robinson Date: 2021-07-30T08:35:42-07:00 New Revision: c0fa174d63ad68f290745aaa6600cede1ad0a25d URL: https://github.com/llvm/llvm-project/commit/c0fa174d63ad68f290745aaa6600cede1ad0a25d DIFF: https://github.com/llvm/llvm-project/commit/c0fa174d63ad68f290745aaa6600cede1ad0a25d.diff

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added a reviewer: rnk. v.g.vassilev added a subscriber: rnk. v.g.vassilev added inline comments. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:134 + // Instead we expect std::terminate to be called upon thrown exception. + EXPECT_DEATH(Main(), "termin

[PATCH] D105907: [CallGraphSection] Add call graph section options and documentation

dblaikie added a comment. Looks like the RFC threads didn't have any discussion - I think that'll be necessary before moving forward with/committing any work here, for what it's worth. Perhaps some Apple folks would have some interest since they use ARM and sanitizers a lot & probably care abou

[clang] aa35c49 - [AIX] Pass the -b option to linker on AIX (with fix to build break)

Author: Anjan Kumar Date: 2021-07-30T15:50:52Z New Revision: aa35c496cf53627147f45adb84fc70ba4f81a38f URL: https://github.com/llvm/llvm-project/commit/aa35c496cf53627147f45adb84fc70ba4f81a38f DIFF: https://github.com/llvm/llvm-project/commit/aa35c496cf53627147f45adb84fc70ba4f81a38f.diff LOG: [

[PATCH] D107105: [AIX] Pass the -b option to linker on AIX (with fix to build break)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa35c496cf53: [AIX] Pass the -b option to linker on AIX (with fix to build break) (authored by anjankgk). Repository: rG LLVM Github Monorepo CHA

[PATCH] D106410: [PowerPC] Emit error for Altivec vector initializations when -faltivec-src-compat=gcc is specified

amyk marked an inline comment as done. amyk added a comment. Addressed Nemanja's comment on the commit. https://reviews.llvm.org/rG5ea6117a9e9eae49ad1295fa422266ef3832e419 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106410/new/ https://reviews.l

[PATCH] D106739: [analyzer] Add option to SATest.py for extra checkers

RedDocMD added a comment. In D106739#2907647 , @ASDenysPetrov wrote: > @RedDocMD Could you, please, explain the motivation and add at least one test > to verify it works. Motivation: I need to run these projects with the SmartPtrChecker enabled (which

[clang] 9ca905b - XFAIL a test on ppc64

Author: Paul Robinson Date: 2021-07-30T09:05:14-07:00 New Revision: 9ca905b52d53c46aceb4d28e44dfbf4a815d0c68 URL: https://github.com/llvm/llvm-project/commit/9ca905b52d53c46aceb4d28e44dfbf4a815d0c68 DIFF: https://github.com/llvm/llvm-project/commit/9ca905b52d53c46aceb4d28e44dfbf4a815d0c68.diff

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16114 +Intrinsic::ID IID; +llvm::Type *ArgTy = llvm::Type::getDoubleTy(getLLVMContext()); +switch (BuiltinID) { arsenm wrote: > Initializing this here is strange, sink down

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

gandhi21299 added a comment. Passed PSDB Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

arsenm added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:201 +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_f32, "ff*1fi", "t", "gfx90a-insts") +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_2f16, "hh*1hi", "t", "gfx90a-insts") +TARGET_BU

  1   2   >