JonChesterfield accepted this revision. JonChesterfield added inline comments.
================ Comment at: clang/lib/Headers/openmp_wrappers/cmath:113 +__DEVICE__ float lgamma(float __x) { return ::lgammaf(__x); } +//__DEVICE__ long long int llrint(float __x) { return ::llrintf(__x); } +//__DEVICE__ long long int llround(float __x) { return ::llroundf(__x); } ---------------- let's not add in commented out code ================ Comment at: clang/test/Headers/Inputs/include/cstdlib:24 +// amdgcn already provides definition of fabs float fabs(float __x) { return __builtin_fabs(__x); } ---------------- drop comment? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/ https://reviews.llvm.org/D104904 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits