Anastasia added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6150
options::OPT_fno_threadsafe_statics,
- !IsWindowsMSVC || IsMSVC2015Compatible))
+ !types::isOpenCL(InputType) &&
+ (!IsWindowsMSVC || IsMSVC2015Compatible)))
----------------
I think this will work fine apart from if someone creates `.cpp` file but
passes `-cl-std=clc++`. But it is not the conventional flow so I think we
should not worry about it for now.
================
Comment at: clang/test/Driver/threadsafe-statics.clcpp:2
+// RUN: %clang -### -c -DNO_THREADSAFE_STATICS %s 2>&1 | FileCheck
--check-prefix=CHECK-NO-THREADSAFE-STATICS %s
+// RUN: %clang -### -fno-threadsafe-statics -DNO_THREADSAFE_STATICS -c %s 2>&1
| FileCheck --check-prefix=CHECK-NO-THREADSAFE-STATICS %s
+
----------------
Worth adding one more RUN line with `-fthreadsafe-statics` passed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107163/new/
https://reviews.llvm.org/D107163
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
