azabaznov added a comment.

> We might need to fix the target triple in 
> clang/test/SemaOpenCL/invalid-pipes-cl2.0.cl to avoid surprises with testing 
> but it has better coverage if we don't though...

Yeah, I am not sure now though. It's awful because testing is not deterministic 
as we have different default targets here, but on the other hand it helps to 
catch errors like this. Maybe it makes sense to change the existing target to 
spir and also add a random target here, such as nvptx for example?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107154/new/

https://reviews.llvm.org/D107154

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to