[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

vsavchenko added a comment. In D95877#2547303 , @RedDocMD wrote: > @vsavchenko are there some more changes you want done? I think we had a bit of misunderstanding about the test. It still should pass (we can't have broken tests, it will disrupt CI bots)

[PATCH] D95369: [clang][cli] Generate and round-trip analyzer options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e07383433d0: [clang][cli] Generate and round-trip analyzer options (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 0e07383 - [clang][cli] Generate and round-trip analyzer options

Author: Jan Svoboda Date: 2021-02-08T09:26:01+01:00 New Revision: 0e07383433d0edc1f53410ce42fae437e1a8f967 URL: https://github.com/llvm/llvm-project/commit/0e07383433d0edc1f53410ce42fae437e1a8f967 DIFF: https://github.com/llvm/llvm-project/commit/0e07383433d0edc1f53410ce42fae437e1a8f967.diff L

[PATCH] D96246: Make sure a module file with errors produced via '-fallow-pcm-with-compiler-errors' can be loaded when using implicit modules

akyrtzi created this revision. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A module with errors would be marked as out-of-date, then the `compilerModule` action would produce it, but due to the error it would be treated as fail

[clang] 0c42d87 - [clang][cli] Generate and round-trip preprocessor options

Author: Jan Svoboda Date: 2021-02-08T09:34:55+01:00 New Revision: 0c42d87ea8e01f369d9cced7427a5ee0cca7574b URL: https://github.com/llvm/llvm-project/commit/0c42d87ea8e01f369d9cced7427a5ee0cca7574b DIFF: https://github.com/llvm/llvm-project/commit/0c42d87ea8e01f369d9cced7427a5ee0cca7574b.diff L

[PATCH] D95366: [clang][cli] Generate and round-trip preprocessor options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c42d87ea8e0: [clang][cli] Generate and round-trip preprocessor options (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES S

[clang] c1b482e - [clang][index] Mark file as C++ in parse-all-comments test

Author: Jan Svoboda Date: 2021-02-08T09:42:44+01:00 New Revision: c1b482e726a943862ec5277a44c1994acfb7f97f URL: https://github.com/llvm/llvm-project/commit/c1b482e726a943862ec5277a44c1994acfb7f97f DIFF: https://github.com/llvm/llvm-project/commit/c1b482e726a943862ec5277a44c1994acfb7f97f.diff L

[PATCH] D95879: [clang][index] Mark file as C++ in parse-all-comments test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc1b482e726a9: [clang][index] Mark file as C++ in parse-all-comments test (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D96247: [clangd] Fix false positive in local rename collision detetction

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clan

[PATCH] D96247: [clangd] Fix false positive in local rename collision detetction

kbobyrev updated this revision to Diff 322045. kbobyrev added a comment. Fix comment formatting in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96247/new/ https://reviews.llvm.org/D96247 Files: clang-tools-extra/clangd/refactor/Rename

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD added a comment. In D95877#2547949 , @vsavchenko wrote: > I think we had a bit of misunderstanding about the test. It still should > pass (we can't have broken tests, it will disrupt CI bots). Try to put the > test case, so it is THERE and you

[clang] bff6d9b - [clang][cli] Report result of ParseLangArgs

Author: Jan Svoboda Date: 2021-02-08T09:56:33+01:00 New Revision: bff6d9bb0f6d382d1d1826e997a6104bbe5ade73 URL: https://github.com/llvm/llvm-project/commit/bff6d9bb0f6d382d1d1826e997a6104bbe5ade73 DIFF: https://github.com/llvm/llvm-project/commit/bff6d9bb0f6d382d1d1826e997a6104bbe5ade73.diff L

[PATCH] D95792: [clang][cli] Report result of ParseLangArgs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbff6d9bb0f6d: [clang][cli] Report result of ParseLangArgs (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

vsavchenko added a comment. In D95877#2548021 , @RedDocMD wrote: > In D95877#2547949 , @vsavchenko > wrote: > >> I think we had a bit of misunderstanding about the test. It still should >> pass (we can't have bro

[PATCH] D96114: [ASTMatchers] Fix parent-child traversal between functions and parms

klimek added a comment. Can you explain the change and the before/after a bit more? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96114/new/ https://reviews.llvm.org/D96114 ___ cfe-commits mailin

[clang] 6362398 - [clang][cli] NFC: Mirror CreateFromArgs order in generateCC1CommandLine

Author: Jan Svoboda Date: 2021-02-08T10:12:51+01:00 New Revision: 63623982e1adb4b7e85f21d00d04dd2f555b79b6 URL: https://github.com/llvm/llvm-project/commit/63623982e1adb4b7e85f21d00d04dd2f555b79b6 DIFF: https://github.com/llvm/llvm-project/commit/63623982e1adb4b7e85f21d00d04dd2f555b79b6.diff L

[PATCH] D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

pdhaliwal created this revision. pdhaliwal added reviewers: jdoerfert, JonChesterfield, ronlieb, saiislam, ABataev. Herald added subscribers: dang, kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. Herald added a reviewer: jansvoboda11. pdhaliwal requested review of t

[clang] 6039f82 - Revert "[clang][cli] Report result of ParseLangArgs"

Author: Jan Svoboda Date: 2021-02-08T10:18:15+01:00 New Revision: 6039f821456fffa24fa36132f2022880fa9128df URL: https://github.com/llvm/llvm-project/commit/6039f821456fffa24fa36132f2022880fa9128df DIFF: https://github.com/llvm/llvm-project/commit/6039f821456fffa24fa36132f2022880fa9128df.diff L

[PATCH] D96151: [OpenCL] Fix pipe type printing in arg info metadata

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. Nice refactoring & fix! LGTM. I suppose Stuart's comment about moving `typeNameRef` can be addressed when pushing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96151/new/ ht

[PATCH] D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

pdhaliwal updated this revision to Diff 322052. pdhaliwal added a comment. Accidently missed some changes, - Fix openmp-offload.c test failure - Fix amdgpu-openmp-toolchain.c test failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96248/new/ ht

[PATCH] D95435: [clang][aarch64][WOA64][docs] Release note for longjmp crash with /guard:cf

peterwaller-arm abandoned this revision. peterwaller-arm added a comment. Release note upstream on release/12.x branch in rGbc2dad1671598a87423c61c355d03db49ce76907 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D96245: [clangd] Propagate CodeActions in addition to Fixes for diagnostics

njames93 added a comment. Emitting fixes for a diagnostic in another file seems dangerous, what's the intended use case for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96245/new/ https://reviews.llvm.org/D96245 ___

[PATCH] D96252: [RFC] Feature modularization for clangd

sammccall created this revision. Herald added subscribers: usaxena95, kadircet, arphaman, mgorny. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This is related to the ideas in D96244

[PATCH] D96245: [clangd] Propagate CodeActions in addition to Fixes for diagnostics

kadircet added a comment. > Emitting fixes for a diagnostic in another file seems dangerous, what's the > intended use case for this? one particular example is fixing layering violations in more strict build systems like bazel/blaze. for example if you `#include "a.h"` in a file, but build tar

[PATCH] D96244: [clangd][RFC] Introudce Plugins

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Plugin.h:26 + virtual llvm::Optional + actOnDiagnostic(DiagnosticsEngine::Level L, const clang::Diagnostic &Diag) { +return llvm::None; i think it would be better to have these as separate

[clang] a016374 - [OpenCL] Do not enforce ASTContext for OCL2Qual

Author: Sven van Haastregt Date: 2021-02-08T10:56:39Z New Revision: a016374d079b0d8f37af052ced13f9850f1049fa URL: https://github.com/llvm/llvm-project/commit/a016374d079b0d8f37af052ced13f9850f1049fa DIFF: https://github.com/llvm/llvm-project/commit/a016374d079b0d8f37af052ced13f9850f1049fa.diff

[PATCH] D96050: [OpenCL] Do not enforce ASTContext for OCL2Qual

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa016374d079b: [OpenCL] Do not enforce ASTContext for OCL2Qual (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

vabridgers added a comment. Thanks @thakis, per @rsmith 's suggestion in the review, I'll revert this. Apologies for the inconvenience. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71714/new/ https://reviews.llvm.org/D71714 _

[PATCH] D96032: [flang][driver] Add support for -fopenmp and -fopenacc

FarisRehman updated this revision to Diff 322071. FarisRehman added a comment. Rebase off main Rebase off main as patch D95448 , which this patch depends on, has been merged into main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag added a comment. @fghanim @jdoerfert please review the code if/when possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91054/new/ https://reviews.llvm.org/D91054 ___ cfe-commits mailing li

[clang] e22677b - Reapply "[clang][cli] Report result of ParseLangArgs"

Author: Jan Svoboda Date: 2021-02-08T13:14:43+01:00 New Revision: e22677bbdbdc725463feaa1aa50f179964ce442b URL: https://github.com/llvm/llvm-project/commit/e22677bbdbdc725463feaa1aa50f179964ce442b DIFF: https://github.com/llvm/llvm-project/commit/e22677bbdbdc725463feaa1aa50f179964ce442b.diff L

[PATCH] D95935: [clang][CodeComplete] Fix crash on ParenListExprs

kadircet updated this revision to Diff 322077. kadircet marked an inline comment as done. kadircet added a comment. - Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95935/new/ https://reviews.llvm.org/D95935 Files: clang/lib/Sema/

[clang] f743184 - [clang][CodeComplete] Fix crash on ParenListExprs

Author: Kadir Cetinkaya Date: 2021-02-08T13:16:49+01:00 New Revision: f74318491134356a19ba2d9673f89c8b74ff3692 URL: https://github.com/llvm/llvm-project/commit/f74318491134356a19ba2d9673f89c8b74ff3692 DIFF: https://github.com/llvm/llvm-project/commit/f74318491134356a19ba2d9673f89c8b74ff3692.dif

[PATCH] D95935: [clang][CodeComplete] Fix crash on ParenListExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf74318491134: [clang][CodeComplete] Fix crash on ParenListExprs (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

tbaeder updated this revision to Diff 322082. tbaeder added a comment. Switched to `llvm::Optional` and added some tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95915/new/ https://reviews.llvm.org/D95915 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain

[clang] 9083d0a - Revert "[Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item"

Author: einvbri Date: 2021-02-08T06:38:31-06:00 New Revision: 9083d0a40d980928f2f45236a4616528a7ab19ce URL: https://github.com/llvm/llvm-project/commit/9083d0a40d980928f2f45236a4616528a7ab19ce DIFF: https://github.com/llvm/llvm-project/commit/9083d0a40d980928f2f45236a4616528a7ab19ce.diff LOG:

[PATCH] D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

JonChesterfield added a comment. I like this. Using the same logic, in the same function call, to find this library on either gpu is the right thing to do. Looks like a non functional change on nvptx, though phab doesn't make that obvious. Comment at: clang/include/clang/Driv

[PATCH] D96161: [OpenCL] Fix printing of types with signed prefix in arg info metadata

Anastasia updated this revision to Diff 322087. Anastasia added a comment. Use char instead of int in the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96161/new/ https://reviews.llvm.org/D96161 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/CodeGenOpenCL/kernel-arg-in

[PATCH] D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

pdhaliwal updated this revision to Diff 322090. pdhaliwal added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96248/new/ https://reviews.llvm.org/D96248 Files: clang/include/clang/Driver/Options.td clang/l

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD updated this revision to Diff 322094. RedDocMD added a comment. Moved failing test of reinterpret_cast to its own file, marked to failx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95877/new/ https://reviews.llvm.org/D95877 Files: clan

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD added a comment. In D95877#2548027 , @vsavchenko wrote: > Yes, it'd be better to extract this case into a separate file and mark it as > XFAIL Done that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D96261: [Syntax] Remove a strict valid source location assertion for TypeLoc.

hokein created this revision. hokein added a reviewer: sammccall. hokein requested review of this revision. Herald added a project: clang. The EndLoc of a type loc can be invalid for broken code. Also extend the existing test to support error code with `error-ok` annotation. Repository: rG LL

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

mibintc added a comment. In D96203#2546856 , @aaron.ballman wrote: > Thank you for working on this! > >> This changes the option names that include substring blacklist to blocklist. > > I think this change works in some places, but in other places we say

[PATCH] D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

JonChesterfield added a comment. LGTM. Let's wait for someone using nvptx to sanity check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96248/new/ https://reviews.llvm.org/D96248 ___ cfe-commits mailing

[PATCH] D96175: [clang] Add support for attribute 'swift_async_error'

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5867 + << AsyncAttr << isa(D); + return; +} You can elide this `return`. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5977 +checkSwiftAsyncErr

[PATCH] D96262: [clang][index] report references from unreslovedLookupExpr.

hokein created this revision. hokein added a reviewer: usaxena95. Herald added subscribers: kadircet, arphaman. hokein requested review of this revision. Herald added a subscriber: ilya-biryukov. Herald added a project: clang. Fix https://github.com/clangd/clangd/issues/675 Repository: rG LLVM

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. Hi, community. I kindly ask you to review this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-com

[PATCH] D96215: [clang-tidy] Recognize captures as a form of aliasing.

aaron.ballman added a comment. Notionally, I think it makes sense to treat byref captures as a form of aliasing. Should structured bindings be treated similarly as well (not necessarily as part of this patch)? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

aaron.ballman added a comment. In D96203#2548471 , @mibintc wrote: > In D96203#2546856 , @aaron.ballman > wrote: > >> Thank you for working on this! >> >>> This changes the option names that include substring black

[PATCH] D96247: [clangd] Fix false positive in local rename collision detetction

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks for the quick fix. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:427 +// something in the definition's body is a valid transformation. +if (!Enclosi

[PATCH] D89651: [clang-tidy] Add bugprone-suspicious-memory-comparison check

steakhal added a comment. Herald added a subscriber: nullptr.cpp. I really love this. I'm gonna have a look at the blocking patch. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-suspicious-memory-comparison-32bits.cpp:2 +// RUN: %check_clang_tidy %s bugprone-s

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

echristo added a reviewer: vitalybuka. echristo added a comment. In D96203#2548495 , @aaron.ballman wrote: > In D96203#2548471 , @mibintc wrote: > >> In D96203#2546856 , @aa

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. One question that came up in off-line discussions with @mibintc is whether the evaluation method should have an impact on constant folding or not. My intuition is that it should impact constant folding because it would be pre

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:234 +FEM_Extended, +/// Use the default float eval method specified by Target +FEM_TargetDefault aaron.ballman wrote: > FYI: it may be somewhat confusing that we have a

[PATCH] D96036: [clang][codegen] Remember string used to create llvm::Regex for optimization remarks

jansvoboda11 updated this revision to Diff 322103. jansvoboda11 added a comment. Apply suggested change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96036/new/ https://reviews.llvm.org/D96036 Files: clang/include/clang/Basic/CodeGenOptions.h

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:177 + const std::size_t StartIndex) { + const std::size_t NumParams = FD->getNumParams(); + assert(StartIndex < NumPa

[PATCH] D96265: [PowerPC] Change target data layout for 16-byte stack alignment

saghir created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai, emaste. saghir requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. This changes the target data layout to make stack align

[PATCH] D96036: [clang][codegen] Remember string used to create llvm::Regex for optimization remarks

jansvoboda11 added a comment. I originally wanted to improve the API (make the null checks unnecessary), but keeping the API and minimizing the patch with your changes is nice too. I'm going with your suggestion, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D95793: [clang][cli] Generate and round-trip language options

jansvoboda11 updated this revision to Diff 322106. jansvoboda11 added a comment. Add comment, remove unnecessary diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95793/new/ https://reviews.llvm.org/D95793 Files: clang/include/clang/Basic/Sanit

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-signal-handler.rst:29-30 + `_ + for more information). This is not an extension of the mi

[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

poelmanc updated this revision to Diff 322108. poelmanc added a comment. Comment change, "beginning" to "start" for consistency, being sure to set Repository on "diff" page (not just on edit page) to see if https://github.com/google/llvm-premerge-checks/issues/263 was the problem. Repository:

[PATCH] D96268: [-Wcompletion-handler] Support checks with builtins

vsavchenko created this revision. vsavchenko added a reviewer: NoQ. Herald added a subscriber: Charusso. vsavchenko requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It is very common to check callbacks and completion handlers for null. This

[PATCH] D96056: [clang][cli] Generate and round-trip CodeGen options

jansvoboda11 updated this revision to Diff 322112. jansvoboda11 added a comment. Document functions in XRayInstr.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96056/new/ https://reviews.llvm.org/D96056 Files: clang/include/clang/Basic/XRayInst

[PATCH] D89649: Fix __has_unique_object_representations with no_unique_address

steakhal added a comment. It looks great. Comment at: clang/lib/AST/ASTContext.cpp:2582-2584 +int64_t BitfieldSize = Field->getBitWidthValue(Context); +if (BitfieldSize > FieldSizeInBits) + return llvm::None; Why do you return `None` here? ==

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:177 + const std::size_t StartIndex) { + const std::size_t NumParams = FD->getNumParams(); + assert(StartIndex < NumParam

[PATCH] D96149: [clang][cli] Store InputKind in FrontendOptions

jansvoboda11 updated this revision to Diff 322113. jansvoboda11 added a comment. Fix typo in comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96149/new/ https://reviews.llvm.org/D96149 Files: clang/include/clang/Frontend/FrontendOptions.h

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

jdoerfert added a comment. In D91054#2548266 , @AMDChirag wrote: > @fghanim @jdoerfert please review the code if/when possible. Let's resolve the issue described in the TODO before we go ahead with this. There is little point reviewing something that can

[PATCH] D96151: [OpenCL] Fix pipe type printing in arg info metadata

This revision was automatically updated to reflect the committed changes. Closed by commit rGecc8ac3f081b: [OpenCL] Fix pipe type printing in arg info metadata (authored by Anastasia). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D96151?vs=321799&id=322114#to

[PATCH] D96269: [clang][cli] Look up program action argument in a table

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch extracts the mapping between command line option and frontend::ActionKind into

[PATCH] D96161: [OpenCL] Fix printing of types with signed prefix in arg info metadata

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1500 StringRef typeNameRef = typeName; // Turn "unsigned type" to "utype" if (Ty.isCanonical()) { stuart wrote:

[PATCH] D95714: [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator comparisons

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. Herald added a subscriber: nullptr.cpp. LGTM, Same as last time for the commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95714/new/ https://reviews.llvm.org/D95714 _

[PATCH] D96056: [clang][cli] Generate and round-trip CodeGen options

jansvoboda11 updated this revision to Diff 322118. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96056/new/ https://reviews.llvm.org/D96056 Files: clang/include/clang/Basic/XRayInstr.h clang/include/clang/D

[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b1e2fc89327: [FE] Manipulate the first byte of guard variable type in both load and store… (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] 6b1e2fc - [FE] Manipulate the first byte of guard variable type in both load and store operation

Author: Xiangling Liao Date: 2021-02-08T11:14:34-05:00 New Revision: 6b1e2fc89327a64c9300d543e00f12435c32dfcf URL: https://github.com/llvm/llvm-project/commit/6b1e2fc89327a64c9300d543e00f12435c32dfcf DIFF: https://github.com/llvm/llvm-project/commit/6b1e2fc89327a64c9300d543e00f12435c32dfcf.diff

[PATCH] D96155: [clang][cli] Generate and round-trip Frontend options

jansvoboda11 updated this revision to Diff 322120. jansvoboda11 added a comment. Document getProgramActionOpt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96155/new/ https://reviews.llvm.org/D96155 Files: clang/include/clang/Driver/Options.td

[PATCH] D96155: [clang][cli] Generate and round-trip Frontend options

jansvoboda11 updated this revision to Diff 322121. jansvoboda11 added a comment. Fix whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96155/new/ https://reviews.llvm.org/D96155 Files: clang/include/clang/Driver/Options.td clang/include

[PATCH] D96231: [X86] Always assign reassoc flag for intrinsics *reduce_add/mul_ps/pd.

spatel added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13829 CGM.getIntrinsic(Intrinsic::vector_reduce_fadd, Ops[1]->getType()); +Builder.getFastMathFlags().setAllowReassoc(true); return Builder.CreateCall(F, {Ops[0], Ops[1]}); ---

[PATCH] D95714: [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator comparisons

poelmanc added a comment. In D95714#2548735 , @njames93 wrote: > LGTM, Same as last time for the commit? That would be great, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95714/new/ https://reviews.llvm.org/D95714

[PATCH] D96155: [clang][cli] Generate and round-trip Frontend options

jansvoboda11 added inline comments. Comment at: clang/include/clang/Serialization/ModuleFileExtension.h:75 + ModuleFileExtensionKind getKind() const { return Kind; } + I'm not sure what the best approach is here. `ModuleFileExtension` is an abstract class. Wh

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

svenvh updated this revision to Diff 322123. svenvh added a comment. Do not assume cast to Enum/TypedefDecl is always successful. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96051/new/ https://reviews.llvm.org/D96051 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/l

[PATCH] D96156: [clang][cli] Generate and round-trip PreprocessorOutput options

jansvoboda11 updated this revision to Diff 322124. jansvoboda11 added a comment. Switch from member functions to static ones Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96156/new/ https://reviews.llvm.org/D96156 Files: clang/include/clang/Driv

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3363 + +When ``pragma float_control(source, off)`` or +``pragma float_control(double, off)`` or I'd like to add Intel ICL compatible syntax, but 'off' doesn't make too much sense to me.

[PATCH] D96270: [release][docs] Update contributions to LLVM 12 for scalable vectors.

david-arm created this revision. david-arm added reviewers: sdesmalen, willlovett, c-rhodes. david-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96270 Files: clang/do

[PATCH] D96231: [X86] Always assign reassoc flag for intrinsics *reduce_add/mul_ps/pd.

spatel added inline comments. Comment at: clang/lib/Headers/avx512fintrin.h:9352 static __inline__ double __DEFAULT_FN_ATTRS512 _mm512_reduce_add_pd(__m512d __W) { return __builtin_ia32_reduce_fadd_pd512(0.0, __W); } Ah - this is where the +0.0 is specified

[PATCH] D96158: [clang][cli] Generate and round-trip Target options

jansvoboda11 updated this revision to Diff 322128. jansvoboda11 added a comment. Switch to static functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96158/new/ https://reviews.llvm.org/D96158 Files: clang/include/clang/Driver/Options.td c

[PATCH] D96273: [clang][cli] Generate and round-trip DependencyOutput options

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements generation of remaining dependency

[PATCH] D95714: [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator comparisons

njames93 added a comment. I'm unable to cleanly apply this patch, looks like something was a bit off when you created the diff. ➜ llvm-project git:(main) ✗ arc patch D95714 INFO Base commit is not in local repository; trying to fetch. Created and checked out b

[PATCH] D86376: [HIP] Simplify kernel launching

yaxunl added a comment. In D86376#2239618 , @tra wrote: > In D86376#2239391 , @yaxunl wrote: > >> For example, in HIP program, there is a kernel `void foo(int*)`. If a C++ >> program wants to launch it, the desirab

[PATCH] D96274: [clang][cli] Generate and round-trip Diagnostic options

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements generation of remaining diagnostic

[PATCH] D96270: [release][docs] Update contributions to LLVM 12 for scalable vectors.

sdesmalen added inline comments. Comment at: clang/docs/ReleaseNotes.rst:153 + compiler should use fixed-width or scalable vectorization. Fixed-width is + assumed by default. Scalable vectorization is an experimental feature for + targets that support it, such as Arm targets

[PATCH] D96278: [clang][cli] Extract FileSystem and Migrator options parsing/generation

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch splits out the last two option groups (`Filesy

[PATCH] D96279: [OpenCL] Add cl_khr_subgroup_extended_types to TableGen BIFs

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added a subscriber: yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add the builtin functions brought by the cl_khr_subgroup_extended_types extension t

[PATCH] D96280: [WIP][clang][cli] Round-trip the whole CompilerInvocation

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Finally, this patch moves from round-tripping one `CompilerInvocation` at a time to round

[PATCH] D96281: Add options to flag individual core increments and to ignore macros to cognitive complexity check.

massberg created this revision. massberg added reviewers: lebedev.ri, alexfh. Herald added a subscriber: nullptr.cpp. massberg requested review of this revision. Herald added a project: clang. Often you are only interested in the overall cognitive complexity of a function and not every individual

[PATCH] D96175: [clang] Add support for attribute 'swift_async_error'

erik.pilkington updated this revision to Diff 322152. erik.pilkington marked 2 inline comments as done. erik.pilkington added a comment. Get rid of a useless `return`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96175/new/ https://reviews.llvm.org/D96175 Files: clang/include/clang/

[PATCH] D96175: [clang] Add support for attribute 'swift_async_error'

erik.pilkington added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5977 +checkSwiftAsyncErrorBlock(S, D, ErrorAttr, AsyncAttr); +} + aaron.ballman wrote: > Should there be a diagnostic to combine `swift_error` and `swift_async_error` > on the

[PATCH] D89649: Fix __has_unique_object_representations with no_unique_address

gbencze added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2582-2584 +int64_t BitfieldSize = Field->getBitWidthValue(Context); +if (BitfieldSize > FieldSizeInBits) + return llvm::None; steakhal wrote: > Why do you return `None` here? The

[PATCH] D96175: [clang] Add support for attribute 'swift_async_error'

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM modulo some testing requests. Thanks! Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5977 +checkSwiftAsyncErrorBlock(S, D, ErrorAttr, AsyncAttr); +} + ---

[PATCH] D96032: [flang][driver] Add support for -fopenmp and -fopenacc

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. Thank you for this patch @FarisRehman , it's great to see more tests being ported to the new driver! Although this patches touches many files, it mostly just generalizes the `RUN` lin

[PATCH] D96246: Make sure a module file with errors produced via '-fallow-pcm-with-compiler-errors' can be loaded when using implicit modules

akyrtzi updated this revision to Diff 322166. akyrtzi added a comment. clang-format change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96246/new/ https://reviews.llvm.org/D96246 Files: clang/include/clang/Serialization/ASTReader.h clang/lib/

  1   2   >