mibintc added a comment. In D96203#2546856 <https://reviews.llvm.org/D96203#2546856>, @aaron.ballman wrote:
> Thank you for working on this! > >> This changes the option names that include substring blacklist to blocklist. > > I think this change works in some places, but in other places we say things > like "blocklisted" which feels a bit awkward. I don't super love the name > `blocklist`, but I don't super hate it either. All the alternative names I > come up with aren't really great either, like `UnsanitiziedEntities` or > `IgnoredObjects`. Maybe someone will have a better idea here than me, but I > do think the current name is an improvement over the old name. There is a pre-existing patch https://reviews.llvm.org/D82244 using block and allow, that's why I chose blocklist. Although going in cold I would prefer to use allow and deny, and block seems to me a little like cheating (too similar to black). However I can "disagree and commit" (cf. https://en.wikipedia.org/wiki/Disagree_and_commit) with this choice of wording. I can search out the awkward Blocklisted and come up with different phrasing in the prose, but I think names in the program should use blocklist so that they can be easily connected to the option name for future maintainers of llvm. I'll check this. >> In options.td there is a way to officially mark an option deprecated by >> adding it to a specific group, I didn't do that yet. When could we actually >> eliminate the old spelling? How about December 2021? > > I think we want to leave the deprecated options in for a full release cycle, > so I'd say that (assuming this lands in Clang 13) we could remove support > once we start work on Clang 14. > >> I thought it would be best to start with the external clang interface, but i >> also want to make more patches to eliminate whitelist and blacklist in the >> comments and in the object names, file names etc. > > Fantastic, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96203/new/ https://reviews.llvm.org/D96203 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
