aaron.ballman added inline comments.
================ Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5867 + << AsyncAttr << isa<ObjCMethodDecl>(D); + return; + } ---------------- You can elide this `return`. ================ Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5977 + checkSwiftAsyncErrorBlock(S, D, ErrorAttr, AsyncAttr); +} + ---------------- Should there be a diagnostic to combine `swift_error` and `swift_async_error` on the same function? Similarly, should there be a diagnostic when adding `swift_async_error` to a function that isn't (eventually) marked `swift_async`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96175/new/ https://reviews.llvm.org/D96175 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
