[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

poelmanc updated this revision to Diff 226847. poelmanc added a comment. Changed default to 1, updated help accordingly, and removed an extraneous set of braces around a one-line statement. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69145/new/ h

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

kadircet updated this revision to Diff 226849. kadircet added a comment. - Handle unnamed parameters explicitly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68937/new/ https://reviews.llvm.org/D68937 Files: clang-tools-extra/clangd/refactor/twe

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

merge_guards_bot added a comment. Build result: pass - 59704 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

Re: [llvm-dev] Zorg migration to GitHub/monorepo

Hi Galina, On Tue, 29 Oct 2019 at 04:42, Galina Kistanova wrote: > > Hello Nemanja, > > > a commit to a project that shouldn't trigger builds on a libcxx bot (i.e. > > the change was in llvm). > > With all due respect, this does not sound right. > I'm not sure how changes in a code a particular

[PATCH] D69506: [clangd] Add missing highlights for using decls.

hokein updated this revision to Diff 226851. hokein marked 2 inline comments as done. hokein added a comment. address remaining nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69506/new/ https://reviews.llvm.org/D69506 Files: clang-tools-ext

[clang-tools-extra] 94cd2f0 - [clangd] Add missing highlights for using decls.

Author: Haojian Wu Date: 2019-10-29T09:49:42+01:00 New Revision: 94cd2f03032475e26767cf11eb81fefb00fc4dc0 URL: https://github.com/llvm/llvm-project/commit/94cd2f03032475e26767cf11eb81fefb00fc4dc0 DIFF: https://github.com/llvm/llvm-project/commit/94cd2f03032475e26767cf11eb81fefb00fc4dc0.diff LO

[PATCH] D69506: [clangd] Add missing highlights for using decls.

This revision was automatically updated to reflect the committed changes. Closed by commit rG94cd2f030324: [clangd] Add missing highlights for using decls. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69506/new/ https://review

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

Hi All, Apologies for the delay in responding, I was away from keyboard (llvm dev conf). This is a real funny patch! It is a (simple) fix that uncovers quite a few things. Anyway, thanks Michael for your analysis! As I will need to make some changes this time (this wasn't the case last time), I

[PATCH] D69544: [clangd] NFC, reuse the source manager variable in the RawStringLiteral apply method

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69544/new/ https://reviews.llvm.org/D69544 _

[clang-tools-extra] f821ab8 - [clangd] NFC, use URI::resolve to simplify the code.

Author: Haojian Wu Date: 2019-10-29T10:53:16+01:00 New Revision: f821ab807debdc973066ea43ac23173ef08dc2f5 URL: https://github.com/llvm/llvm-project/commit/f821ab807debdc973066ea43ac23173ef08dc2f5 DIFF: https://github.com/llvm/llvm-project/commit/f821ab807debdc973066ea43ac23173ef08dc2f5.diff LO

[PATCH] D69517: [clangd] Add a hidden tweak to dump symbol under the curosr.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69517/new/ https://reviews.llvm.org/D69517 _

[PATCH] D69517: [clangd] Add a hidden tweak to dump symbol under the curosr.

ilya-biryukov added a comment. NIT: a typo in the title: s/curosr/cursor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69517/new/ https://reviews.llvm.org/D69517 ___ cfe-commits mailing list cfe-commit

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

ilya-biryukov added a comment. Just a few final NITs from my side. And would also be nice to get tests with macros. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:251 +} +NewName.append(SourceParam->getName()); +ParamToNewName[DestParam->getC

[PATCH] D69543: [WIP][clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:127 +TEST_F(ObjCLocalizeStringLiteralTest, Test) { + ExtraArgs.push_back("-x=objective-c"); + Context = Expression; make sure this is rebased on top of http://github.

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

SouraVX added a comment. Hi Adrian, Thanks for taking out time for reviewing this. I've again updated doc. Currently we're in process of getting commit access, discussion with Tom in progress So, could you please commit these changes. Thank you so much! CHANGES SINCE LAST ACTION https://rev

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

SouraVX updated this revision to Diff 226867. SouraVX added a comment. Updated doc. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69215/new/ https://reviews.llvm.org/D69215 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-deleted.cpp llvm/docs/SourceLevel

[PATCH] D69498: IR: Invert convergent attribute handling

nhaehnle added a comment. As you know, I am very much in favor of this change, and really anything that re-establishes the rule that code is treated maximally conservatively when there are no attributes or metadata. There is one slight concern here because what we arguably need in SIMT targets

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

kadircet updated this revision to Diff 226868. kadircet marked 3 inline comments as done. kadircet added a comment. - Handle macros in parameter names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68937/new/ https://reviews.llvm.org/D68937 Files:

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1517 +template +void foo(PARAM, TYPE b, TYPE c, TYPE d = BODY(x)){} + We fail to rename the parameter in that case, right? Should the action not be availab

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

balazske added a comment. Ping again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67706/new/ https://reviews.llvm.org/D67706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

malcolm.parsons added a comment. I like that this check warns about copy constructors that don't copy. The warning can be suppressed with a NOLINT comment if not copying is intentional. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69145/new/ https

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

merge_guards_bot added a comment. Build result: pass - 59704 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm marked an inline comment as done. peterwaller-arm added a comment. I'm still awaiting commit access, please can someone submit this on my behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63607/new/ https://reviews.llvm.org/D63607 _

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

Charusso added a reviewer: Charusso. Charusso requested changes to this revision. Charusso added a comment. This revision now requires changes to proceed. Could you please mark resolved issues as resolved? I would like to see what we miss, and what has been done. Comment at: c

[clang-tools-extra] 80b0cdd - [clangd] Add a hidden tweak to dump symbol under the cursor.

Author: Haojian Wu Date: 2019-10-29T13:06:34+01:00 New Revision: 80b0cdde0ffc4ca59e99fed3dcb18412ff97568c URL: https://github.com/llvm/llvm-project/commit/80b0cdde0ffc4ca59e99fed3dcb18412ff97568c DIFF: https://github.com/llvm/llvm-project/commit/80b0cdde0ffc4ca59e99fed3dcb18412ff97568c.diff LO

[PATCH] D69517: [clangd] Add a hidden tweak to dump symbol under the cursor.

This revision was automatically updated to reflect the committed changes. Closed by commit rG80b0cdde0ffc: [clangd] Add a hidden tweak to dump symbol under the cursor. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69517/new/ ht

[PATCH] D69548: Give clang-tidy readability-redundant-string-init a customizable list of string types to fix

Eugene.Zelenko added a comment. Please mention new option in Release Notes (in new options section, if there is no such yet, see previous release for order of sections). Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.h:13 #include "../ClangTidy

[PATCH] D69548: Give clang-tidy readability-redundant-string-init a customizable list of string types to fix

MyDeveloperDay added a comment. Thanks you so much for this patch, I obviously like it! So many of us who write our own string classes we tend to make them have similar interfaces to std::string anyway for obvious reasons (some of us actually add decent startWith,endsWith and contains functions

Re: [clang] bd87916 - [clang] Add no_builtin attribute

hi Vlad, I've spend a big part of my day digging into this and I'm less and less convinced that my patch broke the builds. IIUC the built bots are still failing although my patch has been reverted for quite some time now. Am I missing something? On Mon, Oct 28, 2019 at 11:24 PM Vlad Tsyrklevich

Re: [clang] bd87916 - [clang] Add no_builtin attribute

For instance here are the kind of errors I have by running a sanitized clang on master (with or without my patch it doesn't make a difference) cd /redacted/git/llvm-project/llvm/build-msan && > /redacted/git/llvm-project/llvm/build-msan/bin/llvm-tblgen > -gen-opt-parser-defs -I /redacted/git/llvm-

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao added a comment. PING for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

whisperity created this revision. whisperity added reviewers: aaron.ballman, alexfh, Eugene.Zelenko, JonasToth, NoQ, Szelethus, xazax.hun, baloghadamsoftware, Charusso. whisperity added a project: clang-tools-extra. Herald added subscribers: cfe-commits, ormris, kbarton, mgorny, nemanjai. Herald a

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

whisperity added a comment. Herald added a subscriber: wuzish. A few interesting "true positive" findings: - F10568770: AnalysisDeclContext.cpp_9aaed563ddd9ebd73fdd228c2883b8e7.plist.html (Such cases with many `bool`s are being discussed on enhancing type s

[PATCH] D69378: [AArch64][SVE] Implement masked store intrinsics

kmclaughlin updated this revision to Diff 226885. kmclaughlin added a comment. - Removed masked load tests from sve-masked-ldst-trunc.ll CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69378/new/ https://reviews.llvm.org/D69378 Files: llvm/lib/Target/AArch64/AArch64InstrInfo.td llvm/

[PATCH] D69378: [AArch64][SVE] Implement masked store intrinsics

sdesmalen added a comment. Thanks for the changes to the tests. Comment at: llvm/test/CodeGen/AArch64/sve-masked-ldst-trunc.ll:9 +; CHECK-LABEL: masked_trunc_store_nxv2i8: +; CHECK: st1b { [[IN:z[0-9]]].d }, [[PG:p[0-9]]], [x1] + %trunc = trunc %val to I thi

[clang] 99f5196 - [Hexagon] Handle remaining registers in getRegisterByName()

Author: Krzysztof Parzyszek Date: 2019-10-29T08:56:01-05:00 New Revision: 99f51960fdb5559d6720281bff9a63041452bf9a URL: https://github.com/llvm/llvm-project/commit/99f51960fdb5559d6720281bff9a63041452bf9a DIFF: https://github.com/llvm/llvm-project/commit/99f51960fdb5559d6720281bff9a63041452bf9a

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

thakis added a comment. Just doing nothing is fine with me. I'll note that this change required several changes in our Obj-C++ codebase, and we don't have all that much Obj-C++ code in Chromium. Most of the changes made the code better, but I'd imagine that folks with more Obj-C++ code might n

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AdjacentArgumentsOfSameTypeCheck.cpp:1 +//===--- AvoidAdjacentArgumentsOfSameTypeCheck.cpp - clang-tidy ===// +// Please adjust length to 80 cha

[PATCH] D67216: [cfi] Add flag to always generate .debug_frame

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67216/new/ https://reviews.llvm.org/D67216 ___ cfe-commits mailing list cfe-com

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

mitchell-stellar added a comment. Sounds like you know what you're doing. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69433/new/ https://reviews.llvm.org/D69433 ___ cfe-commits mailing list cfe-commits@lists.

[clang] c09c065 - [OPENMP]Fix PR43772: No warning in non-combined target regions.

Author: Alexey Bataev Date: 2019-10-29T10:31:24-04:00 New Revision: c09c0651a43b75044dc99e7c69acbcfaffd08aa2 URL: https://github.com/llvm/llvm-project/commit/c09c0651a43b75044dc99e7c69acbcfaffd08aa2 DIFF: https://github.com/llvm/llvm-project/commit/c09c0651a43b75044dc99e7c69acbcfaffd08aa2.diff

[clang] 98f3151 - [clang] Add no_builtin attribute

Author: Guillaume Chatelet Date: 2019-10-29T15:50:29+01:00 New Revision: 98f3151a7dded8838fafcb5f46e6c8358def96b8 URL: https://github.com/llvm/llvm-project/commit/98f3151a7dded8838fafcb5f46e6c8358def96b8 DIFF: https://github.com/llvm/llvm-project/commit/98f3151a7dded8838fafcb5f46e6c8358def96b8.

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

sammccall accepted this revision. sammccall added a comment. Apologies for this mess, I didn't know about dump_format_style. Thanks for cleaning this up! Generally the differences were intentional and I think the text in Format.h was mostly better :-( Happy to unify but a bunch of suggestions a

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

ilya-biryukov added a comment. The most important comment is in the tests. Is there a way to have the same effect with less changes? Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:47 const UsingDirectiveDecl *TargetDirective = nullptr; + cons

[PATCH] D69566: [ASTImporter] Add support for BuiltinTemplateDecl

teemperor created this revision. teemperor added reviewers: martong, a.sidorin. Herald added subscribers: cfe-commits, kristina, rnkovacs. Herald added a reviewer: shafik. Herald added a project: clang. That decl kind is currently not implemented. BuiltinTemplateDecl is for decls that are hardcod

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

whisperity added reviewers: Szelethus, baloghadamsoftware. whisperity edited subscribers, added: baloghadamsoftware, NoQ; removed: Szelethus. whisperity added a comment. @Szelethus and @baloghadamsoftware are colleagues to me whom are far more knowledgeable about check development and I want the

[PATCH] D69567: [AArch64][SVE] Implement additional integer arithmetic intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: huntergr, sdesmalen. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a project: LLVM. Add intrinsics for the following: - sxt[b|h|w] & uxt[b|h|w] - cls & clz - not & cnot Repository: rG

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 226907. mibintc added a comment. In response to comments from @rjmccall I inserted into the UsersManual the one-line summary of frounding-math that had been omitted and changed the semantics of frounding-math to not also set exception-behavior to strict Re

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1724290 , @rjmccall wrote: > Is the exception-strictness of `-frounding-math` actually considered to be > specified behavior, or is it just a consequence of the current > implementation? There are definitely some optim

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1517 +template +void foo(PARAM, TYPE b, TYPE c, TYPE d = BODY(x)){} + ilya-biryukov wrote: > We fail to rename the parameter in that case, right? > Should the a

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

kadircet updated this revision to Diff 226909. kadircet marked 2 inline comments as done. kadircet added a comment. - Use Lexer::makeFileCharRange Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68937/new/ https://reviews.llvm.org/D68937 Files: cl

[clang] 5607ff1 - Fix missing memcpy builtin on ppc64be

Author: Guillaume Chatelet Date: 2019-10-29T16:35:32+01:00 New Revision: 5607ff12fad9a54728a3cda0eacaffee02e4b434 URL: https://github.com/llvm/llvm-project/commit/5607ff12fad9a54728a3cda0eacaffee02e4b434 DIFF: https://github.com/llvm/llvm-project/commit/5607ff12fad9a54728a3cda0eacaffee02e4b434.

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

MyDeveloperDay marked 4 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2343 Use C++14-compatible syntax. +``Cpp11``: deprecated alias for ``Latest`` sammccall wrote: > sammccall wrote:

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

merge_guards_bot added a comment. Build result: pass - 59704 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69567: [AArch64][SVE] Implement additional integer arithmetic intrinsics

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69567/new/ https://reviews.llvm.org/D69567 _

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

tra added a reviewer: rnk. tra added a subscriber: rnk. tra added a comment. @rnk Reid, would you be the right person to look at the change on the Windows' side? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

rjmccall added a comment. Thanks. A few things about the functionality parts of the patch now. Comment at: clang/include/clang/Basic/CodeGenOptions.def:238 CODEGENOPT(UnsafeFPMath , 1, 0) ///< Allow unsafe floating point optzns. +CODEGENOPT(RoundingFPMath, 1, 0) ///<

[PATCH] D69566: [ASTImporter] Add support for BuiltinTemplateDecl

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Comment at: clang/lib/AST/ASTImporter.cpp:4479 + } + assert(ToD && "BuiltinTemplateDecl of unsupported kind!"); + Importer.MapImported(D, ToD); ---

[PATCH] D69498: IR: Invert convergent attribute handling

rjmccall added a comment. In D69498#1724625 , @kariddi wrote: > One thing to probably note is that its not only a "target specific" issue, > but a language specific issue as well (IMHO). OpenCL, CUDA, SYCL are all > languages (to name a few) that have a

[clang] 1c85a2e - isBuiltinFunc() uses StringRef instead of const char*

Author: Guillaume Chatelet Date: 2019-10-29T17:36:55+01:00 New Revision: 1c85a2e8dc7e76761d301f9a35374e0aafc757ec URL: https://github.com/llvm/llvm-project/commit/1c85a2e8dc7e76761d301f9a35374e0aafc757ec DIFF: https://github.com/llvm/llvm-project/commit/1c85a2e8dc7e76761d301f9a35374e0aafc757ec.

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

martong added inline comments. Herald added a subscriber: rnkovacs. Comment at: clang/lib/AST/ASTImporter.cpp:7004 + // FIXME: Should ManglingNumber get numbers associated with 'to' context? + auto* To = MaterializeTemporaryDecl::Create(Temporary, ExtendingDecl, +

[PATCH] D69569: isBuiltinFunc() uses StringRef instead of const char*

gchatelet created this revision. gchatelet added a reviewer: vlad.tsyrklevich. Herald added a project: clang. Herald added a subscriber: cfe-commits. gchatelet edited the summary of this revision. This prevents a bug when passing `nullptr`, `StringRef` ctor would call `strlen(nullptr)`. This shou

[PATCH] D69569: isBuiltinFunc() uses StringRef instead of const char*

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG1c85a2e8dc7e: isBuiltinFunc() uses StringRef instead of const char* (authored by gchatelet). Repository: rG LLVM Github

[PATCH] D69569: isBuiltinFunc() uses StringRef instead of const char*

vlad.tsyrklevich added a comment. Fix LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69569/new/ https://reviews.llvm.org/D69569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rG2a0fcae3d4d1: [lld] [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

MaskRay added inline comments. Comment at: lld/ELF/Driver.cpp:357 + + // default + return GnuStackKind::NoExec; mgorny wrote: > MaskRay wrote: > > MaskRay wrote: > > > This is obvious. The comment can be removed. > > Not done. `// default` can be deleted I thin

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lld/ELF/Driver.cpp:357 + + // default + return GnuStackKind::NoExec; MaskRay wrote: > mgorny wrote: > > MaskRay wrote: > > > MaskRay wrote: > > > > This is obvious. The comment c

[PATCH] D60220: [CUDA][Windows] Final fix for bug 38811 (Step 3 of 3)

dim added a comment. Hm, I would really say that `__isnan` and the other `__` prefixed functions are Linuxisms, or more accurately, glibc-isms. They also don't exist on e.g. macOS: $ cat check-isnan.cpp #include int check_isnan(double d) { return ::__isnan(d); } $ clang -

[PATCH] D68733: Use -fdebug-compilation-dir to form absolute paths in coverage mappings

vsk added a comment. In D68733#1723734 , @liaoyuke wrote: > In D68733#1702609 , @vsk wrote: > > > Thanks, lgtm! > > > > In PR43614 I mentioned adding an extra argument to llvm-cov to specify the > > base directory.

[PATCH] D60220: [CUDA][Windows] Final fix for bug 38811 (Step 3 of 3)

tra added a comment. In D60220#1725633 , @dim wrote: > Hm, I would really say that `__isnan` and the other `__` prefixed functions > are Linuxisms, or more accurately, glibc-isms. They also don't exist on e.g. > macOS: > > Why can't the regular `isnan`

[PATCH] D69498: IR: Invert convergent attribute handling

kariddi added a comment. In D69498#1725528 , @rjmccall wrote: > It absolutely makes sense for Clang as a GPU-programming frontend to set > attributes appropriately when targeting the GPU. I'm objecting to making > "convergence" and related "code layout

[clang] efed314 - Revert "[clang-format] Remove the dependency on frontend"

Author: Vlad Tsyrklevich Date: 2019-10-29T10:48:03-07:00 New Revision: efed314118c7c287a71b8a8d67953a98d8a718d5 URL: https://github.com/llvm/llvm-project/commit/efed314118c7c287a71b8a8d67953a98d8a718d5 DIFF: https://github.com/llvm/llvm-project/commit/efed314118c7c287a71b8a8d67953a98d8a718d5.di

Re: [clang] ec66603 - [clang-format] Remove the dependency on frontend

I've reverted this commit as it was causing UBSan failures on the ubsan bot. These failures looked like: llvm/lib/Support/SourceMgr.cpp:440:48: runtime error: pointer index expression with base 0x overflowed to 0xfffa Looking at a backtrace, this line was reached from the `

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: mitchell-stellar, klimek, owenpan, sammccall. MyDeveloperDay added projects: clang-format, clang-tools-extra. Herald added a project: clang. https://bugs.llvm.org/show_bug.cgi?id=36294 Addressing bug related to returning after

[PATCH] D60220: [CUDA][Windows] Final fix for bug 38811 (Step 3 of 3)

emankov added a comment. In D60220#1725633 , @dim wrote: > $ cat check-isnan.cpp > #include > > int check_isnan(double d) > { > return ::__isnan(d); > } > $ clang -c check-isnan.cpp > Why can't the regular `isnan` be used instead? Or

[PATCH] D69574: Remove lazy thread-initialisation

mmalcomson created this revision. mmalcomson added reviewers: eugenis, pcc, Sanitizers. mmalcomson added a project: Sanitizers. Herald added subscribers: llvm-commits, cfe-commits, jfb, hiraditya, srhines. Herald added projects: clang, LLVM. As I asked in the comments of https://reviews.llvm.org/D

[PATCH] D69574: Remove lazy thread-initialisation

eugenis added a comment. LGTM keeping the flag looks like the right thing to do. I'll leave this for @pcc to accept. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69574/new/ https://reviews.llvm.org/D69574 ___

[PATCH] D69478: [Sema] Allow warnStackExhausted to show more info

Mordante added a comment. @rsmith also doesn't like the approach `runWithSufficientStackSpace` in D69479 . So I'll try to use a different approach. If that succeeds I have no use case for this patch and will probably abandon it. Repository: rG LLVM Github Mon

[PATCH] D69479: [Sema] Warn about possible stack exhaution

Mordante added a comment. I'll look at a worklist first, before fixing the other issues. However it seems it's not as trivial as I hoped. The recursion occurs in the `SequenceChecker` which has a `WorkList` but that's not used for this part. I'll try to find a solution. CHANGES SINCE LAST ACT

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

sammccall added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1347 Contexts.back().CanBeExpression = false; -} else if (Current.isOneOf(tok::semi, tok::exclaim)) { +} else if (Current.isOneOf(tok::semi, tok::exclaim) && + !(Current.

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev added a comment. Does anybody have suggestions on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69435/new/ https://reviews.llvm.org/D69435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, mitchell-stellar, owenpan, sammccall. MyDeveloperDay added projects: clang-format, clang-tools-extra. Herald added a project: clang. see https://bugs.llvm.org/show_bug.cgi?id=35518 clang-format removes spaces around ded

[PATCH] D69498: IR: Invert convergent attribute handling

mehdi_amini added a comment. Maybe we can start by looking into the motivation for this patch: > There is a burden on frontends in environments that care about convergent > operations to add the attribute just in case it is needed. This has proven to > be somewhat problematic, and different fro

Re: [llvm-dev] Zorg migration to GitHub/monorepo

Thanks for explaining, Diana. And you are welcome. I’m glad this is not an issue with missing changes or something. Thanks Galina On Tue, Oct 29, 2019 at 1:48 AM Diana Picus wrote: > > Hi Galina, > > On Tue, 29 Oct 2019 at 04:42, Galina Kistanova wrote: > > > > Hello Nemanja, > > > > > a commi

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

Mordante added a comment. In D68912#1723722 , @aaron.ballman wrote: > In D68912#1723691 , @xbolva00 wrote: > > > >> Does this analysis require CFG support > > > > https://reviews.llvm.org/D69292 also requires CFG s

[PATCH] D69498: IR: Invert convergent attribute handling

jdoerfert added a comment. In D69498#1725819 , @mehdi_amini wrote: > Maybe we can start by looking into the motivation for this patch: > > > There is a burden on frontends in environments that care about convergent > > operations to add the attribute just

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:238 CODEGENOPT(UnsafeFPMath , 1, 0) ///< Allow unsafe floating point optzns. +CODEGENOPT(RoundingFPMath, 1, 0) ///< Rounding floating point optzns. CODEGENOPT(UnwindTables , 1,

[PATCH] D69498: IR: Invert convergent attribute handling

arsenm added a comment. In D69498#1725819 , @mehdi_amini wrote: > Maybe we can start by looking into the motivation for this patch: > > > There is a burden on frontends in environments that care about convergent > > operations to add the attribute just in

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

xbolva00 added a comment. > I compiled LLVM and Clang and it adds 145 unique warnings. I wouldn't mind to > fix those and the other subprojects, so I can test whether the tests have > false positives. > Am I correct to assume these patches all need to be reviewed? Can you upload the list with

[clang] 5259031 - Fix argument numbering confusion when diagnosing a non-viable operator().

Author: Richard Smith Date: 2019-10-29T13:08:39-07:00 New Revision: 52590319a225768404591e60803d0bfa84a8b5cd URL: https://github.com/llvm/llvm-project/commit/52590319a225768404591e60803d0bfa84a8b5cd DIFF: https://github.com/llvm/llvm-project/commit/52590319a225768404591e60803d0bfa84a8b5cd.diff

[PATCH] D69582: Let clang driver support parallel jobs

yaxunl created this revision. yaxunl added reviewers: tra, rsmith, rjmccall. Herald added subscribers: jfb, mgorny. It is observed that device code compilation takes most of the compilation time when clang compiles CUDA/HIP programs since device code usually contains complicated computation code.

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the release notes alias request. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69181/new/ https://reviews.llvm.org/

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

rsmith added a comment. Thanks, I like this a lot. There are a few more changes we'll need in addition to this before we can properly serialize `APValue`s referring to such temporaries: 1. Merging during deserialization. For example, if we have inline int &&r = 123; in two different modules

[PATCH] D69533: Thread safety analysis: Peel away NoOp implicit casts in initializers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69533/new/ https://reviews.llvm.org/D69533

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:67-70 +// With -std c++14 or earlier (!LangOps.CPlusPlus17), it was sufficient to +// return CtorExpr->getSourceRange(). However, starting with c++17, parsing +

[clang] f919be3 - [DWARF5] Added support for deleted C++ special member functions.

Author: Adrian Prantl Date: 2019-10-29T13:44:06-07:00 New Revision: f919be336583349d883ba0dfdb3b2479a190b67c URL: https://github.com/llvm/llvm-project/commit/f919be336583349d883ba0dfdb3b2479a190b67c DIFF: https://github.com/llvm/llvm-project/commit/f919be336583349d883ba0dfdb3b2479a190b67c.diff

[PATCH] D69548: Give clang-tidy readability-redundant-string-init a customizable list of string types to fix

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:21 +const char DefaultStringNames[] = "basic_string"; + I think the default should probably be `::std::basic_string` to avoid getting other

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

MyDeveloperDay updated this revision to Diff 226961. MyDeveloperDay added a comment. Trying to address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69573/new/ https://reviews.llvm.org/D69573 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTe

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

usaxena95 updated this revision to Diff 226962. usaxena95 marked 7 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69162/new/ https://reviews.llvm.org/D69162 Files: clang-tool

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:180 + if (ContainingNS) +findExplicitReferences(ContainingNS, SelectRefToQualify); + else ilya-biryukov wrote: > Do we also need to run in the re

  1   2   >