mgorny marked an inline comment as done. mgorny added inline comments.
================ Comment at: lld/ELF/Driver.cpp:357 + + // default + return GnuStackKind::NoExec; ---------------- MaskRay wrote: > mgorny wrote: > > MaskRay wrote: > > > MaskRay wrote: > > > > This is obvious. The comment can be removed. > > > Not done. `// default` can be deleted I think. > > You didn't give me time to upload updated patch ;-). > You had plenty of time updating the patch but you still committed without > changing this part... I'm really sorry, I thought I did that. You commented before I actually uploaded the new patch, and no comments afterwards got me confused. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
