usaxena95 added inline comments.
================
Comment at:
clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:180
+ if (ContainingNS)
+ findExplicitReferences(ContainingNS, SelectRefToQualify);
+ else
----------------
ilya-biryukov wrote:
> Do we also need to run in the redeclarations of the same namespace?
> ```
> namespace clangd {
> using namespace clang;
> }
>
> namespace clangd {
> /*clang::*/Decl* D = nullptr;
> }
> ```
Aah. Didn't know we have the redecls here itself. I had a FIXME as a negative
test for this. Fixed that now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69162/new/
https://reviews.llvm.org/D69162
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
