[PATCH] D57012: Merge similar target diagnostics for interrupt attribute into one. NFC

krisb updated this revision to Diff 182852. krisb added a comment. Applied the comment. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57012/new/ https://reviews.llvm.org/D57012 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDeclAttr.cpp Ind

[PATCH] D57012: Merge similar target diagnostics for interrupt attribute into one. NFC

krisb added a comment. @aaron.ballman Thanks! Could I ask you to commit the patch? I don't have commit access yet. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57012/new/ https://reviews.llvm.org/D57012 ___ cfe-com

[clang-tools-extra] r351788 - [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

Author: kadircet Date: Tue Jan 22 01:10:20 2019 New Revision: 351788 URL: http://llvm.org/viewvc/llvm-project?rev=351788&view=rev Log: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB. Summary: Some projects make use of clang plugins when building,

[PATCH] D56841: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rL351788: [clangd] Filter out plugin related flags and move all commandline manipulations… (authored by kadircet, committed by ). Herald added a subscriber: llvm-co

[PATCH] D56860: [clangd] NFC: Use buildCompilerInvocation in CodeComplete

kadircet updated this revision to Diff 182856. kadircet marked 2 inline comments as done. kadircet added a comment. - Moved ParseInputs and buildCompilerInvocation into Compiler.h Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56860/new/ https://revi

[PATCH] D55256: [clangd] Support clang-tidy configuration in clangd.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clangd/ClangdLSPServer.h:132 - RealFileSystemProvider FSProvider; /// Options used for code completion ilya-biryukov wrote: > hokein wrote: > > sammccall wrote: > > > ilya-bi

[clang-tools-extra] r351792 - [clangd] Support clang-tidy configuration in clangd.

Author: hokein Date: Tue Jan 22 01:39:05 2019 New Revision: 351792 URL: http://llvm.org/viewvc/llvm-project?rev=351792&view=rev Log: [clangd] Support clang-tidy configuration in clangd. Summary: This patch adds some basic supports for clang-tidy configurations in clangd: - clangd will respe

[PATCH] D55256: [clangd] Support clang-tidy configuration in clangd.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE351792: [clangd] Support clang-tidy configuration in clangd. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D55256?vs=182778&id=182862#toc Repository: rCTE C

[PATCH] D56860: [clangd] NFC: Use buildCompilerInvocation in CodeComplete

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56860/new/ https://reviews.llvm.org/D56860

[PATCH] D57042: [clangd] NFC: reduce log noise from Diagnostics.

ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D57042 Files: clangd/Diagnostics.cpp Index: clangd/Diagnostics.cpp

[clang-tools-extra] r351793 - [clangd] NFC: Use buildCompilerInvocation in CodeComplete

Author: kadircet Date: Tue Jan 22 01:58:53 2019 New Revision: 351793 URL: http://llvm.org/viewvc/llvm-project?rev=351793&view=rev Log: [clangd] NFC: Use buildCompilerInvocation in CodeComplete Reviewers: ilya-biryukov, sammccall Reviewed By: sammccall Subscribers: ioeric, MaskRay, jkorous, arph

[PATCH] D57043: [clangd] Use the shared forced-linking code.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, mgorny, srhines. Also add a missing MPI module. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D57043 Files: clangd/CMakeLi

[PATCH] D56860: [clangd] NFC: Use buildCompilerInvocation in CodeComplete

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE351793: [clangd] NFC: Use buildCompilerInvocation in CodeComplete (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D56860?vs=182856&id=182865#toc Repository:

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

balazske updated this revision to Diff 182866. balazske added a comment. - Small style corrections. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53818/new/ https://reviews.llvm.org/D53818 Files: include/clang/AST/ASTImporter.h lib/AST/ASTImporter.cpp Index

[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov updated this revision to Diff 182870. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. - Inline Tweak::Selection::create() - Define Tweak::id() in REGISTER_TWEAK. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56267/new/ https://reviews.llvm.or

[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov marked an inline comment as not done. ilya-biryukov added inline comments. Comment at: clangd/refactor/Tweak.h:40 + struct Selection { +static llvm::Optional create(llvm::StringRef File, +llvm::StringRef Code, ---

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov updated this revision to Diff 182872. ilya-biryukov added a comment. - Update id of swap branches in tests - Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56611/new/ https://reviews.llvm.org/D56611 Files: clang-tools-extra/clangd/SourceCode.cpp clang-tools-extr

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

ilya-biryukov updated this revision to Diff 182871. ilya-biryukov added a comment. - Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56610/new/ https://reviews.llvm.org/D56610 Files: clang-tools-extra/clangd/refactor/tweaks/CMakeLists.txt clang-tools-extra/clangd/refactor/twea

[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/Tweak.cpp:27 +std::vector> prepareTweaks(const Tweak::Selection &S) { +#ifndef NDEBUG + { Please note I added these assertions here

Re: r351629 - Emit !callback metadata and introduce the callback attribute

On Sat, Jan 19, 2019 at 2:18 AM Johannes Doerfert via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jdoerfert > Date: Fri Jan 18 21:36:54 2019 > New Revision: 351629 > > URL: http://llvm.org/viewvc/llvm-project?rev=351629&view=rev > Log: > Emit !callback metadata and introduce the cal

[PATCH] D56612: [clangd] A code action to remove 'using namespace'

ilya-biryukov updated this revision to Diff 182873. ilya-biryukov added a comment. - Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56612/new/ https://reviews.llvm.org/D56612 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/AST.h clang-tools-extra/clangd/ref

Re: r351629 - Emit !callback metadata and introduce the callback attribute

On Sat, Jan 19, 2019 at 2:18 AM Johannes Doerfert via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jdoerfert > Date: Fri Jan 18 21:36:54 2019 > New Revision: 351629 > > URL: http://llvm.org/viewvc/llvm-project?rev=351629&view=rev > Log: > Emit !callback metadata and introduce the cal

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

Anastasia added a comment. In D55850#1365437 , @ebevhan wrote: > I'm a bit late to the party here, it was an older patch so I wasn't watching > this one. > > I get a bit miffed when address space related features get locked behind > langoptions that aren

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

ebevhan added a comment. Okay, sounds good! I'm not a C++ expert, but I'd be happy to look at the patches when they're up. Haven't done much serious testing on my end so far, but from what I've seen the patches so far look good! Repository: rC Clang CHANGES SINCE LAST ACTION https://revie

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov updated this revision to Diff 182884. ilya-biryukov added a comment. - Use helper to avoid creating RewriteBuffer - Use std::string to fix stack corruption CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56611/new/ https://reviews.llvm.org/D56611 Files: clang-tools-extra/

[PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

schroedersi added a comment. Ping. It would indeed be very helpful to have information about the kind of an operator :-) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10833/new/ https://reviews.llvm.org/D10833 ___ c

[clang-tools-extra] r351809 - [clangd] Fix the `-Wtype-limits` warning, NFC

Author: hokein Date: Tue Jan 22 04:21:25 2019 New Revision: 351809 URL: http://llvm.org/viewvc/llvm-project?rev=351809&view=rev Log: [clangd] Fix the `-Wtype-limits` warning, NFC The assertion is always true, and triggers a compiler warning, so remove it. Modified: clang-tools-extra/trunk/cl

[PATCH] D57043: [clangd] Use the shared forced-linking code.

sammccall added inline comments. Comment at: clangd/CMakeLists.txt:110 +if( CLANG_ENABLE_STATIC_ANALYZER ) + target_link_libraries(clangDaemon PRIVATE clangd doesn't support the static analyzer. Fundamentally I don't know how to enforce the partial-traversal (

[PATCH] D57047: [clangd] Fix broken build after r351793.

ioeric created this revision. ioeric added reviewers: kadircet, sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D57047 Files: clangd/CodeComplete.cpp Index: clangd/CodeComplete.cpp ===

[clang-tools-extra] r351812 - [clangd] Fix the broken buildbot.

Author: hokein Date: Tue Jan 22 04:55:15 2019 New Revision: 351812 URL: http://llvm.org/viewvc/llvm-project?rev=351812&view=rev Log: [clangd] Fix the broken buildbot. Modified: clang-tools-extra/trunk/clangd/tool/CMakeLists.txt Modified: clang-tools-extra/trunk/clangd/tool/CMakeLists.txt URL

[clang-tools-extra] r351813 - [clangd] NFC: reduce log noise from Diagnostics.

Author: ioeric Date: Tue Jan 22 04:55:27 2019 New Revision: 351813 URL: http://llvm.org/viewvc/llvm-project?rev=351813&view=rev Log: [clangd] NFC: reduce log noise from Diagnostics. Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits Differential R

[PATCH] D57042: [clangd] NFC: reduce log noise from Diagnostics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL351813: [clangd] NFC: reduce log noise from Diagnostics. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.ll

[clang-tools-extra] r351814 - [clang-tidy] Fix whitespace in docs. NFC

Author: alexfh Date: Tue Jan 22 04:59:34 2019 New Revision: 351814 URL: http://llvm.org/viewvc/llvm-project?rev=351814&view=rev Log: [clang-tidy] Fix whitespace in docs. NFC Actually, just testing commits via monorepo ;) Modified: clang-tools-extra/trunk/docs/clang-tidy/index.rst Modified:

[PATCH] D57012: Merge similar target diagnostics for interrupt attribute into one. NFC

aaron.ballman added a comment. In D57012#1365939 , @krisb wrote: > @aaron.ballman Thanks! Could I ask you to commit the patch? I don't have > commit access yet. Happy to do so -- just to double-check: are you aware of the recent relicensing of the proj

[PATCH] D56967: Thread safety analysis: Improve diagnostics for double locking

aaron.ballman added a comment. In D56967#1365742 , @aaronpuchert wrote: > Thanks for the review! I'll commit this when I have commit access again, > which is waiting for my employer's approval to the relicensing. Sounds good to me!

Re: r351701 - Replace llvm::isPodLike<...> by llvm::is_trivially_copyable<...>

Hi, This broke our clang builds with $ gcc --version gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-36) on CentOS Linux release 7.6.1810 (Core), [ 23%] Building CXX object tools/clang/lib/Basic/CMakeFiles/clangBasic.dir/Module.cpp.o In file included from include/llvm/ADT/StringMap.h:20:0,

[PATCH] D56429: fix python3 compability issue

serge-sans-paille added a comment. @roxma: do you want me to commit this on your behalf? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56429/new/ https://reviews.llvm.org/D56429 ___ cfe-commits mailing list cfe-commi

[PATCH] D56903: [clangd] Suggest adding missing includes for incomplete type diagnostics.

ilya-biryukov added a comment. A drop-by comment. Comment at: clangd/IncludeFixer.cpp:66 + vlog("Trying to fix include for incomplete type {0}", IncompleteType); + FuzzyFindRequest Req; + Req.AnyScope = false; sammccall wrote: > limit? Why do we use fuzzyFin

[clang-tools-extra] r351818 - Fix "missing field 'ClangTidyOpts' initializer" warning. NFCI.

Author: rksimon Date: Tue Jan 22 05:35:16 2019 New Revision: 351818 URL: http://llvm.org/viewvc/llvm-project?rev=351818&view=rev Log: Fix "missing field 'ClangTidyOpts' initializer" warning. NFCI. Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp Modified: clang-tools-extra/trunk/cla

[PATCH] D56429: fix python3 compability issue

roxma added a comment. Yes please. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56429/new/ https://reviews.llvm.org/D56429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D56936: Fix handling of overriden methods during ASTImport

martong added a comment. I have found some other minor things in the tests. Comment at: unittests/AST/ASTImporterTest.cpp:2275 + auto DFDef = cxxMethodDecl( + hasName("f"), hasParent(cxxRecordDecl(hasName("B"))), isDefinition()); + auto FDefAll = cxxMethodDecl(hasName("f

[PATCH] D57032: [SemaCXX] Param diagnostic matches overload logic

cpplearner added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5092 // The parameter types are identical -if (Context.hasSameType(DefParamTy, DeclParamTy)) +if (Context.hasSameType(DefParamTy.getUnqualifiedType(), +DeclParamTy.getUnqu

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov updated this revision to Diff 182900. ilya-biryukov added a comment. - Use a helper to avoid creating RewriteBuffer CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56611/new/ https://reviews.llvm.org/D56611 Files: clang-tools-extra/clangd/SourceCode.cpp clang-tools-extr

[PATCH] D57047: [clangd] Fix broken build after r351793.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, but hokein might know better whether to push the default options or the one in ClangdServerOpts Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D57047: [clangd] Fix broken build after r351793.

ioeric added a comment. In D57047#1366265 , @kadircet wrote: > LGTM, but hokein might know better whether to push the default options or the > one in ClangdServerOpts I'm going to land this now to unbreak build. Feel free to comment or do further refac

[PATCH] D57047: [clangd] Fix broken build after r351793.

ioeric abandoned this revision. ioeric added a comment. nvm, Simon beat me to it ;) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57047/new/ https://reviews.llvm.org/D57047 ___ cfe-commits mailing list

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

Anastasia added a comment. In D55850#1366094 , @ebevhan wrote: > Okay, sounds good! I'm not a C++ expert, but I'd be happy to look at the > patches when they're up. Haven't done much serious testing on my end so far, > but from what I've seen the patches

[clang-tools-extra] r351826 - [clangd] Followup fix of rL351818

Author: hokein Date: Tue Jan 22 06:48:04 2019 New Revision: 351826 URL: http://llvm.org/viewvc/llvm-project?rev=351826&view=rev Log: [clangd] Followup fix of rL351818 ClangTidyOptions::getDefaults is not free, it will initialize all clang-tidy modules to get check-specific options, and we don't u

[PATCH] D57047: [clangd] Fix broken build after r351793.

hokein added a comment. I think it is safe to use the empty one (constructed by the default constructor) here -- since `getDefaults` is not free, and we don't need the configurations in codeComplete, fixed in rL351826 . Repository: rCTE Clang Tools Extra

[PATCH] D56984: [libunwind] Silence warnings about unused parameters

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM, but would it make sense to have a macro like `_LIBUNWIND_MAYBE_UNUSED(var)` instead? Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56984/new/ ht

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov updated this revision to Diff 182910. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Fix a typo in a comment: isValidRange -> isValidFileRange - Make action available under 'else' keywords and conditions - Move the logic of creating replacements to a

[PATCH] D56849: [ASTMatchers][NFC] Update comments on assorted `CXXMemberCallExpr` matchers.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Thanks for tidying up the docs. LG with one nit. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5018 +/// memberExpr(hasObjectExpression(hasType(cxxRecordDecl(hasN

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clangd/refactor/tweaks/SwapIfBranches.cpp:34 +/// After: +/// if (foo) { continue; } else { return 10; } +class SwapIfBranches : public Tweak { sammccall wrote: > T

[PATCH] D56540: [clangd] Clean the cache of file statuses on vscode-clangd when clangd crashes.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clangd/clients/clangd-vscode/src/extension.ts:127 +(fileStatus) => { status.onFileUpdated(fileStatus); }); +} e

[PATCH] D56539: [clangd] Drop documentation in static index if symbols are not indexed for completion.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Just realized I missed this review, sorry about that. LGTM with a nit. Comment at: clangd/index/FileIndex.cpp:51 CollectorOpts.RefFilter = RefKind::All; -

[PATCH] D57055: [RISCV] Mark TLS as supported

lewis-revill created this revision. lewis-revill added a reviewer: asb. Herald added subscribers: cfe-commits, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar. Inform Cla

[PATCH] D57055: [RISCV] Mark TLS as supported

jrtc27 requested changes to this revision. jrtc27 added inline comments. This revision now requires changes to proceed. Comment at: lib/Basic/Targets/RISCV.h:39 HasD(false), HasC(false) { -TLSSupported = false; +TLSSupported = true; LongDoubleWidth = 128; --

[PATCH] D57057: [clangd] Log clang-tidy configuration, NFC

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. This is used for debugging purpose. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D57057 Files: clangd/ClangdUnit.cpp In

[PATCH] D56849: [ASTMatchers][NFC] Update comments on assorted `CXXMemberCallExpr` matchers.

ymandel updated this revision to Diff 182918. ymandel marked an inline comment as done. ymandel added a comment. Use backticks instead of quotes for quoted code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56849/new/ https://reviews.llvm.org/D56849 Files: clang/docs/LibASTMatchersR

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

ymandel updated this revision to Diff 182919. ymandel marked an inline comment as done. ymandel added a comment. Remove unnecessary expectation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56850/new/ https://reviews.llvm.org/D56850 Files: clang/unittests/ASTMatchers/ASTMatchersTrav

[PATCH] D57055: [RISCV] Mark TLS as supported

lewis-revill updated this revision to Diff 182920. lewis-revill added a comment. Rely on default value rather than explicitly marking `TLSSupported` as true. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57055/new/ https://reviews.llvm.org/D57055 Files: lib/Ba

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

dgoldman added a comment. In D56916#1365357 , @ilya-biryukov wrote: > Good point, @aaron.ballman! @dgoldman, could you please add a test case? Unfortunately I can't get ninja check-clangd to build: /Users/davg/dev/llvm/source/llvm/tools/clang/tools/

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

dgoldman updated this revision to Diff 182921. dgoldman marked an inline comment as done. dgoldman added a comment. - use auto Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56916/new/ https://reviews.llvm.org/D56916 Files: clangd/index/SymbolColl

[PATCH] D56903: [clangd] Suggest adding missing includes for incomplete type diagnostics.

ioeric added a comment. In D56903#1365487 , @sammccall wrote: > This looks pretty good! My main concern is latency (and variability of > latency) in practice. > Particularly: > > - we should avoid paying for fuzzyfind and fetching hundreds of results when

[PATCH] D56903: [clangd] Suggest adding missing includes for incomplete type diagnostics.

ioeric updated this revision to Diff 182922. ioeric marked 15 inline comments as done. ioeric added a comment. - Address review comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56903/new/ https://reviews.llvm.org/D56903 Files: clangd/CMakeL

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

ioeric updated this revision to Diff 182925. ioeric added a comment. - Rebase on D56903 Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57021/new/ https://reviews.llvm.org/D57021 Files: clangd/ClangdUnit.cpp clan

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

ilya-biryukov added a comment. > Unfortunately I can't get ninja check-clangd to build: Looks like `clang-tools-extra` uses an old revision. Rebasing after rL350916 should do the trick. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https:

[PATCH] D56936: Fix handling of overriden methods during ASTImport

martong added a comment. Shafik, I have realized what's the problem with the `ctu-main` test. When we import the body and set the new body to the existing FunctionDecl then the parameters are still the old parameters so the new body does not refer to the formal parameters! This way the analyzer

[PATCH] D57060: [NFC][Clang] Add driver tests for sb and predres

dnsampaio created this revision. dnsampaio added a reviewer: pbarrio. Herald added subscribers: cfe-commits, javed.absar. Add tests that arguments for enabling/disabling sb and predres are correctly being or not passed by the driver. Repository: rC Clang https://reviews.llvm.org/D57060 File

[PATCH] D56936: Fix handling of overriden methods during ASTImport

martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:3046 +if (!D->doesThisDeclarationHaveABody()) + return cast(const_cast(FoundByLookup)); +else { balazske wrote: > The `cast` should not be needed here (and is not done at

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

ymandel updated this revision to Diff 182933. ymandel marked 3 inline comments as done. ymandel added a comment. Extended test of `hasObjectExpression`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56850/new/ https://reviews.llvm.org/D56850 Files: clang/unittests/ASTMatchers/ASTMatc

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

ymandel added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:558 + int m; + int f(X x) { return m; } +}; steveire wrote: > Are we missing a matcher that would reach the type of X in this case? > `h

[PATCH] D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

martong accepted this revision. martong added a comment. The updated version looks good to me! Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56651/new/ https://reviews.llvm.org/D56651 ___ cfe-commits mailing list cfe-commits@list

r351841 - ReleaseNotes: remove openmp notes from r351580

Author: hans Date: Tue Jan 22 09:01:39 2019 New Revision: 351841 URL: http://llvm.org/viewvc/llvm-project?rev=351841&view=rev Log: ReleaseNotes: remove openmp notes from r351580 They were for the 8.0 branch, and have been committed there in r351839. Modified: cfe/trunk/docs/ReleaseNotes.rst

Re: r351580 - [OPENMP][DOCS] Release notes/OpenMP support updates, NFC.

Thanks, I've merged it to 8.0 in r351839. Since the release notes are for 8.0 and not trunk, I've removed the change from trunk in r351841. On Fri, Jan 18, 2019 at 12:05 PM Kelvin Li wrote: > > Hi Hans, > > I am not sure if it is the proper way to request the change committed > to the release_80

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

ilya-biryukov added a comment. Thanks for the suggestion, this should definitely work! I did struggle to figure out a way to do this without annotating every path with `enterUnknown` and failed. I'll try playing around with your idea, my initial plan is to store preferred type alongside the cur

Re: r351629 - Emit !callback metadata and introduce the callback attribute

On 01/22, Chandler Carruth wrote: > On Sat, Jan 19, 2019 at 2:18 AM Johannes Doerfert via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > Author: jdoerfert > > Date: Fri Jan 18 21:36:54 2019 > > New Revision: 351629 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=351629&view=rev > >

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan added a comment. @rsmith Any comments on this patch before submitting? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55447/new/ https://reviews.llvm.org/D55447 ___ cfe-commits mailing list cfe-commits@lis

Re: r351629 - Emit !callback metadata and introduce the callback attribute

On 01/22, Chandler Carruth wrote: > On Sat, Jan 19, 2019 at 2:18 AM Johannes Doerfert via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > Author: jdoerfert > > Date: Fri Jan 18 21:36:54 2019 > > New Revision: 351629 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=351629&view=rev > >

r351849 - [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

Author: teemperor Date: Tue Jan 22 09:59:45 2019 New Revision: 351849 URL: http://llvm.org/viewvc/llvm-project?rev=351849&view=rev Log: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl Summary: Shafik found out that importing a CXXConstructorDecl will create a translation unit

[PATCH] D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rC351849: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl (authored by teemperor, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56651/new/

[PATCH] D57004: [docs] Add release notes for notable things I've contributed since last release

hans accepted this revision. hans added inline comments. This revision is now accepted and ready to land. Comment at: docs/ReleaseNotes.rst:190 +- For MinGW, clang now produces vtables and RTTI for dllexported classes + without key functions. + mstorsjo wrote: >

[PATCH] D57004: [docs] Add release notes for notable things I've contributed since last release

rnk added inline comments. Comment at: docs/ReleaseNotes.rst:190 +- For MinGW, clang now produces vtables and RTTI for dllexported classes + without key functions. + hans wrote: > mstorsjo wrote: > > This comment doesn't really say much for the casual reader, pe

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

dgoldman updated this revision to Diff 182942. dgoldman added a comment. Herald added a subscriber: jfb. - FIXME and dyn_cast - use auto - Add test Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56916/new/ https://reviews.llvm.org/D56916 Files: cl

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

dgoldman added a comment. In D56916#1366456 , @ilya-biryukov wrote: > > Unfortunately I can't get ninja check-clangd to build: > > Looks like `clang-tools-extra` uses an old revision. Rebasing after rL350916 > should d

[PATCH] D56946: [Documentation] Use HTTPS whenever possible in Clang

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Seems like a good change to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56946/new/ https://reviews.llvm.org/D56946 ___

[PATCH] D55676: [Modules] Fix decl order for DeclsInPrototype

bruno added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55676/new/ https://reviews.llvm.org/D55676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r351788 - [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

This has been merged to the 8.0 branch in r351860. Please let me know if there are any follow-ups so they can be merged too. Thanks, Hans On Tue, Jan 22, 2019 at 1:10 AM Kadir Cetinkaya via cfe-commits wrote: > > Author: kadircet > Date: Tue Jan 22 01:10:20 2019 > New Revision: 351788 > > URL:

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan updated this revision to Diff 182945. leonardchan marked 6 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56900/new/ https://reviews.llvm.org/D56900 Files: clang/include/clang/AST/OperationKinds.def clang/include/clang/Basic

[clang-tools-extra] r351862 - [Documentation] Use HTTPS whenever possible.

Author: eugenezelenko Date: Tue Jan 22 11:19:48 2019 New Revision: 351862 URL: http://llvm.org/viewvc/llvm-project?rev=351862&view=rev Log: [Documentation] Use HTTPS whenever possible. Differential revision: https://reviews.llvm.org/D56926 Modified: clang-tools-extra/trunk/docs/clang-doc.rst

[PATCH] D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE351862: [Documentation] Use HTTPS whenever possible. (authored by eugenezelenko, committed by ). Changed prior to commit: https://reviews.llvm.org/D56926?vs=182590&id=182947#toc Repository: rCTE Cl

[PATCH] D55400: [analyzer] Move out tracking retain count for OSObjects into a separate checker

george.karpenkov added a comment. > Deal with the consequences of this, and just correct all plist files to now > refer to the new base checker. What does it mean? > Each time a report is emitted from these checkers, create a ProgramPointTag, > and "manually" make sure the emitted checker name

[PATCH] D55676: [Modules] Fix decl order for DeclsInPrototype

rsmith added inline comments. Comment at: lib/Parse/ParseDecl.cpp:6237 +llvm::sort(SortedDecls, [](const Decl *L, const Decl *R) { + return L->getID() < R->getID(); +}); I would prefer that we use `getID` only for debug dumping purposes. Can we chan

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

rjmccall added a comment. I'll just add that we've been trying to not put things behind OpenCL guards as much as possible. Most of the remaining OpenCL checks are for OpenCL-specific logic like inferring the default address space, and yeah, we could probably make that a target option or someth

r351864 - [analyzer] Model another special-case kind of cast for OSObject RetainCountChecker

Author: george.karpenkov Date: Tue Jan 22 11:50:47 2019 New Revision: 351864 URL: http://llvm.org/viewvc/llvm-project?rev=351864&view=rev Log: [analyzer] Model another special-case kind of cast for OSObject RetainCountChecker Differential Revision: https://reviews.llvm.org/D56951 Modified:

r351865 - [analyzer] Insert notes in RetainCountChecker where our dynamic cast modeling assumes 'null' output

Author: george.karpenkov Date: Tue Jan 22 11:51:00 2019 New Revision: 351865 URL: http://llvm.org/viewvc/llvm-project?rev=351865&view=rev Log: [analyzer] Insert notes in RetainCountChecker where our dynamic cast modeling assumes 'null' output rdar://47397214 Differential Revision: https://revie

[PATCH] D57062: [analyzer] Re-enable the "System is over constrained" assertion on optimized builds.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, george.karpenkov, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet. This assertion was only enabled in Debug+Asserts, not on Relea

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

philip.pfaffe added a comment. This generally looks sane. What will happen on windows though? Will it silently fail? Comment at: clang/include/clang/Basic/CodeGenOptions.h:292 + /// List of dynamic shared object files to be loaded as pass plugins. + std::vector PassPlugins;

[clang-tools-extra] r351867 - [doc] Replace 'class' with 'struct' for 'public' by default

Author: zinovy.nis Date: Tue Jan 22 12:27:02 2019 New Revision: 351867 URL: http://llvm.org/viewvc/llvm-project?rev=351867&view=rev Log: [doc] Replace 'class' with 'struct' for 'public' by default Make sample syntax correct. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/bugprone

[PATCH] D57004: [docs] Add release notes for notable things I've contributed since last release

This revision was automatically updated to reflect the committed changes. Closed by commit rL351872: [docs] Add release notes for notable things I've contributed since last release (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

  1   2   >