Anastasia added a comment. In D55850#1365437 <https://reviews.llvm.org/D55850#1365437>, @ebevhan wrote:
> I'm a bit late to the party here, it was an older patch so I wasn't watching > this one. > > I get a bit miffed when address space related features get locked behind > langoptions that aren't strictly address spaces. I know that there are > currently a couple code snippets which are behind LangOptions.OpenCL, that > are needed for address spaces to work reasonably even when you aren't using > OpenCL. > > I guess I do understand that the only address spaces that are interesting to > parse here are the named qualifier ones, but it would be convenient if the > parsing would accept other ones as well (such as the `__attribute__` based > ones) and not necessarily assume that the user is using OpenCL++. > > EDIT: Sort of jumped the gun there... The summary even says "This patch > doesn't enable the feature for C++ yet but it can easily be generalized if > the overall flow is right." Don't mind me. This is correct. My plan was to generalize to C++ in the next patch. As I am more familiar with OpenCL and many rules are already well defined, this was my starting point. However, I want this work to be used for C++ based implementations generically and not just for OpenCL. I am still struggling to understand the semantic of address spaces in C++ for some cases and need a little bit more time, but I think I should be able to upload the initial patch soon. I would then appreciate any help with reviewing to get it right! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55850/new/ https://reviews.llvm.org/D55850 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
