ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Just realized I missed this review, sorry about that.
LGTM with a nit.
================
Comment at: clangd/index/FileIndex.cpp:51
CollectorOpts.RefFilter = RefKind::All;
- }else {
+ CollectorOpts.StoreAllDocumentation = false;
+ } else {
----------------
NIT: maybe mention the rationale here in a comment? Something like `// comments
for main file can always be obtained from sema, do not store them in the index.`
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56539/new/
https://reviews.llvm.org/D56539
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
