hans accepted this revision.
hans added inline comments.
This revision is now accepted and ready to land.


================
Comment at: docs/ReleaseNotes.rst:190
+- For MinGW, clang now produces vtables and RTTI for dllexported classes
+  without key functions.
+
----------------
mstorsjo wrote:
> This comment doesn't really say much for the casual reader, perhaps it should 
> just be left out and regarded as general assorted bugfixes? Although the fix 
> (D55698) is a notable step towards matching GCC better for MinGW, and fixes 
> an actual issue (building Qt in debug mode).
I think keeping it in is fine. If you want you could of course expand with 
mentioning the Qt part of your comment and maybe link to a bug entry if 
applicable.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57004/new/

https://reviews.llvm.org/D57004



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to