On Thu, Apr 26, 2018 at 12:29:21PM +0200, Solene Rapenne wrote:
>
> Landry Breuil writes:
>
> > On Thu, Apr 26, 2018 at 10:38:44AM +0200, Solene Rapenne wrote:
> > More points:
> >
> > - Please use lowercase M in the port name (ie mail/mailpile)
> > - i think its simpler for you to rm the files you dont want in
> > do-install (since you already have that target) instead of manually
> > @comment'ing them in the PLIST..
> > - RUN_DEPENDS should use MODPY_RUN_DEPENDS instead of hardcoding
> > lang/python/2.7
> >
> > Landry
>
> I renamed mail/Mailpile to mail/mailpile but the package name will stay
> Mailpile (because GH_PROJECT=Mailpile), is it required to use a
> lowercase m for the package name as well ?
Not really, but that all depends on best practices. Iirc we have
historically some pkgname starting by an uppercase letter when upstream
insists on the naming, (like math/R for example, or
ImageMagick/GraphicsMagick) but to me those are historic and most recent
imports were all lowercase - to see a list, the shortest ive found is the
following:
$echo 'select pkgname from ports where
substr(pkgname,1,1)!=lower(substr(pkgname,1,1));' |sqlite3
/usr/local/share/sqlports
which only yields 40 pkgnames starting with an uppercase letter.
> I removed lots of @comment lines by rm -fr some folders in do-install
> but I kept @comments for excluding lots of singles files, I find it more
> readable that way.
Your call as maintainer :)
> for RUN_DEPENDS, jca@ pointed me that using MODULE= lang/python is
> already including lang/python/2.7 in RUN_DEPENDS.
See, simpler. Looks okay to me portswise, havent tested it thought, with
a preference for a lowercase pkgname (i often use PKGNAME=
${DISTNAME:L})
Landry
