Landry Breuil writes:

> On Thu, Apr 26, 2018 at 10:38:44AM +0200, Solene Rapenne wrote:
> More points:
>
> - Please use lowercase M in the port name (ie mail/mailpile)
> - i think its simpler for you to rm the files you dont want in
>   do-install (since you already have that target) instead of manually
> @comment'ing them in the PLIST..
> - RUN_DEPENDS should use MODPY_RUN_DEPENDS instead of hardcoding
>   lang/python/2.7
>
> Landry

I renamed mail/Mailpile to mail/mailpile but the package name will stay
Mailpile (because GH_PROJECT=Mailpile), is it required to use a
lowercase m for the package name as well ?

I removed lots of @comment lines by rm -fr some folders in do-install
but I kept @comments for excluding lots of singles files, I find it more
readable that way.

for RUN_DEPENDS, jca@ pointed me that using MODULE= lang/python is
already including lang/python/2.7 in RUN_DEPENDS.

I added myself as MAINTAINER.

latest tarball attached.

Attachment: mailpile.tar.gz
Description: mailpile

Reply via email to