On Thu, Apr 26, 2018 at 10:38:44AM +0200, Solene Rapenne wrote:
>
> Jeremie Courreges-Anglas writes:
>
> > Looks good, ports-specific nits only:
> > - license seems to be AGPLv3+
> > - please add devel/py-fasteners and security/gnupg to RUN_DEPENDS
> > - please add ${RUN_DEPENDS} to TEST_DEPENDS
> > - post-install can be folded into do-install
> > - patch-scripts_test-sendmail_sh should not hardcode /usr/local but use
> > ${LOCALBASE} instead
>
> I fixed all the points, tarball attached
More points:
- Please use lowercase M in the port name (ie mail/mailpile)
- i think its simpler for you to rm the files you dont want in
do-install (since you already have that target) instead of manually
@comment'ing them in the PLIST..
- RUN_DEPENDS should use MODPY_RUN_DEPENDS instead of hardcoding
lang/python/2.7
Landry
