On Fri, Sep 20, 2013 at 01:56:07PM +0200, Juan Francisco Cantero Hurtado wrote:
> On Thu, Sep 19, 2013 at 04:19:34PM -0600, Kyle R W Milz wrote:
> > ports@,
> >
> > Attached is an attempt at a port for radeontop, a top like program
> > showing GPU utilization on radeon cards >=R600.
> >
> > It's quite the hack and I'm positive I'm doing some things wrong
> > including but not limited to
> >
> > 1) Getting tarball off of github and the name of the distfile itself
> > (v0.6)
> >
> > 2) Patching of the Makefile to link to libintl properly
> >
> > 3) Patching of the Makefile to install files properly
> >
> > If anyone could take a look and give feedback I would gladly appreciate.
>
> I've not tested the port but here are some comments.
>
> The patch is wrong:
> - Add CPPFLAGS and LDFLAGS to the Makefile of the port. Use "MAKE_ENV"
> to set the flags.
done
> - Use "${LOCALBASE}" instead of "/usr/local".
done
> - Why are you removing "DESTDIR"?
I was having difficulty during `make package', it kept wanting to
install to
/usr/ports/pobj/radeontop-0.6/fake-amd64//usr/ports/pobj/radeontop-0.6/fake-amd64/usr/local/*
which obviously is wrong.
Got around that with setting DESTDIRNAME = / this time around however
I'm unsure if this is the correct way. I think PREFIX might be getting
fucked up or something.
> - Trim LDFLAGS from the makefile of the software. We don't want extra
> optimizations. The same for "-Os".
ok I left -Wl in there but trimmed the rest, I think the "-Os" is
harmless because it's a conditional assignment ( ?= ) and CFLAGS is set
already.
> - Don't install the binary to "sbin", use "bin" instead.
This thing needs to be run as root as it mmaps /dev/mem, is it still
suitable for bin/ ? I did as you asked anyways.
> Makefile of the port:
> - Don't start COMMENT with capital letters. Also COMMENT is weird, use
> something like "top like program for radeon GPUs" or similar.
done
> - You don't need EXTRACT_SUFX for .tar.gz files.
done
> - Change "VERSION" to "V".
done
> - Change the DISTNAME to "radeontop-${V}".
done
> - Use https://github.com/clbr/radeontop/archive/v${V}/ in MASTER_SITES.
done, thanks for this. This is why I was doing the empty EXTRACT_SUFX
and WRKDIST dance.
> - Remove PKGNAME.
done
> - Remove WRKDIST.
done
> - Remove "\" from MODULES.
done
> --
> Juan Francisco Cantero Hurtado http://juanfra.info
>
