On Thu, Sep 19, 2013 at 04:19:34PM -0600, Kyle R W Milz wrote:
> ports@,
>
> Attached is an attempt at a port for radeontop, a top like program
> showing GPU utilization on radeon cards >=R600.
>
> It's quite the hack and I'm positive I'm doing some things wrong
> including but not limited to
>
> 1) Getting tarball off of github and the name of the distfile itself
> (v0.6)
>
> 2) Patching of the Makefile to link to libintl properly
>
> 3) Patching of the Makefile to install files properly
>
> If anyone could take a look and give feedback I would gladly appreciate.
I've not tested the port but here are some comments.
The patch is wrong:
- Add CPPFLAGS and LDFLAGS to the Makefile of the port. Use "MAKE_ENV"
to set the flags.
- Use "${LOCALBASE}" instead of "/usr/local".
- Why are you removing "DESTDIR"?
- Trim LDFLAGS from the makefile of the software. We don't want extra
optimizations. The same for "-Os".
- Don't install the binary to "sbin", use "bin" instead.
Makefile of the port:
- Don't start COMMENT with capital letters. Also COMMENT is weird, use
something like "top like program for radeon GPUs" or similar.
- You don't need EXTRACT_SUFX for .tar.gz files.
- Change "VERSION" to "V".
- Change the DISTNAME to "radeontop-${V}".
- Use https://github.com/clbr/radeontop/archive/v${V}/ in MASTER_SITES.
- Remove PKGNAME.
- Remove WRKDIST.
- Remove "\" from MODULES.
--
Juan Francisco Cantero Hurtado http://juanfra.info
