On Fri, Sep 20, 2013 at 01:08:32PM +0100, Stuart Henderson wrote:
> On 2013/09/20 13:20, Dmitrij D. Czarkoff wrote:
> > On Thu, Sep 19, 2013 at 04:19:34PM -0600, Kyle R W Milz wrote:
> > > 1) Getting tarball off of github and the name of the distfile itself
> > > (v0.6)
> >
> > You might want to use DIST_SUBDIR (see bsd.port.mk(5)). BTW, is it really
> > necessary to hide file suffix?
> >
> > > 2) Patching of the Makefile to link to libintl properly
> > >
> > > 3) Patching of the Makefile to install files properly
> >
> > While you are at patching Makefile anyway, why not patch away all the CFLAGS
> > stuff that is not needed (eg. it forces "-Wall", which may go against local
> > settings). FWIW I would probably replace the original Makefile with a custom
> > one.
> >
> > --
> > Dmitrij D. Czarkoff
> >
>
> - no problem with the -W's in CFLAGS, but the hardcoded /usr/local
> should pick up LOCALBASE instead (will need to be patched using SUBST_CMD
> etc).
> I see no reason to replace with a custom Makefile, that is more likely
> to cause problems at update time
OK I changed hardcoded /usr/local to ${LOCALBASE} and used MAKE_ENV
instead of patching Makefile.
> - lowercase start of COMMENT
Done
> - stray \ at end of MODULES
Done
> - follow Makefile.template ordering of variables e.g. WANTLIB is in
> the wrong place (goes below PERMIT_..), makes it easier when we do bulk
> work on the tree
Done
