On Thu, Jun 20, 2013 at 05:53:27PM +0100, Stuart Henderson wrote:
>
> I would actually go the other way, make PKGNAME be ag-$VERSION,
> and put "the_silver_searcher" or similar in the COMMENT, this is a
> very awkward PKGNAME for somebody to type..
>
I am reluctant to rename the package, because it is called like this
(the_silver_searcher) in many other package systems. Including FreeBSD
ports [1], and other Linux package systems including those of Gentoo and
Feodra [2] [3].
So for the sake of consistency it will remain the_silver_searcher.
> > Be more precise with what license it is. License is Apache 2.0.
> >
> > Don't use DISTFILES since you're only pulling one item.
> > Instead, try:
> > DISTNAME = ${V}
>
> this filename format (versionnumber.tar.gz) isn't acceptable directly
> in the distfiles directory.
>
Is there any way I can rename it using the ports framework? The problem
is that this tarball comes from GitHub. Github names those archives
based on a git tag ${TAGNAME}.tar.gz instead of
${REPONAME}-${TAGNAME}.tar.gz.
> Florian, can you talk to upstream about making a real release tarball
> with a proper generated configure script?
>
I tried to mail the author of the software but he hasn't replied within
a week.
> separate lines yes, but use
>
> ${MODGNU_AUTOCONF_DEPENDS}
> ${MODGNU_AUTOMAKE_DEPENDS}
>
> (but only needed if it's impossible to get upstream to put a bit
> more love into their code ;)
>
> patch to remove the line in build.sh which runs configure, it is
> running it with incorrect arguments for the ports tree.
>
> use CONFIGURE_STYLE=gnu, get rid of CONFIGURE_SCRIPT, CONFIGURE_ENV.
>
> do keep AUTOCONF_VERSION and AUTOMAKE_VERSION.
>
> use a post-patch target to run autoconf/automake etc.:
>
> cd ${WRKSRC} && AUTOCONF_VERSION=${AUTOCONF_VERSION}
> AUTOMAKE_VERSION=${AUTOMAKE_VERSION} ./build.sh
>
> as before, all this stuff is not needed if upstream will make a
> proper release.
>
Thanks for the suggestions to make this build a bit more sane.
Regards,
Florian
[1] http://www.freshports.org/textproc/the_silver_searcher/
[2] http://gpo.zugaina.org/sys-apps/the_silver_searcher/ChangeLog
[3] http://pkgs.org/download/the_silver_searcher
