On 6/20/2013 11:57 AM, Florian Stinglmayr wrote:
Hi list,
as my first OpenBSD port I ported the the_silver_searcher aka "ag". It
is a command line utility similar to grep to aid searching for text
within files. It has a focus on searching through source code, as it,
for example, ignores files listed in git and mercurial repository ignore
files.
Comments and feedback highly appreciated and anticipated.
Regards,
Florian
Comments:
This might be my personal preference, but variables should be like this:
VARIABLE <space> = <tab> whatever
Makes reading easier.
More formatting, I would look at
ports/infrastructure/templates/Makefile.template and rearrange variables
according to that. (i.e. put WANTLIB between PERMIT_PACKAGE_CDROM and
MASTER_SITES)
COMMENT should be: code searching tool, with a focus on speed (ag)
so that people who only know the software as ag doing 'make search
key=ag' will find it.
Be more precise with what license it is. License is Apache 2.0.
Don't use DISTFILES since you're only pulling one item.
Instead, try:
DISTNAME = ${V}
PKGNAME = the_silver_searcher-${V}
Remove EXTRACT_SUFX, .tar.gz is the default.
More personal preference, but put each DEPEND on their own line, like this:
BUILD_DEPENDS = devel/autoconf/2.59 \
devel/automake/1.9 \
devel/pcre
Make reading easier.
Drop devel/gmake from BUILD_DEPENDS, USE_GMAKE=Yes implies that.
Drop USE_GMAKE=Yes, you don't need it (and you weren't using it, as I'll
explain later).
Remove the second declaration of AUTOCONF_VERSION and AUTOMAKE_VERSION.
The declaration in CONFIGURE_ENV is enough.
Someone smarter than me might have something to say about
CONFIGURE_STYLE, but as-is it's wrong. 'make configure' is also building
the program. The last line of build.sh is make - meaning you weren't
using gmake (and you don't need it). So remove the last line from
build.sh and regen patches. Again, someone smarter than me might chime
in with a better fix.
You need NO_TEST=Yes.
That's all I can think of at the moment.
~Brian
