enriquem updated this revision to Diff 57394. enriquem added a comment.
I addressed your comments. Sorry for the careless coding in what spaces are concerned. BTW, I added a missing QStringLiteral. I believe the combobox size constraints are fixed now (although I liked it better before). CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=57294&id=57394 REVISION DETAIL https://phabricator.kde.org/D18394 AFFECTED FILES vpn/openconnect/CMakeLists.txt vpn/openconnect/nm-openconnect-service.h vpn/openconnect/openconnectauth.cpp vpn/openconnect/openconnectauth.h vpn/openconnect/openconnectauthworkerthread.cpp vpn/openconnect/openconnectauthworkerthread.h vpn/openconnect/openconnectprop.ui vpn/openconnect/openconnectwidget.cpp vpn/openconnect/openconnectwidget.h To: enriquem, jgrulich Cc: pino, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart