jgrulich added a comment.
In D18394#445224 <https://phabricator.kde.org/D18394#445224>, @enriquem wrote: > In D18394#444795 <https://phabricator.kde.org/D18394#444795>, @jgrulich wrote: > > > 1. I'm not sure if the UI for openconnect tokens is correct, I think the QLineEdit for token secret should be on the same line, and you should probably use PasswordField instead? It can be our PasswordField widget from libs/editor/widgets/. Or it's not secret in the same sense as other secrets and it will not need to be saved by secret agent, like rest of passwords? I would also follow nm-connection-editor and make tokens options visible in the main UI, not under specific button. > > > a) I don't see any need for the QComboBox and theQLineEdit to be in the same line, but that's a matter of taste, not functionality. Both fields are sort of independent: same key works with different OTP options. All forms in the kcm use "Label: input" so I would like all the options to follow same pattern. > b) I agree on the PasswordField, although this being an OTP it really does not matter if anyone sees it. Ok, then I guess leave it as it is now. > c) No need to save it. It is used and discarded Doesn't seem to be true, when I save token secret, I see it is saved in NetworkManager so in this case PasswordField should be used and there should be an option to store it either to NM or secret agent. > d) I tried putting all options in the main UI. This made the window too tall for the allocated space, so that resizing was necessary or the main window initial size ought be changed. It looked ugly to me. That's why I opted for a separate dialog. I can change it if you think it is important, but, again, it looks ugly to me. In that case use a different button label, something like "Token Authentication". REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18394 To: enriquem, jgrulich Cc: pino, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
