enriquem added a comment.
> ! In D18394#445411 <https://phabricator.kde.org/D18394#445411>, @jgrulich wrote: > All forms in the kcm use "Label: input" so I would like all the options to follow same pattern. OK. >> b) I agree on the PasswordField, although this being an OTP it really does not matter if anyone sees it. > > Ok, then I guess leave it as it is now. > >> c) No need to save it. It is used and discarded > > Doesn't seem to be true, when I save token secret, I see it is saved in NetworkManager so in this case PasswordField should be used and there should be an option to store it either to NM or secret agent. I was wrong in the two points above. The token secret is needed for automatic generation of the OTP. The OTP will not be shown in the connection dialog. I changed the behavior, to enable password options, but that conflicts with NetworkManager (I guess this is like any other vpn setting). >> d) I tried putting all options in the main UI. This made the window too tall for the allocated space, so that resizing was necessary or the main window initial size ought be changed. It looked ugly to me. That's why I opted for a separate dialog. I can change it if you think it is important, but, again, it looks ugly to me. > > In that case use a different button label, something like "Token Authentication". OK. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18394 To: enriquem, jgrulich Cc: pino, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
