jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.
Just fix those minor issues, otherwise it looks good to me, I'll verify on
Monday, but I believe it's safe to push this.
INLINE COMMENTS
> openconnectauth.cpp:287
> + ret = __openconnect_set_token_mode(d->vpninfo,
> OC_TOKEN_MODE_STOKEN, tokenSecret);
> + } else if (d->tokenMode ==QStringLiteral("stokenrc")) {
> + ret = __openconnect_set_token_mode(d->vpninfo,
> OC_TOKEN_MODE_STOKEN, NULL);
Missing space after "==".
> openconnectauth.cpp:293
> +#if OPENCONNECT_CHECK_VER(3,4)
> + else if (d->tokenMode == QStringLiteral("hotp") &&
> !tokenSecret.isEmpty()) {
> + ret = __openconnect_set_token_mode(d->vpninfo,
> OC_TOKEN_MODE_HOTP, tokenSecret);
And here is one additional space after "=="
> openconnecttoken.ui:36
> + <property name="sizeAdjustPolicy">
> + <enum>QComboBox::AdjustToContents</enum>
> + </property>
I think this combobox should be expanded across whole width.
> openconnectwidget.cpp:132
> + d->tokenUi.leTokenSecret->setToolTip("Insert the secret here, with a
> sha specification and a leading '0x' or 'base32:'. See the openconnect
> documentation for syntax.");
> + } else if (mode ==QStringLiteral("hotp")) {
> + d->tokenUi.leTokenSecret->setEnabled(true);
Missing space after "=="
REVISION DETAIL
https://phabricator.kde.org/D18394
To: enriquem, jgrulich
Cc: pino, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
