McPain added inline comments. INLINE COMMENTS
> davidedmundson wrote in soliddeviceengine.cpp:555 > not sure you need this timer > > 1. You should still get the job finishing with error ERR_SERVER_TIMEOUT. > (untested, but the protocol manager in the client does have some stuff doing > this) > > 2. if you don't get a progress bar for a drive that's frozen anyway, do you > really care? There are solutions to notify user about stuck FS without that timer, right? > davidedmundson wrote in soliddeviceengine.cpp:560 > We don't know which window will be active when this timer fires. Which means > the behavior to dismiss is somewhat random. I tested it - works for me. REVISION DETAIL https://phabricator.kde.org/D14895 To: McPain, broulik, ngraham, davidedmundson Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
