broulik added inline comments.
INLINE COMMENTS
> subdiff wrote in ListItemBase.qml:135
> How does it break accessibility?
- Missing `Accessible`
- Cannot be tabbed to
- Doesn't have a proper hover effect
- Has no tooltip
etc etc
> ListItemBase.qml:145
> + onClicked: contextMenu.show(parent.x, parent.y +
> parent.height)
> + onEntered: parent.opacity = 0.8
> + onExited: parent.opacity = 1
Don't mess with the opacity, use the `active` property on `IconItem` which will
have `KIconLoader` use the correct hover state (you could have configured it to
tint the icon instead etc)
> ListItemBase.qml:273
> + var menuItem = newMenuItem();
> + menuItem.text = i18n("Default");
> + menuItem.checkable = true;
Please add some context for translators
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D4751
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: subdiff, #plasma, drosca, Zren
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol
