drosca added inline comments.
INLINE COMMENTS
> ListItemBase.qml:135
> +
> + PlasmaCore.IconItem {
> + source: "application-menu"
As @Zren pointed out, please change it to ToolButton. This is actually a
button, so there is no reason to make it IconItem + MouseArea. Also as it is
now, it breaks accessibility.
> Zren wrote in ListItemBase.qml:283
> I prefer `if (Ports.length > 0)` since that's how you'd read it in English.
> You wouldn't ask "is 0 less than the number of ports".
Also, at least in plasma code, `(var > 2)` is used everywhere, so please change
it.
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D4751
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: subdiff, #plasma, drosca, Zren
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
