drosca added inline comments.

INLINE COMMENTS

> subdiff wrote in ListItemBase.qml:135
> How does it break accessibility?

You would need to manually set Accessible.role to Accessible.Button and other 
properties, but that's not really the main issue I have with that. This is 
clickable button, so it should be (and look like) button Item, for the 
consistency sake.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4751

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma, drosca, Zren
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Reply via email to