> On Dec. 17, 2015, 1:43 a.m., Lamarque Souza wrote: > > Ship It!
So how do i get this checked in? The tutorial just says "If your patch was accepted, congratulations! :)" ^^ https://techbase.kde.org/Contribute/Send_Patches - René ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125266/#review89632 ----------------------------------------------------------- On Dec. 17, 2015, 8:40 p.m., René Fürst wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125266/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 8:40 p.m.) > > > Review request for Network Management and Plasma. > > > Repository: plasma-nm > > > Description > ------- > > Authentication with certificates / Make MRU/MTU editable / Dialog fix > > > Diffs > ----- > > vpn/l2tp/l2tp.ui bf35d02 > vpn/l2tp/l2tpppp.ui 3c70165 > vpn/l2tp/l2tppppwidget.cpp ffe2c2b > vpn/l2tp/l2tpwidget.h a161b53 > vpn/l2tp/l2tpwidget.cpp a4ff42f > vpn/l2tp/nm-l2tp-service.h ac2ecc9 > > Diff: https://git.reviewboard.kde.org/r/125266/diff/ > > > Testing > ------- > > This patch contains 3 things: > 1) Add authentication with certificates > 2) Make MRU/MTU editable > 3) Fix an issue where PPP/Advanced settings were lost when the dialogs were > not opened > > The base for 1) and 2) was added to NetworkManager-l2tp here > https://github.com/frenetic1/NetworkManager-l2tp/commit/8103cf09e2cda19d701a48331eba069ff4c8e82c > > > File Attachments > ---------------- > > Patch without indent changes > > https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/e492aabf-c098-4ea7-bff0-30a13cc3fdda__cert_mru_mtu_dialog_fix4_noindent.diff > > > Thanks, > > René Fürst > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
