> On Dez. 13, 2015, 12:50 vorm., Lamarque Souza wrote: > > vpn/l2tp/l2tpwidget.cpp, line 107 > > <https://git.reviewboard.kde.org/r/125266/diff/1/?file=404334#file404334line107> > > > > Use QStringLiteral("yes") instead of just "yes". Add brackets after the > > parentesis and space after if.
Actually, for comparison prefer QLatin1String. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125266/#review89404 ----------------------------------------------------------- On Dez. 12, 2015, 11:11 nachm., René Fürst wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125266/ > ----------------------------------------------------------- > > (Updated Dez. 12, 2015, 11:11 nachm.) > > > Review request for Network Management and Plasma. > > > Repository: plasma-nm > > > Description > ------- > > Authentication with certificates / Make MRU/MTU editable / Dialog fix > > > Diffs > ----- > > vpn/l2tp/l2tpwidget.cpp b278228 > vpn/l2tp/nm-l2tp-service.h ac2ecc9 > vpn/l2tp/l2tpwidget.h 1e4c383 > vpn/l2tp/l2tppppwidget.cpp ffe2c2b > vpn/l2tp/l2tp.ui 22b9f73 > vpn/l2tp/l2tpppp.ui 7e4fea3 > > Diff: https://git.reviewboard.kde.org/r/125266/diff/ > > > Testing > ------- > > This patch contains 3 things: > 1) Add authentication with certificates > 2) Make MRU/MTU editable > 3) Fix an issue where PPP/Advanced settings were lost when the dialogs were > not opened > > The base for 1) and 2) was added to NetworkManager-l2tp here > https://github.com/frenetic1/NetworkManager-l2tp/commit/8103cf09e2cda19d701a48331eba069ff4c8e82c > > > Thanks, > > René Fürst > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
