On Tuesday 28 October 2008, Guillaume Pothier wrote:
> 2008/10/29 Aaron J. Seigo <[EMAIL PROTECTED]>:
> > On Tuesday 28 October 2008, Guillaume Pothier wrote:
> >> to have the corona register itself when created. Ok to commit?
> >
> > getting closer =)
>
> Cool :-)
>
> > first, the patch needs to guard against containment() and/or corona()
> > being 0.
>
> Do we need to check that each time corona is used? Isn't that a bug if
> we have no corona/containment?

*thinks*

technically, none of that code should be triggered if there is no corona. soo 
... put some asserts in there instead?

> > Plasma::Corona *c = m_applet->corona();
>
> That would be Plasma::Corona *c = m_applet()->containment() ?
> m_applet()->containment()->corona() : 0;

right =)

> What do we do about the ugly ToolTipManager stuff?

i think that's ok...

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to