2008/10/29 Aaron J. Seigo <[EMAIL PROTECTED]>: > On Tuesday 28 October 2008, Guillaume Pothier wrote: >> to have the corona register itself when created. Ok to commit? > > getting closer =)
Cool :-) > > first, the patch needs to guard against containment() and/or corona() being 0. Do we need to check that each time corona is used? Isn't that a bug if we have no corona/containment? > Plasma::Corona *c = m_applet->corona(); That would be Plasma::Corona *c = m_applet()->containment() ? m_applet()->containment()->corona() : 0; Or do you mean we should add those helper methods? I'm still in favor of it, but you're the boss ;-) What do we do about the ugly ToolTipManager stuff? Cheers, g > menu.exec(c ? c->popupPosition(this, menu.size()) : e->screenPos()); > > also Corona::screenGeometry should have a Q_UNUSED(id) to avoid a compiler > warning. > > so, some small implementation fixes, but i like how simple this makes things > while removing QDesktopWidget use from libplasma. after the above changes are > made, pls commit. > > -- > Aaron J. Seigo > humru othro a kohnu se > GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 > > KDE core developer sponsored by Qt Software > > > _______________________________________________ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
